From 1ae5f7978788ac5192b19bb3da791bb27c7b2d89 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Fri, 3 Nov 2017 15:09:32 +0200 Subject: loplugin:finalclasses in editeng Change-Id: I3cf074d101311e516ee1ce23ad032225780f3e25 Reviewed-on: https://gerrit.libreoffice.org/44314 Tested-by: Jenkins Reviewed-by: Noel Grandin --- editeng/inc/edtspell.hxx | 3 +-- editeng/source/editeng/eertfpar.hxx | 3 +-- editeng/source/editeng/textconv.hxx | 3 +-- include/editeng/borderline.hxx | 3 +-- include/editeng/unofield.hxx | 5 +---- 5 files changed, 5 insertions(+), 12 deletions(-) diff --git a/editeng/inc/edtspell.hxx b/editeng/inc/edtspell.hxx index 1165e7a1f54d..82ed2f618e9d 100644 --- a/editeng/inc/edtspell.hxx +++ b/editeng/inc/edtspell.hxx @@ -113,7 +113,7 @@ public: const_iterator end() const; }; -class EdtAutoCorrDoc : public SvxAutoCorrDoc +class EdtAutoCorrDoc final : public SvxAutoCorrDoc { EditEngine* mpEditEngine; ContentNode* pCurNode; @@ -122,7 +122,6 @@ class EdtAutoCorrDoc : public SvxAutoCorrDoc bool bAllowUndoAction; bool bUndoAction; -protected: void ImplStartUndoAction(); public: diff --git a/editeng/source/editeng/eertfpar.hxx b/editeng/source/editeng/eertfpar.hxx index 2a7629e6b758..a308ff5ad3da 100644 --- a/editeng/source/editeng/eertfpar.hxx +++ b/editeng/source/editeng/eertfpar.hxx @@ -26,7 +26,7 @@ class EditEngine; -class EditRTFParser : public SvxRTFParser +class EditRTFParser final : public SvxRTFParser { private: EditSelection aCurSel; @@ -37,7 +37,6 @@ private: sal_uInt16 nDefFont; bool bLastActionInsertParaBreak; -protected: virtual void InsertPara() override; virtual void InsertText() override; virtual void MovePos( bool bForward = true ) override; diff --git a/editeng/source/editeng/textconv.hxx b/editeng/source/editeng/textconv.hxx index 301fcf746f09..d7b6ff10ae8d 100644 --- a/editeng/source/editeng/textconv.hxx +++ b/editeng/source/editeng/textconv.hxx @@ -28,7 +28,7 @@ class EditView; -class TextConvWrapper : public editeng::HangulHanjaConversion +class TextConvWrapper final : public editeng::HangulHanjaConversion { OUString m_aConvText; // convertible text part found last time LanguageType m_nConvTextLang; // language of aConvText @@ -71,7 +71,6 @@ class TextConvWrapper : public editeng::HangulHanjaConversion TextConvWrapper (const TextConvWrapper &) = delete; TextConvWrapper & operator= (const TextConvWrapper &) = delete; -protected: virtual void GetNextPortion( OUString& /* [out] */ rNextPortion, LanguageType& /* [out] */ rLangOfPortion, bool /* [in] */ _bAllowImplicitChangesForNotConvertibleText ) override; diff --git a/include/editeng/borderline.hxx b/include/editeng/borderline.hxx index fd356b489546..b873852fc7a0 100644 --- a/include/editeng/borderline.hxx +++ b/include/editeng/borderline.hxx @@ -137,9 +137,8 @@ double EDITENG_DLLPUBLIC ConvertBorderWidthToWord(SvxBorderLineStyle, double); double EDITENG_DLLPUBLIC ConvertBorderWidthFromWord(SvxBorderLineStyle, double, int); -class EDITENG_DLLPUBLIC SvxBorderLine +class EDITENG_DLLPUBLIC SvxBorderLine final { -protected: Color aColor; long m_nWidth; diff --git a/include/editeng/unofield.hxx b/include/editeng/unofield.hxx index 31594e91bb77..8e81da850f99 100644 --- a/include/editeng/unofield.hxx +++ b/include/editeng/unofield.hxx @@ -43,20 +43,17 @@ class SvxFieldData; css::uno::Reference< css::uno::XInterface > EDITENG_DLLPUBLIC SAL_CALL SvxUnoTextCreateTextField( const OUString& ServiceSpecifier ); -class EDITENG_DLLPUBLIC SvxUnoTextField : public SvxMutexHelper, +class EDITENG_DLLPUBLIC SvxUnoTextField final : public SvxMutexHelper, public ::cppu::OComponentHelper, public css::text::XTextField, public css::beans::XPropertySet, public css::lang::XServiceInfo, public css::lang::XUnoTunnel { -private: css::uno::Reference< css::text::XTextRange > mxAnchor; const SfxItemPropertySet* mpPropSet; sal_Int32 mnServiceId; std::unique_ptr mpImpl; - -protected: css::uno::Sequence< css::uno::Type > maTypeSequence; public: -- cgit