From 2f9c6940a702da50cf19bc22c3bc85066a27fc3a Mon Sep 17 00:00:00 2001
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
Date: Wed, 5 Sep 2018 18:06:36 +0200
Subject: printdialog: fix some accessibility warnings

Change-Id: Icf508473d194bc8c6f01e551b6659a625b8ee229
Reviewed-on: https://gerrit.libreoffice.org/60141
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
---
 solenv/sanitizers/ui/vcl.suppr |  5 -----
 vcl/uiconfig/ui/printdialog.ui | 14 ++++++++++++++
 2 files changed, 14 insertions(+), 5 deletions(-)

diff --git a/solenv/sanitizers/ui/vcl.suppr b/solenv/sanitizers/ui/vcl.suppr
index ba71a66caff1..cd77920c627a 100644
--- a/solenv/sanitizers/ui/vcl.suppr
+++ b/solenv/sanitizers/ui/vcl.suppr
@@ -1,13 +1,8 @@
 vcl/uiconfig/ui/cupspassworddialog.ui://GtkLabel[@id='text'] orphan-label
 vcl/uiconfig/ui/printdialog.ui://GtkSpinButton[@id='pageedit-nospin'] no-labelled-by
 vcl/uiconfig/ui/printdialog.ui://GtkLabel[@id='totalnumpages'] orphan-label
-vcl/uiconfig/ui/printdialog.ui://GtkButton[@id='forward'] button-no-label
-vcl/uiconfig/ui/printdialog.ui://GtkButton[@id='backward'] button-no-label
 vcl/uiconfig/ui/printdialog.ui://GtkImage[@id='collateimage'] no-labelled-by
 vcl/uiconfig/ui/printdialog.ui://GtkLabel[@id='fromwhich'] orphan-label
-vcl/uiconfig/ui/printdialog.ui://GtkEntry[@id='pagerange'] no-labelled-by
-vcl/uiconfig/ui/printdialog.ui://GtkComboBox[@id='paperspersheetlb'] no-labelled-by
-vcl/uiconfig/ui/printdialog.ui://GtkLabel[@id='pagespersheettxt'] orphan-label
 vcl/uiconfig/ui/printdialog.ui://vcllo-ShowNupOrderWindow[@id='orderpreview'] no-labelled-by
 vcl/uiconfig/ui/printdialog.ui://GtkLabel[@id='pagemargintxt2'] orphan-label
 vcl/uiconfig/ui/printdialog.ui://GtkLabel[@id='sheetmargintxt2'] orphan-label
diff --git a/vcl/uiconfig/ui/printdialog.ui b/vcl/uiconfig/ui/printdialog.ui
index 7f5763a3c8f8..62faa172026d 100644
--- a/vcl/uiconfig/ui/printdialog.ui
+++ b/vcl/uiconfig/ui/printdialog.ui
@@ -243,6 +243,7 @@
                         <property name="can_focus">True</property>
                         <property name="receives_default">True</property>
                         <property name="image">image2</property>
+                        <property name="tooltip_text" translatable="yes" context="printdialog|forward">Next page</property>
                       </object>
                       <packing>
                         <property name="expand">False</property>
@@ -257,6 +258,7 @@
                         <property name="can_focus">True</property>
                         <property name="receives_default">True</property>
                         <property name="image">image1</property>
+                        <property name="tooltip_text" translatable="yes" context="printdialog|backward">Previous page</property>
                       </object>
                       <packing>
                         <property name="expand">False</property>
@@ -711,6 +713,9 @@
                                             <property name="xalign">0</property>
                                             <property name="draw_indicator">True</property>
                                             <property name="group">printselection</property>
+                                            <accessibility>
+                                              <relation type="label-for" target="pagerange"/>
+                                            </accessibility>
                                           </object>
                                           <packing>
                                             <property name="expand">False</property>
@@ -722,6 +727,9 @@
                                           <object class="GtkEntry" id="pagerange">
                                             <property name="can_focus">True</property>
                                             <property name="no_show_all">True</property>
+                                            <accessibility>
+                                              <relation type="labelled-by" target="printpages"/>
+                                            </accessibility>
                                           </object>
                                           <packing>
                                             <property name="expand">False</property>
@@ -1066,6 +1074,9 @@
                                     <property name="visible">True</property>
                                     <property name="can_focus">False</property>
                                     <property name="model">liststore1</property>
+                                    <accessibility>
+                                      <relation type="labelled-by" target="pagespersheettxt"/>
+                                    </accessibility>
                                   </object>
                                   <packing>
                                     <property name="left_attach">1</property>
@@ -1098,6 +1109,9 @@
                                     <child>
                                       <object class="GtkLabel" id="pagespersheettxt">
                                         <property name="can_focus">False</property>
+                                        <accessibility>
+                                          <relation type="label-for" target="paperspersheetlb"/>
+                                        </accessibility>
                                       </object>
                                       <packing>
                                         <property name="expand">False</property>
-- 
cgit