From 34f50399f1bc896849a0e3fc3598ab1225d760c5 Mon Sep 17 00:00:00 2001 From: Jelle van der Waa Date: Sat, 22 Jun 2013 12:53:29 +0200 Subject: fdo#43460 shell,vcl,xmlreader: use isEmpty() Change-Id: Ie3d16da6c246b79c4c304b21476f84b2788f0d6e Reviewed-on: https://gerrit.libreoffice.org/4444 Tested-by: LibreOffice gerrit bot Reviewed-by: Thomas Arnhold Tested-by: Thomas Arnhold --- shell/source/unix/exec/shellexec.cxx | 2 +- vcl/generic/fontmanager/helper.cxx | 4 ++-- xmlreader/source/pad.cxx | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/shell/source/unix/exec/shellexec.cxx b/shell/source/unix/exec/shellexec.cxx index 6fe1c1e59e6b..b962f8a58172 100644 --- a/shell/source/unix/exec/shellexec.cxx +++ b/shell/source/unix/exec/shellexec.cxx @@ -236,7 +236,7 @@ void SAL_CALL ShellExec::execute( const OUString& aCommand, const OUString& aPar } // Prefer DESKTOP_LAUNCH when available - if ( aLaunchBuffer.getLength() > 0 ) + if ( !aLaunchBuffer.isEmpty() ) { FILE *pLaunch = popen( aLaunchBuffer.makeStringAndClear().getStr(), "w" ); if ( pLaunch != NULL ) diff --git a/vcl/generic/fontmanager/helper.cxx b/vcl/generic/fontmanager/helper.cxx index 33db29819c79..fc582bdf01e2 100644 --- a/vcl/generic/fontmanager/helper.cxx +++ b/vcl/generic/fontmanager/helper.cxx @@ -115,7 +115,7 @@ void psp::getPrinterPathList( std::list< OUString >& rPathList, const char* pSub // append net path aPathBuffer.append( getOfficePath( psp::InstallationRootPath ) ); - if( aPathBuffer.getLength() ) + if( !aPathBuffer.isEmpty() ) { aPathBuffer.appendAscii( "/share/psprint" ); if( pSubDir ) @@ -127,7 +127,7 @@ void psp::getPrinterPathList( std::list< OUString >& rPathList, const char* pSub } // append user path aPathBuffer.append( getOfficePath( psp::UserPath ) ); - if( aPathBuffer.getLength() ) + if( !aPathBuffer.isEmpty() ) { aPathBuffer.appendAscii( "/user/psprint" ); if( pSubDir ) diff --git a/xmlreader/source/pad.cxx b/xmlreader/source/pad.cxx index d48915702784..c7d9b4dba9b2 100644 --- a/xmlreader/source/pad.cxx +++ b/xmlreader/source/pad.cxx @@ -32,7 +32,7 @@ void Pad::add(char const * begin, sal_Int32 length) { begin != 0 && length >= 0 && !(span_.is() && buffer_.getLength() != 0)); if (length != 0) { flushSpan(); - if (buffer_.getLength() == 0) { + if (buffer_.isEmpty()) { span_ = Span(begin, length); } else { buffer_.append(begin, length); @@ -59,7 +59,7 @@ Span Pad::get() const { assert(!(span_.is() && buffer_.getLength() != 0)); if (span_.is()) { return span_; - } else if (buffer_.getLength() == 0) { + } else if (buffer_.isEmpty()) { return Span(""); } else { return Span(buffer_.getStr(), buffer_.getLength()); -- cgit