From 35d21e4bf6f66b3bbc7a44fcf184cb721b524a94 Mon Sep 17 00:00:00 2001 From: Stephan Bergmann Date: Fri, 4 Oct 2019 19:09:59 +0200 Subject: Remove redundant memsets ...since 1f8c2a2e5c8bda6e6e35a868e5ac7afdc7d32317 "coverity#1187868 Uninitialized pointer field" introduced a default ctor zero-initializing all members of SystemEnvData Change-Id: Ifd31282ab4b82e26733afdd74c234a8a1b4dbb4c Reviewed-on: https://gerrit.libreoffice.org/80255 Tested-by: Jenkins Reviewed-by: Stephan Bergmann --- vcl/headless/svpdummies.cxx | 3 --- vcl/headless/svpframe.cxx | 4 ---- 2 files changed, 7 deletions(-) diff --git a/vcl/headless/svpdummies.cxx b/vcl/headless/svpdummies.cxx index 21a054761ea2..9fab8f15f990 100644 --- a/vcl/headless/svpdummies.cxx +++ b/vcl/headless/svpdummies.cxx @@ -17,7 +17,6 @@ * the License at http://www.apache.org/licenses/LICENSE-2.0 . */ -#include #include #include #include @@ -25,8 +24,6 @@ // SalObject SvpSalObject::SvpSalObject() { - // fast and easy cross-platform wiping of the data - memset( static_cast(&m_aSystemChildData), 0, sizeof( SystemEnvData ) ); m_aSystemChildData.nSize = sizeof( SystemEnvData ); } diff --git a/vcl/headless/svpframe.cxx b/vcl/headless/svpframe.cxx index 4259a84d5a0b..977d83d08fcf 100644 --- a/vcl/headless/svpframe.cxx +++ b/vcl/headless/svpframe.cxx @@ -17,8 +17,6 @@ * the License at http://www.apache.org/licenses/LICENSE-2.0 . */ -#include - #include #include #include @@ -57,8 +55,6 @@ SvpSalFrame::SvpSalFrame( SvpSalInstance* pInstance, m_nMaxHeight( 0 ) { // SAL_DEBUG("SvpSalFrame::SvpSalFrame: " << this); - // fast and easy cross-platform wiping of the data - memset( static_cast(&m_aSystemChildData), 0, sizeof( SystemEnvData ) ); m_aSystemChildData.nSize = sizeof( SystemEnvData ); #ifdef IOS // Nothing -- cgit