From 3beb77bb6753a77b7d801fdc65fad78b98331813 Mon Sep 17 00:00:00 2001 From: Caolán McNamara Date: Thu, 12 May 2016 11:30:14 +0100 Subject: Resolves: tdf#99464 don't allow a menu as a dialog parent MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit which is an issue since... commit dd46727b99d4bb5135451aa7e5e1bdb197373843 Author: Caolán McNamara Date: Tue Apr 5 15:27:38 2016 +0100 Resolves; tdf#87120 no keyboard navigation inside floating windows lets try and treat these the same as we do normal toplevels like dialogs if they popup with GrabFocus. This way focus can be set on widgets inside the floating windows, and so keyboard traversal of widgets etc all works. which allows keyboard focus inside floatinging windows to allow a11y keyboard navigation inside them without jumping through difficult hoops. Its typically better to explicitly set the parent of the dialog rather than depend no the auto-search stuff Change-Id: I869f3ef6c86d32dd9a1f5b53a2677be9f16a1598 --- vcl/source/app/svapp.cxx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vcl/source/app/svapp.cxx b/vcl/source/app/svapp.cxx index 76947cf57bc1..1374a7a6d9bf 100644 --- a/vcl/source/app/svapp.cxx +++ b/vcl/source/app/svapp.cxx @@ -1442,7 +1442,7 @@ vcl::Window* Application::GetDefDialogParent() // current focus frame vcl::Window *pWin = pSVData->maWinData.mpFocusWin; - if (pWin) + if (pWin && !pWin->IsMenuFloatingWindow()) { while (pWin->mpWindowImpl && pWin->mpWindowImpl->mpParent) pWin = pWin->mpWindowImpl->mpParent; -- cgit