From 3eba5eb1774ab621a1f0f4dcc7e82cce6c025b0a Mon Sep 17 00:00:00 2001 From: Caolán McNamara Date: Sat, 31 Jan 2015 21:11:57 +0000 Subject: coverity#1267678 this is surely backwards (gold) surely we clone from the source and return the newly created entry. Presumably this doesn't break all the time because aCloneLink is generally set ? coverity#1267678 Resource leak Change-Id: I3e02dfaef371e006f1510b186cdd881c991ef2cf (cherry picked from commit 9f1ecd3ac35f06746fe2a12ca52899f664679de5) Reviewed-on: https://gerrit.libreoffice.org/15022 Tested-by: David Tardon Reviewed-by: David Tardon --- svtools/source/contnr/treelist.cxx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/svtools/source/contnr/treelist.cxx b/svtools/source/contnr/treelist.cxx index 60a8d27855c8..1da2c9856d52 100644 --- a/svtools/source/contnr/treelist.cxx +++ b/svtools/source/contnr/treelist.cxx @@ -355,8 +355,8 @@ SvTreeListEntry* SvTreeList::CloneEntry( SvTreeListEntry* pSource ) const if( aCloneLink.IsSet() ) return reinterpret_cast(aCloneLink.Call( pSource )); SvTreeListEntry* pEntry = CreateEntry(); - pSource->Clone( pEntry ); - return pSource; + pEntry->Clone(pSource); + return pEntry; } SvTreeListEntry* SvTreeList::CreateEntry() const -- cgit