From 423c5d4eaa15fe5cbef75ac45061d317004a6475 Mon Sep 17 00:00:00 2001 From: Michael Weghorn Date: Tue, 6 Apr 2021 14:26:06 +0200 Subject: android: Drop custom file abstraction + UI Android Viewer had its own file abstraction layer. From the (now deleted) IFile.java: > An abstraction of the File class, intended to be implemented by different > Document Providers. > > It represents a file or a directory in the context of a certain Document > Provider. It wraps the file-related operations and provides access to the > final document as a local File, downloading it if necessary. However, Android already provides such an abstraction by what is called "documents provider" there as well, s. [1]. Android Viewer has previously been adapted to support and make use of that. Therefore, drop the custom implementation to avoid duplication and having to reimplement functionality already provided otherwise. Also, drop the custom UI elements to display and select files implemented on top of the custom file abstraction. Support for using the system file picker (via the corresponding Intents) has been added earlier and is now the only available option to open files from within the app. [1] https://developer.android.com/training/data-storage/shared/documents-files Change-Id: Ide529e836a32fd7e880e5a72d971af9f9c7e74bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113667 Tested-by: Jenkins Reviewed-by: Michael Weghorn (cherry picked from commit a23bd42e9b2f6401c710ac95afcc3aa8f360d65c) --- android/source/AndroidManifest.xml | 17 - .../res/layout/activity_directory_browser.xml | 6 - .../res/layout/activity_document_browser.xml | 27 - .../source/res/layout/file_explorer_grid_item.xml | 42 - android/source/res/layout/file_grid.xml | 25 - android/source/res/layout/file_list.xml | 20 - android/source/res/layout/file_list_item.xml | 58 -- .../res/layout/fragment_directory_browser.xml | 71 -- android/source/res/menu/context_menu.xml | 7 - android/source/res/menu/navigation_menu.xml | 34 - android/source/res/menu/view_menu.xml | 54 -- android/source/res/values-de/strings.xml | 63 -- android/source/res/values-tr/strings.xml | 54 -- android/source/res/values/arrays.xml | 47 -- android/source/res/values/integers.xml | 6 - android/source/res/values/strings.xml | 64 -- .../res/xml/documentprovider_preferences.xml | 22 - android/source/res/xml/libreoffice_preferences.xml | 31 - .../org/libreoffice/LibreOfficeMainActivity.java | 146 +--- .../storage/DocumentProviderFactory.java | 125 --- .../storage/DocumentProviderSettingsActivity.java | 99 --- .../org/libreoffice/storage/IDocumentProvider.java | 69 -- .../src/java/org/libreoffice/storage/IFile.java | 116 --- .../src/java/org/libreoffice/storage/IOUtils.java | 56 -- .../storage/external/BrowserSelectorActivity.java | 153 ---- .../storage/external/DirectoryBrowserActivity.java | 42 - .../storage/external/DirectoryBrowserFragment.java | 199 ----- .../libreoffice/storage/external/ExternalFile.java | 163 ---- .../storage/external/ExtsdDocumentsProvider.java | 175 ---- .../external/IExternalDocumentProvider.java | 22 - .../storage/external/OTGDocumentsProvider.java | 90 --- .../local/LocalDocumentsDirectoryProvider.java | 73 -- .../storage/local/LocalDocumentsProvider.java | 60 -- .../org/libreoffice/storage/local/LocalFile.java | 103 --- .../src/java/org/libreoffice/ui/FileUtilities.java | 108 --- .../org/libreoffice/ui/LibreOfficeUIActivity.java | 876 +-------------------- 36 files changed, 51 insertions(+), 3272 deletions(-) delete mode 100644 android/source/res/layout/activity_directory_browser.xml delete mode 100644 android/source/res/layout/file_explorer_grid_item.xml delete mode 100644 android/source/res/layout/file_grid.xml delete mode 100644 android/source/res/layout/file_list.xml delete mode 100644 android/source/res/layout/file_list_item.xml delete mode 100644 android/source/res/layout/fragment_directory_browser.xml delete mode 100644 android/source/res/menu/context_menu.xml delete mode 100644 android/source/res/menu/navigation_menu.xml delete mode 100644 android/source/res/values/integers.xml delete mode 100644 android/source/res/xml/documentprovider_preferences.xml delete mode 100644 android/source/src/java/org/libreoffice/storage/DocumentProviderFactory.java delete mode 100644 android/source/src/java/org/libreoffice/storage/DocumentProviderSettingsActivity.java delete mode 100644 android/source/src/java/org/libreoffice/storage/IDocumentProvider.java delete mode 100644 android/source/src/java/org/libreoffice/storage/IFile.java delete mode 100644 android/source/src/java/org/libreoffice/storage/IOUtils.java delete mode 100644 android/source/src/java/org/libreoffice/storage/external/BrowserSelectorActivity.java delete mode 100644 android/source/src/java/org/libreoffice/storage/external/DirectoryBrowserActivity.java delete mode 100644 android/source/src/java/org/libreoffice/storage/external/DirectoryBrowserFragment.java delete mode 100644 android/source/src/java/org/libreoffice/storage/external/ExternalFile.java delete mode 100644 android/source/src/java/org/libreoffice/storage/external/ExtsdDocumentsProvider.java delete mode 100644 android/source/src/java/org/libreoffice/storage/external/IExternalDocumentProvider.java delete mode 100644 android/source/src/java/org/libreoffice/storage/external/OTGDocumentsProvider.java delete mode 100644 android/source/src/java/org/libreoffice/storage/local/LocalDocumentsDirectoryProvider.java delete mode 100644 android/source/src/java/org/libreoffice/storage/local/LocalDocumentsProvider.java delete mode 100644 android/source/src/java/org/libreoffice/storage/local/LocalFile.java diff --git a/android/source/AndroidManifest.xml b/android/source/AndroidManifest.xml index ae37c4fe8054..53a064fb901b 100644 --- a/android/source/AndroidManifest.xml +++ b/android/source/AndroidManifest.xml @@ -110,23 +110,6 @@ - - - - - - - - - - - - - - - - \ No newline at end of file diff --git a/android/source/res/layout/activity_document_browser.xml b/android/source/res/layout/activity_document_browser.xml index b3b4ace2a465..f2985511dd61 100644 --- a/android/source/res/layout/activity_document_browser.xml +++ b/android/source/res/layout/activity_document_browser.xml @@ -86,24 +86,6 @@ android:padding="16dp" android:textStyle="bold" /> - - - - - - - @@ -145,7 +119,6 @@ android:layout_width="wrap_content" android:layout_height="wrap_content" android:clickable="true" - android:visibility="invisible" app:backgroundTint="@color/background_normal" app:fabSize="normal" app:layout_constraintBottom_toBottomOf="parent" diff --git a/android/source/res/layout/file_explorer_grid_item.xml b/android/source/res/layout/file_explorer_grid_item.xml deleted file mode 100644 index e64fdc23a6a7..000000000000 --- a/android/source/res/layout/file_explorer_grid_item.xml +++ /dev/null @@ -1,42 +0,0 @@ - - - - - - - - - - - diff --git a/android/source/res/layout/file_grid.xml b/android/source/res/layout/file_grid.xml deleted file mode 100644 index 1885bd34ed6a..000000000000 --- a/android/source/res/layout/file_grid.xml +++ /dev/null @@ -1,25 +0,0 @@ - - - - - - - - diff --git a/android/source/res/layout/file_list.xml b/android/source/res/layout/file_list.xml deleted file mode 100644 index 48dfb1e31267..000000000000 --- a/android/source/res/layout/file_list.xml +++ /dev/null @@ -1,20 +0,0 @@ - - - - - - - - diff --git a/android/source/res/layout/file_list_item.xml b/android/source/res/layout/file_list_item.xml deleted file mode 100644 index 518885d4b296..000000000000 --- a/android/source/res/layout/file_list_item.xml +++ /dev/null @@ -1,58 +0,0 @@ - - - - - - - - - - diff --git a/android/source/res/layout/fragment_directory_browser.xml b/android/source/res/layout/fragment_directory_browser.xml deleted file mode 100644 index 37a61fa3518c..000000000000 --- a/android/source/res/layout/fragment_directory_browser.xml +++ /dev/null @@ -1,71 +0,0 @@ - - - - - - - - - -