From 49f62c53aa02174ccdb71c8c6a95326e2d49579f Mon Sep 17 00:00:00 2001 From: Miklos Vajna Date: Tue, 4 Jan 2022 16:28:03 +0100 Subject: sc export chart as graphic: handle PDF The context menu for Calc charts would call into GraphicFilter::ExportGraphic(), which has explicit code for e.g. SVG, but not for PDF. The graphic exporter to PDF is only meant to work with images backed with PDF data, not with all shapes. Fix the problem by explicitly handling PDF in GraphicHelper::SaveShapeAsGraphic() in svx/, and invoking the normal PDF export in that case. Continue to fall back to XGraphicExportFilter for other formats. This requires passing down the current document from sc/. (cherry picked from commit 77d2bbaa18e0be5347d7bd7167b245264789e0a4) Conflicts: sc/source/ui/drawfunc/chartsh.cxx svx/Module_svx.mk svx/source/core/graphichelper.cxx Change-Id: Ia5f78bffa1d26989bb0ad3ed265b922e609f076f --- include/svx/graphichelper.hxx | 12 +++++- sc/source/ui/drawfunc/chartsh.cxx | 9 ++++- svx/source/core/graphichelper.cxx | 83 ++++++++++++++++++++++++++++----------- 3 files changed, 80 insertions(+), 24 deletions(-) diff --git a/include/svx/graphichelper.hxx b/include/svx/graphichelper.hxx index 2f723b830493..1d3c6ee58227 100644 --- a/include/svx/graphichelper.hxx +++ b/include/svx/graphichelper.hxx @@ -24,6 +24,10 @@ #include namespace com::sun::star::drawing { class XShape; } +namespace com::sun::star::lang +{ +class XComponent; +} namespace weld { class Widget; } namespace weld { class Window; } @@ -34,7 +38,13 @@ public: static void GetPreferredExtension( OUString& rExtension, const Graphic& rGraphic ); static OUString GetImageType(const Graphic& rGraphic); static OUString ExportGraphic(weld::Window* pWin, const Graphic& rGraphic, const OUString& rGraphicName); - static void SaveShapeAsGraphic(weld::Window* pWin, const css::uno::Reference< css::drawing::XShape >& xShape); + static void + SaveShapeAsGraphicToPath(const css::uno::Reference& xComponent, + const css::uno::Reference& xShape, + const OUString& rMimeType, const OUString& rPath); + static void SaveShapeAsGraphic(weld::Window* pWin, + const css::uno::Reference& xComponent, + const css::uno::Reference& xShape); static short HasToSaveTransformedImage(weld::Widget* pWin); }; diff --git a/sc/source/ui/drawfunc/chartsh.cxx b/sc/source/ui/drawfunc/chartsh.cxx index 95b06385335e..2f714c976cf8 100644 --- a/sc/source/ui/drawfunc/chartsh.cxx +++ b/sc/source/ui/drawfunc/chartsh.cxx @@ -137,8 +137,15 @@ void ScChartShell::ExecuteExportAsGraphic( SfxRequest& ) if( dynamic_cast( pObject) ) { vcl::Window* pWin = GetViewData().GetActiveWin(); + css::uno::Reference xComponent; + const SfxObjectShell* pShell = GetObjectShell(); + if (pShell) + { + xComponent = pShell->GetModel(); + } Reference< drawing::XShape > xSourceDoc( pObject->getUnoShape(), UNO_QUERY_THROW ); - GraphicHelper::SaveShapeAsGraphic(pWin ? pWin->GetFrameWeld() : nullptr, xSourceDoc); + GraphicHelper::SaveShapeAsGraphic(pWin ? pWin->GetFrameWeld() : nullptr, xComponent, + xSourceDoc); } } diff --git a/svx/source/core/graphichelper.cxx b/svx/source/core/graphichelper.cxx index ae31bb0d8f37..0e201b49a4c7 100644 --- a/svx/source/core/graphichelper.cxx +++ b/svx/source/core/graphichelper.cxx @@ -46,9 +46,14 @@ #include #include #include +#include #include +#include +#include +#include + using namespace css::uno; using namespace css::lang; using namespace css::graphic; @@ -382,7 +387,61 @@ OUString GraphicHelper::ExportGraphic(weld::Window* pParent, const Graphic& rGra return OUString(); } -void GraphicHelper::SaveShapeAsGraphic(weld::Window* pParent, const Reference< drawing::XShape >& xShape) +void GraphicHelper::SaveShapeAsGraphicToPath( + const css::uno::Reference& xComponent, + const css::uno::Reference& xShape, const OUString& aExportMimeType, + const OUString& sPath) +{ + Reference xContext(::comphelper::getProcessComponentContext()); + Reference xGraphStream; + + if (xGraphStream.is()) + { + Reference xFileAccess = SimpleFileAccess::create(xContext); + xFileAccess->writeFile(sPath, xGraphStream); + } + else if (xComponent.is() && aExportMimeType == "application/pdf") + { + css::uno::Reference xMSF(xContext->getServiceManager(), + css::uno::UNO_QUERY); + css::uno::Reference xExporter( + xMSF->createInstance("com.sun.star.comp.PDF.PDFFilter"), css::uno::UNO_QUERY); + xExporter->setSourceDocument(xComponent); + + css::uno::Reference xShapes + = css::drawing::ShapeCollection::create(comphelper::getProcessComponentContext()); + xShapes->add(xShape); + css::uno::Sequence aFilterData{ + comphelper::makePropertyValue("Selection", xShapes), + }; + SvFileStream aStream(sPath, StreamMode::READWRITE | StreamMode::TRUNC); + css::uno::Reference xStream(new utl::OStreamWrapper(aStream)); + css::uno::Sequence aDescriptor{ + comphelper::makePropertyValue("FilterData", aFilterData), + comphelper::makePropertyValue("OutputStream", xStream) + }; + css::uno::Reference xFilter(xExporter, css::uno::UNO_QUERY); + xFilter->filter(aDescriptor); + } + else + { + Reference xGraphicExporter = css::drawing::GraphicExportFilter::create( xContext ); + + Sequence aDescriptor( 2 ); + aDescriptor[0].Name = "MediaType"; + aDescriptor[0].Value <<= aExportMimeType; + aDescriptor[1].Name = "URL"; + aDescriptor[1].Value <<= sPath; + + Reference< XComponent > xSourceDocument( xShape, UNO_QUERY_THROW ); + xGraphicExporter->setSourceDocument( xSourceDocument ); + xGraphicExporter->filter( aDescriptor ); + } +} + +void GraphicHelper::SaveShapeAsGraphic(weld::Window* pParent, + const css::uno::Reference& xComponent, + const Reference& xShape) { try { @@ -430,27 +489,7 @@ void GraphicHelper::SaveShapeAsGraphic(weld::Window* pParent, const Reference< OUString sPath( xFilePicker->getFiles().getConstArray()[0] ); OUString aExportMimeType( aMimeTypeMap[xFilePicker->getCurrentFilter()] ); - Reference< XInputStream > xGraphStream; - - if( xGraphStream.is() ) - { - Reference xFileAccess = SimpleFileAccess::create( xContext ); - xFileAccess->writeFile( sPath, xGraphStream ); - } - else - { - Reference xGraphicExporter = css::drawing::GraphicExportFilter::create( xContext ); - - Sequence aDescriptor( 2 ); - aDescriptor[0].Name = "MediaType"; - aDescriptor[0].Value <<= aExportMimeType; - aDescriptor[1].Name = "URL"; - aDescriptor[1].Value <<= sPath; - - Reference< XComponent > xSourceDocument( xShape, UNO_QUERY_THROW ); - xGraphicExporter->setSourceDocument( xSourceDocument ); - xGraphicExporter->filter( aDescriptor ); - } + GraphicHelper::SaveShapeAsGraphicToPath(xComponent, xShape, aExportMimeType, sPath); } } catch( Exception& ) -- cgit