From 4ed70b89aa89ff407775ede83521e9cd377159a0 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Wed, 26 Jul 2017 08:29:30 +0200 Subject: loplugin:unusedfields Change-Id: I21e538b8e9c7a5f0fb233019efac37a3555e3c93 Reviewed-on: https://gerrit.libreoffice.org/40438 Tested-by: Jenkins Reviewed-by: Noel Grandin --- .../clang/unusedfields.readonly.results | 204 +++++++++------------ .../clang/unusedfields.untouched.results | 110 ++--------- .../clang/unusedfields.writeonly.results | 178 +++++++++--------- .../source/sdbtools/connection/objectnames.cxx | 48 ++--- editeng/source/editeng/eertfpar.cxx | 2 +- editeng/source/rtf/svxrtf.cxx | 6 +- filter/source/graphicfilter/icgm/cgm.cxx | 1 - filter/source/graphicfilter/icgm/cgm.hxx | 1 - formula/source/ui/dlg/formula.cxx | 4 - include/editeng/svxrtf.hxx | 6 +- include/formula/formdata.hxx | 2 - include/sfx2/charwin.hxx | 1 - include/svx/deflt3d.hxx | 3 - svx/source/engine3d/deflt3d.cxx | 5 - 14 files changed, 211 insertions(+), 360 deletions(-) diff --git a/compilerplugins/clang/unusedfields.readonly.results b/compilerplugins/clang/unusedfields.readonly.results index 5652c72eeb7f..9e276843d5ba 100644 --- a/compilerplugins/clang/unusedfields.readonly.results +++ b/compilerplugins/clang/unusedfields.readonly.results @@ -176,8 +176,6 @@ cui/source/inc/autocdlg.hxx:229 StringChangeList aNewEntries DoubleStringArray cui/source/inc/autocdlg.hxx:230 StringChangeList aDeletedEntries DoubleStringArray -cui/source/inc/backgrnd.hxx:108 - SvxBackgroundTabPage bLinkOnly _Bool cui/source/inc/cuicharmap.hxx:83 SvxCharacterMap m_pFavCharView VclPtr [16] cui/source/inc/numpages.hxx:167 @@ -192,10 +190,14 @@ cui/source/options/personalization.hxx:85 SelectPersonaDialog m_vResultList VclPtr [9] cui/source/options/personalization.hxx:86 SelectPersonaDialog m_vSearchSuggestions VclPtr [6] +dbaccess/source/core/api/RowSetBase.hxx:99 + dbaccess::ORowSetBase m_aErrors ::connectivity::SQLError +dbaccess/source/core/dataaccess/documentcontainer.cxx:65 + dbaccess::LocalNameApproval m_aErrors ::connectivity::SQLError +dbaccess/source/core/inc/ContentHelper.hxx:111 + dbaccess::OContentHelper m_aErrorHelper const ::connectivity::SQLError dbaccess/source/ui/inc/charsetlistbox.hxx:42 dbaui::CharSetListBox m_aCharSets class dbaui::OCharsetDisplay -desktop/source/deployment/gui/dp_gui_updatedialog.cxx:227 - dp_gui::UpdateDialog::Thread m_abort uno::Reference embeddedobj/source/inc/oleembobj.hxx:119 OleEmbeddedObject m_pOleComponent class OleComponent * embeddedobj/source/inc/oleembobj.hxx:139 @@ -218,16 +220,12 @@ extensions/source/propctrlr/eformshelper.hxx:62 pcr::EFormsHelper m_aSubmissionUINames pcr::MapStringToPropertySet extensions/source/propctrlr/eformshelper.hxx:64 pcr::EFormsHelper m_aBindingUINames pcr::MapStringToPropertySet -extensions/source/propctrlr/propertyhandler.hxx:80 - pcr::PropertyHandler m_aEnsureResAccess class pcr::PcrClient extensions/source/scanner/scanner.hxx:46 ScannerManager maProtector osl::Mutex -filter/inc/gfxtypes.hxx:191 - svgi::State meTextDisplayAlign enum svgi::TextAlign filter/source/graphicfilter/eps/eps.cxx:113 PSWriter pVDev ScopedVclPtrInstance -filter/source/graphicfilter/icgm/cgm.hxx:59 - CGM mpGraphic class Graphic * +filter/source/graphicfilter/icgm/cgm.hxx:138 + CGM mpGDIMetaFile class GDIMetaFile * filter/source/graphicfilter/icgm/chart.hxx:44 DataNode nBoxX1 sal_Int16 filter/source/graphicfilter/icgm/chart.hxx:45 @@ -248,9 +246,9 @@ filter/source/xsltdialog/xmlfiltersettingsdialog.hxx:153 XMLFilterSettingsDialog maModuleOpt class SvtModuleOptions framework/inc/dispatch/dispatchprovider.hxx:81 framework::DispatchProvider m_aProtocolHandlerCache class framework::HandlerCache -framework/source/uiconfiguration/moduleuiconfigurationmanager.cxx:184 +framework/source/uiconfiguration/moduleuiconfigurationmanager.cxx:185 (anonymous namespace)::ModuleUIConfigurationManager::UIElementType aElementsHashMap (anonymous namespace)::ModuleUIConfigurationManager::UIElementDataHashMap -framework/source/uiconfiguration/uiconfigurationmanager.cxx:164 +framework/source/uiconfiguration/uiconfigurationmanager.cxx:165 (anonymous namespace)::UIConfigurationManager::UIElementType aElementsHashMap (anonymous namespace)::UIConfigurationManager::UIElementDataHashMap i18npool/inc/textconversion.hxx:80 com::sun::star::i18n::(anonymous) code sal_Unicode @@ -300,8 +298,8 @@ include/registry/refltype.hxx:69 RTUik m_Data5 sal_uInt32 include/sfx2/charmapcontrol.hxx:43 SfxCharmapCtrl m_pFavCharView VclPtr [16] -include/sfx2/frame.hxx:100 - SfxFrame pChildArr class SfxFrameArr_Impl * +include/sfx2/charwin.hxx:52 + SvxCharView maInsertCharHdl Link include/sfx2/msg.hxx:105 SfxType createSfxPoolItemFunc std::function include/sfx2/msg.hxx:106 @@ -324,14 +322,6 @@ include/svx/svdmark.hxx:142 SdrMarkList maPointName class rtl::OUString include/svx/svdmark.hxx:143 SdrMarkList maGluePointName class rtl::OUString -include/svx/svdobj.hxx:973 - SdrObjUserDataCreatorParams nInventor enum SdrInventor -include/svx/svdobj.hxx:974 - SdrObjUserDataCreatorParams nObjIdentifier sal_uInt16 -include/svx/svdobj.hxx:975 - SdrObjUserDataCreatorParams pObject class SdrObject * -include/svx/svdundo.hxx:150 - SdrUndoAttrObj pRepeatSet class SfxItemSet * include/test/sheet/xdatapilottable.hxx:31 apitest::XDataPilotTable xCellForChange css::uno::Reference include/test/sheet/xdatapilottable.hxx:32 @@ -364,74 +354,8 @@ include/vcl/pdfwriter.hxx:561 vcl::PDFWriter::PDFSignContext m_aSignTSA class rtl::OUString include/vcl/pdfwriter.hxx:562 vcl::PDFWriter::PDFSignContext m_aSignPassword class rtl::OUString -include/vcl/toolbox.hxx:106 - ToolBox maInDockRect tools::Rectangle include/xmloff/nmspmap.hxx:70 SvXMLNamespaceMap sEmpty const class rtl::OUString -l10ntools/inc/export.hxx:75 - ResData nIdLevel enum IdLevel -l10ntools/inc/export.hxx:76 - ResData bChild _Bool -l10ntools/inc/export.hxx:77 - ResData bChildWithText _Bool -l10ntools/inc/export.hxx:79 - ResData bText _Bool -l10ntools/inc/export.hxx:80 - ResData bQuickHelpText _Bool -l10ntools/inc/export.hxx:81 - ResData bTitle _Bool -l10ntools/inc/export.hxx:90 - ResData sQuickHelpText OStringHashMap -l10ntools/inc/export.hxx:92 - ResData sTitle OStringHashMap -l10ntools/inc/export.hxx:96 - ResData m_aList ExportList -l10ntools/inc/export.hxx:121 - Export::(anonymous) mSimple std::ofstream * -l10ntools/inc/export.hxx:122 - Export::(anonymous) mPo class PoOfstream * -l10ntools/inc/export.hxx:124 - Export aOutput union (anonymous union at /home/noel/libo3/l10ntools/inc/export.hxx:119:5) -l10ntools/inc/export.hxx:126 - Export aResStack ResStack -l10ntools/inc/export.hxx:128 - Export bDefine _Bool -l10ntools/inc/export.hxx:129 - Export bNextMustBeDefineEOL _Bool -l10ntools/inc/export.hxx:130 - Export nLevel std::size_t -l10ntools/inc/export.hxx:131 - Export nList enum ExportListType -l10ntools/inc/export.hxx:132 - Export nListLevel std::size_t -l10ntools/inc/export.hxx:133 - Export bMergeMode _Bool -l10ntools/inc/export.hxx:134 - Export sMergeSrc class rtl::OString -l10ntools/inc/export.hxx:136 - Export bReadOver _Bool -l10ntools/inc/export.hxx:137 - Export sFilename class rtl::OString -l10ntools/inc/export.hxx:139 - Export aLanguages std::vector -l10ntools/inc/export.hxx:141 - Export pParseQueue class ParserQueue * -l10ntools/inc/export.hxx:346 - ParserQueue bCurrentIsM _Bool -l10ntools/inc/export.hxx:347 - ParserQueue bNextIsM _Bool -l10ntools/inc/export.hxx:348 - ParserQueue bLastWasM _Bool -l10ntools/inc/export.hxx:349 - ParserQueue bMflag _Bool -l10ntools/inc/export.hxx:353 - ParserQueue aQueueNext std::queue * -l10ntools/inc/export.hxx:354 - ParserQueue aQueueCur std::queue * -l10ntools/inc/export.hxx:356 - ParserQueue aExport class Export & -l10ntools/inc/export.hxx:357 - ParserQueue bStart _Bool libreofficekit/qa/gtktiledviewer/gtv-application-window.hxx:50 GtvApplicationWindow parent_instance GtkApplicationWindow libreofficekit/qa/gtktiledviewer/gtv-application-window.hxx:54 @@ -496,9 +420,9 @@ sal/rtl/alloc_arena.hxx:100 rtl_arena_st m_hash_table_0 struct rtl_arena_segment_type *[64] sal/rtl/alloc_cache.hxx:135 rtl_cache_st m_hash_table_0 struct rtl_cache_bufctl_type *[8] -sal/rtl/digest.cxx:179 +sal/rtl/digest.cxx:181 DigestContextMD2 m_state sal_uInt32 [16] -sal/rtl/digest.cxx:180 +sal/rtl/digest.cxx:182 DigestContextMD2 m_chksum sal_uInt32 [16] sal/rtl/uuid.cxx:64 UUID clock_seq_low sal_uInt8 @@ -506,8 +430,6 @@ sal/rtl/uuid.cxx:65 UUID node sal_uInt8 [6] sc/inc/attrib.hxx:216 ScTableListItem nCount sal_uInt16 -sc/inc/chgviset.hxx:48 - ScChangeViewSettings bEveryoneButMe _Bool sc/inc/clipparam.hxx:41 ScClipParam maProtectedChartRangesVector ScRangeListVector sc/inc/compare.hxx:44 @@ -548,6 +470,62 @@ sc/source/filter/inc/stylesbuffer.hxx:677 oox::xls::Dxf mxProtection std::shared_ptr sc/source/filter/inc/xltracer.hxx:82 XclTracer mbEnabled _Bool +sc/source/filter/xml/xmlimprt.hxx:836 + ScXMLImport pBodyElemTokenMap class SvXMLTokenMap * +sc/source/filter/xml/xmlimprt.hxx:837 + ScXMLImport pContentValidationsElemTokenMap class SvXMLTokenMap * +sc/source/filter/xml/xmlimprt.hxx:839 + ScXMLImport pContentValidationAttrTokenMap class SvXMLTokenMap * +sc/source/filter/xml/xmlimprt.hxx:841 + ScXMLImport pContentValidationHelpMessageAttrTokenMap class SvXMLTokenMap * +sc/source/filter/xml/xmlimprt.hxx:842 + ScXMLImport pContentValidationErrorMessageAttrTokenMap class SvXMLTokenMap * +sc/source/filter/xml/xmlimprt.hxx:843 + ScXMLImport pContentValidationErrorMacroAttrTokenMap class SvXMLTokenMap * +sc/source/filter/xml/xmlimprt.hxx:855 + ScXMLImport pLabelRangesElemTokenMap class SvXMLTokenMap * +sc/source/filter/xml/xmlimprt.hxx:856 + ScXMLImport pLabelRangeAttrTokenMap class SvXMLTokenMap * +sc/source/filter/xml/xmlimprt.hxx:858 + ScXMLImport pTableProtectionElemTokenMap class SvXMLTokenMap * +sc/source/filter/xml/xmlimprt.hxx:860 + ScXMLImport pTableColsElemTokenMap class SvXMLTokenMap * +sc/source/filter/xml/xmlimprt.hxx:861 + ScXMLImport pTableScenarioAttrTokenMap class SvXMLTokenMap * +sc/source/filter/xml/xmlimprt.hxx:862 + ScXMLImport pTableAttrTokenMap class SvXMLTokenMap * +sc/source/filter/xml/xmlimprt.hxx:863 + ScXMLImport pTableColAttrTokenMap class SvXMLTokenMap * +sc/source/filter/xml/xmlimprt.hxx:873 + ScXMLImport pNamedExpressionsElemTokenMap class SvXMLTokenMap * +sc/source/filter/xml/xmlimprt.hxx:874 + ScXMLImport pNamedRangeAttrTokenMap class SvXMLTokenMap * +sc/source/filter/xml/xmlimprt.hxx:875 + ScXMLImport pNamedExpressionAttrTokenMap class SvXMLTokenMap * +sc/source/filter/xml/xmlimprt.hxx:876 + ScXMLImport pDatabaseRangesElemTokenMap class SvXMLTokenMap * +sc/source/filter/xml/xmlimprt.hxx:877 + ScXMLImport pDatabaseRangeElemTokenMap class SvXMLTokenMap * +sc/source/filter/xml/xmlimprt.hxx:878 + ScXMLImport pDatabaseRangeAttrTokenMap class SvXMLTokenMap * +sc/source/filter/xml/xmlimprt.hxx:888 + ScXMLImport pSortAttrTokenMap class SvXMLTokenMap * +sc/source/filter/xml/xmlimprt.hxx:890 + ScXMLImport pDatabaseRangeSubTotalRulesElemTokenMap class SvXMLTokenMap * +sc/source/filter/xml/xmlimprt.hxx:891 + ScXMLImport pDatabaseRangeSubTotalRulesAttrTokenMap class SvXMLTokenMap * +sc/source/filter/xml/xmlimprt.hxx:892 + ScXMLImport pSubTotalRulesSortGroupsAttrTokenMap class SvXMLTokenMap * +sc/source/filter/xml/xmlimprt.hxx:893 + ScXMLImport pSubTotalRulesSubTotalRuleElemTokenMap class SvXMLTokenMap * +sc/source/filter/xml/xmlimprt.hxx:894 + ScXMLImport pSubTotalRulesSubTotalRuleAttrTokenMap class SvXMLTokenMap * +sc/source/filter/xml/xmlimprt.hxx:895 + ScXMLImport pSubTotalRuleSubTotalFieldAttrTokenMap class SvXMLTokenMap * +sc/source/filter/xml/xmlimprt.hxx:911 + ScXMLImport pConsolidationAttrTokenMap class SvXMLTokenMap * +sc/source/filter/xml/xmlimprt.hxx:917 + ScXMLImport pDataStreamAttrTokenMap class SvXMLTokenMap * sc/source/ui/inc/csvruler.hxx:35 ScCsvRuler maBackgrDev ScopedVclPtrInstance sc/source/ui/inc/csvruler.hxx:36 @@ -556,14 +534,6 @@ sc/source/ui/inc/dataprovider.hxx:47 sc::ExternalDataMapper maDocument class ScDocument sc/source/ui/inc/dataprovider.hxx:149 sc::CSVDataProvider mbImportUnderway _Bool -sc/source/ui/inc/tabvwsh.hxx:159 - ScTabViewShell aChartSource ScRangeListRef -sc/source/ui/inc/tabvwsh.hxx:160 - ScTabViewShell aChartPos tools::Rectangle -sc/source/ui/inc/tabvwsh.hxx:161 - ScTabViewShell nChartDestTab SCTAB -sc/source/ui/inc/undobase.hxx:113 - ScMultiBlockUndo meMode enum ScBlockUndoMode scripting/source/stringresource/stringresource.hxx:74 stringresource::LocaleItem m_aIdToIndexMap stringresource::IdToIndexMap sd/inc/sdmod.hxx:117 @@ -606,7 +576,9 @@ slideshow/source/engine/slideshowimpl.cxx:154 (anonymous namespace)::FrameSynchronization maTimer canvas::tools::ElapsedTime sot/source/sdstor/ucbstorage.cxx:421 UCBStorageStream_Impl m_aKey class rtl::OString -starmath/source/view.cxx:864 +starmath/inc/smmod.hxx:70 + SmModule mpLocSymbolData std::unique_ptr +starmath/source/view.cxx:865 SmViewShell_Impl aOpts class SvtMiscOptions svl/source/crypto/cryptosign.cxx:120 (anonymous namespace)::(anonymous) extnID SECItem @@ -624,21 +596,21 @@ svl/source/misc/strmadpt.cxx:55 SvDataPipe_Impl::Page m_aBuffer sal_Int8 [1] svl/source/uno/pathservice.cxx:36 PathService m_aOptions class SvtPathOptions -svtools/source/dialogs/insdlg.cxx:45 - OleObjectDescriptor cbSize sal_uInt32 svtools/source/dialogs/insdlg.cxx:46 - OleObjectDescriptor clsid ClsId + OleObjectDescriptor cbSize sal_uInt32 svtools/source/dialogs/insdlg.cxx:47 - OleObjectDescriptor dwDrawAspect sal_uInt32 + OleObjectDescriptor clsid ClsId svtools/source/dialogs/insdlg.cxx:48 - OleObjectDescriptor sizel class Size + OleObjectDescriptor dwDrawAspect sal_uInt32 svtools/source/dialogs/insdlg.cxx:49 - OleObjectDescriptor pointl class Point + OleObjectDescriptor sizel class Size svtools/source/dialogs/insdlg.cxx:50 - OleObjectDescriptor dwStatus sal_uInt32 + OleObjectDescriptor pointl class Point svtools/source/dialogs/insdlg.cxx:51 - OleObjectDescriptor dwFullUserTypeName sal_uInt32 + OleObjectDescriptor dwStatus sal_uInt32 svtools/source/dialogs/insdlg.cxx:52 + OleObjectDescriptor dwFullUserTypeName sal_uInt32 +svtools/source/dialogs/insdlg.cxx:53 OleObjectDescriptor dwSrcOfCopy sal_uInt32 svtools/source/inc/svimpbox.hxx:121 SvImpLBox m_aNodeAndEntryImages class Image [5] @@ -674,7 +646,7 @@ sw/inc/shellio.hxx:142 SwReader pStg tools::SvRef sw/inc/shellio.hxx:489 SwWriter pStg tools::SvRef -sw/inc/swevent.hxx:81 +sw/inc/swevent.hxx:73 SwCallMouseEvent::(anonymous union)::(anonymous) pFormat const class SwFrameFormat * sw/source/core/doc/swstylemanager.cxx:59 SwStyleManager aAutoCharPool class StylePool @@ -772,12 +744,6 @@ vcl/inc/svdata.hxx:282 ImplSVNWFData mbProgressNeedsErase _Bool vcl/inc/svdata.hxx:291 ImplSVNWFData mbRolloverMenubar _Bool -vcl/inc/unx/i18n_status.hxx:56 - vcl::I18NStatus::ChoiceData aString class rtl::OUString -vcl/source/app/svapp.cxx:159 - ImplEventHook mpUserData void * -vcl/source/app/svapp.cxx:160 - ImplEventHook mpProc VCLEventHookProc vcl/source/filter/jpeg/Exif.hxx:62 Exif::TiffHeader byteOrder sal_uInt16 vcl/source/filter/jpeg/transupp.h:132 @@ -846,11 +812,11 @@ vcl/unx/gtk/gloactiongroup.cxx:28 GLOAction parent_instance GObject vcl/unx/gtk/glomenu.cxx:20 GLOMenu parent_instance GMenuModel -writerfilter/source/ooxml/OOXMLFactory.hxx:60 - writerfilter::ooxml::AttributeInfo m_nToken writerfilter::Token_t writerfilter/source/ooxml/OOXMLFactory.hxx:61 - writerfilter::ooxml::AttributeInfo m_nResource enum writerfilter::ooxml::ResourceType + writerfilter::ooxml::AttributeInfo m_nToken writerfilter::Token_t writerfilter/source/ooxml/OOXMLFactory.hxx:62 + writerfilter::ooxml::AttributeInfo m_nResource enum writerfilter::ooxml::ResourceType +writerfilter/source/ooxml/OOXMLFactory.hxx:63 writerfilter::ooxml::AttributeInfo m_nRef Id xmloff/inc/MultiPropertySetHelper.hxx:78 MultiPropertySetHelper aEmptyAny css::uno::Any diff --git a/compilerplugins/clang/unusedfields.untouched.results b/compilerplugins/clang/unusedfields.untouched.results index 77efd3aeb27d..c5593fc34843 100644 --- a/compilerplugins/clang/unusedfields.untouched.results +++ b/compilerplugins/clang/unusedfields.untouched.results @@ -18,8 +18,6 @@ chart2/source/view/inc/GL3DRenderer.hxx:66 chart::opengl3D::LightSource pad3 float comphelper/source/container/enumerablemap.cxx:299 comphelper::MapEnumeration m_xKeepMapAlive Reference -connectivity/source/commontools/sqlerror.cxx:89 - connectivity::SQLError_Impl m_aContext Reference connectivity/source/drivers/evoab2/EApi.h:122 (anonymous) address_format char * connectivity/source/drivers/evoab2/EApi.h:126 @@ -38,14 +36,20 @@ cppu/source/threadpool/threadpool.cxx:377 _uno_ThreadPool dummy sal_Int32 cppu/source/typelib/typelib.cxx:61 AlignSize_Impl nInt16 sal_Int16 +dbaccess/source/sdbtools/connection/objectnames.cxx:73 + sdbtools::PlainExistenceCheck m_aContext const Reference +dbaccess/source/sdbtools/connection/objectnames.cxx:114 + sdbtools::TableValidityCheck m_aContext const Reference +dbaccess/source/sdbtools/connection/objectnames.cxx:153 + sdbtools::QueryValidityCheck m_aContext const Reference dbaccess/source/sdbtools/inc/connectiondependent.hxx:116 sdbtools::ConnectionDependentComponent::EntryGuard m_aMutexGuard ::osl::MutexGuard emfio/source/emfuno/xemfparser.cxx:59 emfio::emfreader::XEmfParser context_ uno::Reference -extensions/source/propctrlr/propertyhandler.hxx:80 - pcr::PropertyHandler m_aEnsureResAccess class pcr::PcrClient extensions/source/scanner/scanner.hxx:46 ScannerManager maProtector osl::Mutex +filter/source/graphicfilter/icgm/cgm.hxx:138 + CGM mpGDIMetaFile class GDIMetaFile * filter/source/xsltdialog/xmlfiltersettingsdialog.hxx:71 XMLFilterListBox m_aEnsureResLocale class EnsureResLocale filter/source/xsltdialog/xmlfiltersettingsdialog.hxx:130 @@ -54,19 +58,23 @@ include/comphelper/MasterPropertySet.hxx:38 comphelper::SlaveData mxSlave css::uno::Reference include/drawinglayer/primitive2d/textlayoutdevice.hxx:61 drawinglayer::primitive2d::TextLayouterDevice maSolarGuard class SolarMutexGuard +include/editeng/svxrtf.hxx:196 + SvxRTFParser m_xDocProps css::uno::Reference include/editeng/unotext.hxx:608 SvxUnoTextRangeEnumeration mxParentText css::uno::Reference include/LibreOfficeKit/LibreOfficeKitGtk.h:33 _LOKDocView aDrawingArea GtkDrawingArea include/LibreOfficeKit/LibreOfficeKitGtk.h:38 _LOKDocViewClass parent_class GtkDrawingAreaClass +include/sfx2/charwin.hxx:52 + SvxCharView maInsertCharHdl Link include/sfx2/msg.hxx:117 SfxType0 createSfxPoolItemFunc std::function include/sfx2/msg.hxx:119 SfxType0 nAttribs sal_uInt16 include/svtools/genericunodialog.hxx:170 svt::UnoDialogEntryGuard m_aGuard ::osl::MutexGuard -include/svtools/unoevent.hxx:161 +include/svtools/unoevent.hxx:162 SvEventDescriptor xParentRef css::uno::Reference include/vcl/pdfwriter.hxx:550 vcl::PDFWriter::PDFSignContext m_pDerEncoded sal_Int8 * @@ -86,84 +94,10 @@ include/vcl/pdfwriter.hxx:562 vcl::PDFWriter::PDFSignContext m_aSignPassword class rtl::OUString include/vcl/pdfwriter.hxx:564 vcl::PDFWriter::PDFSignContext m_rCMSHexBuffer class rtl::OStringBuffer & -include/vcl/toolbox.hxx:106 - ToolBox maInDockRect tools::Rectangle include/vcl/uitest/uiobject.hxx:241 TabPageUIObject mxTabPage VclPtr include/xmloff/formlayerexport.hxx:173 xmloff::OOfficeFormsExport m_pImpl std::unique_ptr -l10ntools/inc/export.hxx:75 - ResData nIdLevel enum IdLevel -l10ntools/inc/export.hxx:76 - ResData bChild _Bool -l10ntools/inc/export.hxx:77 - ResData bChildWithText _Bool -l10ntools/inc/export.hxx:79 - ResData bText _Bool -l10ntools/inc/export.hxx:80 - ResData bQuickHelpText _Bool -l10ntools/inc/export.hxx:81 - ResData bTitle _Bool -l10ntools/inc/export.hxx:90 - ResData sQuickHelpText OStringHashMap -l10ntools/inc/export.hxx:92 - ResData sTitle OStringHashMap -l10ntools/inc/export.hxx:94 - ResData sTextTyp class rtl::OString -l10ntools/inc/export.hxx:96 - ResData m_aList ExportList -l10ntools/inc/export.hxx:121 - Export::(anonymous) mSimple std::ofstream * -l10ntools/inc/export.hxx:122 - Export::(anonymous) mPo class PoOfstream * -l10ntools/inc/export.hxx:124 - Export aOutput union (anonymous union at /home/noel/libo3/l10ntools/inc/export.hxx:119:5) -l10ntools/inc/export.hxx:126 - Export aResStack ResStack -l10ntools/inc/export.hxx:128 - Export bDefine _Bool -l10ntools/inc/export.hxx:129 - Export bNextMustBeDefineEOL _Bool -l10ntools/inc/export.hxx:130 - Export nLevel std::size_t -l10ntools/inc/export.hxx:131 - Export nList enum ExportListType -l10ntools/inc/export.hxx:132 - Export nListLevel std::size_t -l10ntools/inc/export.hxx:133 - Export bMergeMode _Bool -l10ntools/inc/export.hxx:134 - Export sMergeSrc class rtl::OString -l10ntools/inc/export.hxx:136 - Export bReadOver _Bool -l10ntools/inc/export.hxx:137 - Export sFilename class rtl::OString -l10ntools/inc/export.hxx:139 - Export aLanguages std::vector -l10ntools/inc/export.hxx:280 - MergeData sGID class rtl::OString -l10ntools/inc/export.hxx:281 - MergeData sLID class rtl::OString -l10ntools/inc/export.hxx:334 - QueueEntry nTyp int -l10ntools/inc/export.hxx:335 - QueueEntry sLine class rtl::OString -l10ntools/inc/export.hxx:346 - ParserQueue bCurrentIsM _Bool -l10ntools/inc/export.hxx:347 - ParserQueue bNextIsM _Bool -l10ntools/inc/export.hxx:348 - ParserQueue bLastWasM _Bool -l10ntools/inc/export.hxx:349 - ParserQueue bMflag _Bool -l10ntools/inc/export.hxx:353 - ParserQueue aQueueNext std::queue * -l10ntools/inc/export.hxx:354 - ParserQueue aQueueCur std::queue * -l10ntools/inc/export.hxx:356 - ParserQueue aExport class Export & -l10ntools/inc/export.hxx:357 - ParserQueue bStart _Bool libreofficekit/qa/gtktiledviewer/gtv-application-window.hxx:50 GtvApplicationWindow parent_instance GtkApplicationWindow libreofficekit/qa/gtktiledviewer/gtv-application-window.hxx:54 @@ -224,18 +158,20 @@ sd/source/ui/table/TableDesignPane.hxx:113 sd::TableDesignPane aImpl class sd::TableDesignWidget sd/source/ui/view/DocumentRenderer.cxx:1318 sd::DocumentRenderer::Implementation mxObjectShell SfxObjectShellRef -sd/source/ui/view/viewshel.cxx:1258 +sd/source/ui/view/viewshel.cxx:1257 sd::KeepSlideSorterInSyncWithPageChanges m_aDrawLock sd::slidesorter::view::class SlideSorterView::DrawLock -sd/source/ui/view/viewshel.cxx:1259 +sd/source/ui/view/viewshel.cxx:1258 sd::KeepSlideSorterInSyncWithPageChanges m_aModelLock sd::slidesorter::controller::class SlideSorterController::ModelChangeLock -sd/source/ui/view/viewshel.cxx:1260 +sd/source/ui/view/viewshel.cxx:1259 sd::KeepSlideSorterInSyncWithPageChanges m_aUpdateLock sd::slidesorter::controller::class PageSelector::UpdateLock -sd/source/ui/view/viewshel.cxx:1261 +sd/source/ui/view/viewshel.cxx:1260 sd::KeepSlideSorterInSyncWithPageChanges m_aContext sd::slidesorter::controller::class SelectionObserver::Context -sd/source/ui/view/ViewShellBase.cxx:195 +sd/source/ui/view/ViewShellBase.cxx:194 sd::ViewShellBase::Implementation mpPageCacheManager std::shared_ptr sfx2/source/doc/doctempl.cxx:116 DocTempl::DocTempl_EntryData_Impl mxObjShell class SfxObjectShellLock +starmath/inc/smmod.hxx:70 + SmModule mpLocSymbolData std::unique_ptr starmath/inc/view.hxx:224 SmViewShell maGraphicController class SmGraphicController svl/source/crypto/cryptosign.cxx:120 @@ -272,12 +208,6 @@ unoidl/source/unoidlprovider.cxx:673 unoidl::detail::(anonymous namespace)::UnoidlCursor reference2_ rtl::Reference vcl/inc/opengl/zone.hxx:46 OpenGLVCLContextZone aZone class OpenGLZone -vcl/inc/unx/i18n_status.hxx:56 - vcl::I18NStatus::ChoiceData aString class rtl::OUString -vcl/source/app/svapp.cxx:159 - ImplEventHook mpUserData void * -vcl/source/app/svapp.cxx:160 - ImplEventHook mpProc VCLEventHookProc vcl/source/gdi/jobset.cxx:34 ImplOldJobSetupData cDeviceName char [32] vcl/source/gdi/jobset.cxx:35 diff --git a/compilerplugins/clang/unusedfields.writeonly.results b/compilerplugins/clang/unusedfields.writeonly.results index 7ad5130afe0b..9f36ccff2ff0 100644 --- a/compilerplugins/clang/unusedfields.writeonly.results +++ b/compilerplugins/clang/unusedfields.writeonly.results @@ -104,8 +104,6 @@ comphelper/source/container/enumerablemap.cxx:299 comphelper::MapEnumeration m_xKeepMapAlive Reference configmgr/source/components.cxx:163 configmgr::Components::WriteThread reference_ rtl::Reference * -connectivity/source/commontools/sqlerror.cxx:89 - connectivity::SQLError_Impl m_aContext Reference connectivity/source/drivers/evoab2/EApi.h:122 (anonymous) address_format char * connectivity/source/drivers/evoab2/EApi.h:126 @@ -196,8 +194,14 @@ cui/source/inc/cuihyperdlg.hxx:56 SvxHlinkCtrl aRdOnlyForwarder class SfxStatusForwarder cui/source/inc/cuihyperdlg.hxx:76 SvxHpLinkDlg maCtrl class SvxHlinkCtrl -dbaccess/source/core/dataaccess/documentdefinition.cxx:289 +dbaccess/source/core/dataaccess/documentdefinition.cxx:290 dbaccess::LifetimeCoupler m_xClient Reference +dbaccess/source/sdbtools/connection/objectnames.cxx:73 + sdbtools::PlainExistenceCheck m_aContext const Reference +dbaccess/source/sdbtools/connection/objectnames.cxx:114 + sdbtools::TableValidityCheck m_aContext const Reference +dbaccess/source/sdbtools/connection/objectnames.cxx:153 + sdbtools::QueryValidityCheck m_aContext const Reference desktop/qa/desktop_lib/test_desktop_lib.cxx:175 DesktopLOKTest m_bModified _Bool desktop/source/deployment/gui/dp_gui_updateinstalldialog.cxx:119 @@ -258,8 +262,6 @@ emfio/source/reader/emfreader.cxx:323 (anonymous namespace)::BLENDFUNCTION aBlendOperation unsigned char emfio/source/reader/emfreader.cxx:324 (anonymous namespace)::BLENDFUNCTION aBlendFlags unsigned char -extensions/source/propctrlr/propertyhandler.hxx:80 - pcr::PropertyHandler m_aEnsureResAccess class pcr::PcrClient extensions/source/scanner/scanner.hxx:46 ScannerManager maProtector osl::Mutex extensions/source/scanner/scanner.hxx:47 @@ -284,8 +286,14 @@ include/connectivity/OSubComponent.hxx:54 connectivity::OSubComponent m_xParent css::uno::Reference include/editeng/adjustitem.hxx:39 SvxAdjustItem bLeft _Bool +include/editeng/svxrtf.hxx:190 + SvxRTFParser sBaseURL class rtl::OUString +include/editeng/svxrtf.hxx:196 + SvxRTFParser m_xDocProps css::uno::Reference include/editeng/unotext.hxx:608 SvxUnoTextRangeEnumeration mxParentText css::uno::Reference +include/formula/formdata.hxx:65 + formula::FormEditData nEdFocus sal_uInt16 include/LibreOfficeKit/LibreOfficeKit.h:98 _LibreOfficeKitDocumentClass nSize size_t include/LibreOfficeKit/LibreOfficeKitGtk.h:33 @@ -302,14 +310,22 @@ include/opencl/platforminfo.hxx:30 OpenCLDeviceInfo mnComputeUnits size_t include/opencl/platforminfo.hxx:31 OpenCLDeviceInfo mnFrequency size_t +include/sfx2/charwin.hxx:52 + SvxCharView maInsertCharHdl Link include/sfx2/msg.hxx:117 SfxType0 createSfxPoolItemFunc std::function include/sfx2/msg.hxx:119 SfxType0 nAttribs sal_uInt16 -include/svtools/unoevent.hxx:161 +include/svtools/unoevent.hxx:162 SvEventDescriptor xParentRef css::uno::Reference include/svx/bmpmask.hxx:129 SvxBmpMask aSelItem class SvxBmpMaskSelectItem +include/svx/deflt3d.hxx:41 + E3dDefaultAttributes bDefaultCreateNormals _Bool +include/svx/deflt3d.hxx:42 + E3dDefaultAttributes bDefaultCreateTexture _Bool +include/svx/deflt3d.hxx:47 + E3dDefaultAttributes nDefaultCubeSideFlags enum CubeFaces include/svx/float3d.hxx:199 Svx3DWin pControllerItem class Svx3DCtrlItem * include/svx/imapdlg.hxx:140 @@ -342,8 +358,6 @@ include/vcl/salnativewidgets.hxx:463 PushButtonValue mbBevelButton _Bool include/vcl/salnativewidgets.hxx:464 PushButtonValue mbSingleLine _Bool -include/vcl/toolbox.hxx:106 - ToolBox maInDockRect tools::Rectangle include/vcl/uitest/uiobject.hxx:241 TabPageUIObject mxTabPage VclPtr include/xmloff/formlayerexport.hxx:173 @@ -356,76 +370,6 @@ include/xmloff/shapeimport.hxx:182 SdXML3DSceneAttributesHelper mbVUPUsed _Bool l10ntools/inc/common.hxx:31 common::HandledArgs m_bUTF8BOM _Bool -l10ntools/inc/export.hxx:75 - ResData nIdLevel enum IdLevel -l10ntools/inc/export.hxx:76 - ResData bChild _Bool -l10ntools/inc/export.hxx:77 - ResData bChildWithText _Bool -l10ntools/inc/export.hxx:79 - ResData bText _Bool -l10ntools/inc/export.hxx:80 - ResData bQuickHelpText _Bool -l10ntools/inc/export.hxx:81 - ResData bTitle _Bool -l10ntools/inc/export.hxx:90 - ResData sQuickHelpText OStringHashMap -l10ntools/inc/export.hxx:92 - ResData sTitle OStringHashMap -l10ntools/inc/export.hxx:94 - ResData sTextTyp class rtl::OString -l10ntools/inc/export.hxx:96 - ResData m_aList ExportList -l10ntools/inc/export.hxx:121 - Export::(anonymous) mSimple std::ofstream * -l10ntools/inc/export.hxx:122 - Export::(anonymous) mPo class PoOfstream * -l10ntools/inc/export.hxx:124 - Export aOutput union (anonymous union at /home/noel/libo3/l10ntools/inc/export.hxx:119:5) -l10ntools/inc/export.hxx:126 - Export aResStack ResStack -l10ntools/inc/export.hxx:128 - Export bDefine _Bool -l10ntools/inc/export.hxx:129 - Export bNextMustBeDefineEOL _Bool -l10ntools/inc/export.hxx:130 - Export nLevel std::size_t -l10ntools/inc/export.hxx:131 - Export nList enum ExportListType -l10ntools/inc/export.hxx:132 - Export nListLevel std::size_t -l10ntools/inc/export.hxx:133 - Export bMergeMode _Bool -l10ntools/inc/export.hxx:134 - Export sMergeSrc class rtl::OString -l10ntools/inc/export.hxx:136 - Export bReadOver _Bool -l10ntools/inc/export.hxx:137 - Export sFilename class rtl::OString -l10ntools/inc/export.hxx:139 - Export aLanguages std::vector -l10ntools/inc/export.hxx:280 - MergeData sGID class rtl::OString -l10ntools/inc/export.hxx:281 - MergeData sLID class rtl::OString -l10ntools/inc/export.hxx:334 - QueueEntry nTyp int -l10ntools/inc/export.hxx:335 - QueueEntry sLine class rtl::OString -l10ntools/inc/export.hxx:346 - ParserQueue bCurrentIsM _Bool -l10ntools/inc/export.hxx:347 - ParserQueue bNextIsM _Bool -l10ntools/inc/export.hxx:348 - ParserQueue bLastWasM _Bool -l10ntools/inc/export.hxx:349 - ParserQueue bMflag _Bool -l10ntools/inc/export.hxx:353 - ParserQueue aQueueNext std::queue * -l10ntools/inc/export.hxx:354 - ParserQueue aQueueCur std::queue * -l10ntools/inc/export.hxx:357 - ParserQueue bStart _Bool libreofficekit/qa/gtktiledviewer/gtv-application-window.hxx:50 GtvApplicationWindow parent_instance GtkApplicationWindow libreofficekit/qa/gtktiledviewer/gtv-application-window.hxx:54 @@ -498,7 +442,7 @@ sal/rtl/alloc_cache.hxx:36 rtl_cache_stat_type m_mem_alloc sal_Size sal/rtl/alloc_cache.hxx:151 rtl_cache_st m_cpu_stats struct rtl_cache_stat_type -sal/rtl/math.cxx:878 +sal/rtl/math.cxx:948 md union sal_math_Double sal/textenc/tcvtutf7.cxx:96 ImplUTF7ToUCContextData mbShifted _Bool @@ -590,6 +534,62 @@ sc/source/filter/xml/xmldrani.hxx:76 ScXMLDatabaseRangeContext bIsSelection _Bool sc/source/filter/xml/xmlexternaltabi.hxx:118 ScXMLExternalRefCellContext mnCellType sal_Int16 +sc/source/filter/xml/xmlimprt.hxx:836 + ScXMLImport pBodyElemTokenMap class SvXMLTokenMap * +sc/source/filter/xml/xmlimprt.hxx:837 + ScXMLImport pContentValidationsElemTokenMap class SvXMLTokenMap * +sc/source/filter/xml/xmlimprt.hxx:839 + ScXMLImport pContentValidationAttrTokenMap class SvXMLTokenMap * +sc/source/filter/xml/xmlimprt.hxx:841 + ScXMLImport pContentValidationHelpMessageAttrTokenMap class SvXMLTokenMap * +sc/source/filter/xml/xmlimprt.hxx:842 + ScXMLImport pContentValidationErrorMessageAttrTokenMap class SvXMLTokenMap * +sc/source/filter/xml/xmlimprt.hxx:843 + ScXMLImport pContentValidationErrorMacroAttrTokenMap class SvXMLTokenMap * +sc/source/filter/xml/xmlimprt.hxx:855 + ScXMLImport pLabelRangesElemTokenMap class SvXMLTokenMap * +sc/source/filter/xml/xmlimprt.hxx:856 + ScXMLImport pLabelRangeAttrTokenMap class SvXMLTokenMap * +sc/source/filter/xml/xmlimprt.hxx:858 + ScXMLImport pTableProtectionElemTokenMap class SvXMLTokenMap * +sc/source/filter/xml/xmlimprt.hxx:860 + ScXMLImport pTableColsElemTokenMap class SvXMLTokenMap * +sc/source/filter/xml/xmlimprt.hxx:861 + ScXMLImport pTableScenarioAttrTokenMap class SvXMLTokenMap * +sc/source/filter/xml/xmlimprt.hxx:862 + ScXMLImport pTableAttrTokenMap class SvXMLTokenMap * +sc/source/filter/xml/xmlimprt.hxx:863 + ScXMLImport pTableColAttrTokenMap class SvXMLTokenMap * +sc/source/filter/xml/xmlimprt.hxx:873 + ScXMLImport pNamedExpressionsElemTokenMap class SvXMLTokenMap * +sc/source/filter/xml/xmlimprt.hxx:874 + ScXMLImport pNamedRangeAttrTokenMap class SvXMLTokenMap * +sc/source/filter/xml/xmlimprt.hxx:875 + ScXMLImport pNamedExpressionAttrTokenMap class SvXMLTokenMap * +sc/source/filter/xml/xmlimprt.hxx:876 + ScXMLImport pDatabaseRangesElemTokenMap class SvXMLTokenMap * +sc/source/filter/xml/xmlimprt.hxx:877 + ScXMLImport pDatabaseRangeElemTokenMap class SvXMLTokenMap * +sc/source/filter/xml/xmlimprt.hxx:878 + ScXMLImport pDatabaseRangeAttrTokenMap class SvXMLTokenMap * +sc/source/filter/xml/xmlimprt.hxx:888 + ScXMLImport pSortAttrTokenMap class SvXMLTokenMap * +sc/source/filter/xml/xmlimprt.hxx:890 + ScXMLImport pDatabaseRangeSubTotalRulesElemTokenMap class SvXMLTokenMap * +sc/source/filter/xml/xmlimprt.hxx:891 + ScXMLImport pDatabaseRangeSubTotalRulesAttrTokenMap class SvXMLTokenMap * +sc/source/filter/xml/xmlimprt.hxx:892 + ScXMLImport pSubTotalRulesSortGroupsAttrTokenMap class SvXMLTokenMap * +sc/source/filter/xml/xmlimprt.hxx:893 + ScXMLImport pSubTotalRulesSubTotalRuleElemTokenMap class SvXMLTokenMap * +sc/source/filter/xml/xmlimprt.hxx:894 + ScXMLImport pSubTotalRulesSubTotalRuleAttrTokenMap class SvXMLTokenMap * +sc/source/filter/xml/xmlimprt.hxx:895 + ScXMLImport pSubTotalRuleSubTotalFieldAttrTokenMap class SvXMLTokenMap * +sc/source/filter/xml/xmlimprt.hxx:911 + ScXMLImport pConsolidationAttrTokenMap class SvXMLTokenMap * +sc/source/filter/xml/xmlimprt.hxx:917 + ScXMLImport pDataStreamAttrTokenMap class SvXMLTokenMap * sc/source/ui/inc/dataprovider.hxx:47 sc::ExternalDataMapper maDocument class ScDocument sc/source/ui/inc/dataprovider.hxx:170 @@ -632,18 +632,16 @@ sd/source/ui/table/TableDesignPane.hxx:113 sd::TableDesignPane aImpl class sd::TableDesignWidget sd/source/ui/view/DocumentRenderer.cxx:1318 sd::DocumentRenderer::Implementation mxObjectShell SfxObjectShellRef -sd/source/ui/view/viewshel.cxx:1258 +sd/source/ui/view/viewshel.cxx:1257 sd::KeepSlideSorterInSyncWithPageChanges m_aDrawLock sd::slidesorter::view::class SlideSorterView::DrawLock -sd/source/ui/view/viewshel.cxx:1259 +sd/source/ui/view/viewshel.cxx:1258 sd::KeepSlideSorterInSyncWithPageChanges m_aModelLock sd::slidesorter::controller::class SlideSorterController::ModelChangeLock -sd/source/ui/view/viewshel.cxx:1260 +sd/source/ui/view/viewshel.cxx:1259 sd::KeepSlideSorterInSyncWithPageChanges m_aUpdateLock sd::slidesorter::controller::class PageSelector::UpdateLock -sd/source/ui/view/viewshel.cxx:1261 +sd/source/ui/view/viewshel.cxx:1260 sd::KeepSlideSorterInSyncWithPageChanges m_aContext sd::slidesorter::controller::class SelectionObserver::Context -sd/source/ui/view/ViewShellBase.cxx:195 +sd/source/ui/view/ViewShellBase.cxx:194 sd::ViewShellBase::Implementation mpPageCacheManager std::shared_ptr -sfx2/source/appl/shutdownicon.hxx:70 - ShutdownIcon m_pResLocale std::locale * sfx2/source/doc/doctempl.cxx:116 DocTempl::DocTempl_EntryData_Impl mxObjShell class SfxObjectShellLock sfx2/source/inc/appdata.hxx:75 @@ -660,6 +658,8 @@ slideshow/source/engine/opengl/TransitionImpl.hxx:297 Vertex texcoord glm::vec2 soltools/cpp/cpp.h:143 macroValidator pMacro Nlist * +starmath/inc/smmod.hxx:70 + SmModule mpLocSymbolData std::unique_ptr starmath/inc/view.hxx:163 SmCmdBoxWindow aController class SmEditController starmath/inc/view.hxx:224 @@ -806,14 +806,8 @@ vcl/inc/salwtype.hxx:250 SalSwipeEvent mnVelocityY double vcl/inc/sft.hxx:486 vcl::TrueTypeFont mapper sal_uInt32 (*)(const sal_uInt8 *, sal_uInt32, sal_uInt32) -vcl/inc/unx/i18n_status.hxx:56 - vcl::I18NStatus::ChoiceData aString class rtl::OUString vcl/opengl/salbmp.cxx:412 (anonymous namespace)::ScanlineWriter mpCurrentScanline sal_uInt8 * -vcl/source/app/svapp.cxx:159 - ImplEventHook mpUserData void * -vcl/source/app/svapp.cxx:160 - ImplEventHook mpProc VCLEventHookProc vcl/source/filter/graphicfilter.cxx:1034 ImpFilterLibCache mpLast struct ImpFilterLibCacheEntry * vcl/source/filter/jpeg/Exif.hxx:56 diff --git a/dbaccess/source/sdbtools/connection/objectnames.cxx b/dbaccess/source/sdbtools/connection/objectnames.cxx index 42f58e9d5b5c..69ab85b57be2 100644 --- a/dbaccess/source/sdbtools/connection/objectnames.cxx +++ b/dbaccess/source/sdbtools/connection/objectnames.cxx @@ -70,14 +70,12 @@ namespace sdbtools class PlainExistenceCheck : public INameValidation { private: - const Reference m_aContext; Reference< XConnection > m_xConnection; Reference< XNameAccess > m_xContainer; public: - PlainExistenceCheck( const Reference& _rContext, const Reference< XConnection >& _rxConnection, const Reference< XNameAccess >& _rxContainer ) - :m_aContext( _rContext ) - ,m_xConnection( _rxConnection ) + PlainExistenceCheck( const Reference< XConnection >& _rxConnection, const Reference< XNameAccess >& _rxContainer ) + :m_xConnection( _rxConnection ) ,m_xContainer( _rxContainer ) { OSL_ENSURE( m_xContainer.is(), "PlainExistenceCheck::PlainExistenceCheck: this will crash!" ); @@ -111,13 +109,11 @@ namespace sdbtools // TableValidityCheck class TableValidityCheck : public INameValidation { - const Reference m_aContext; const Reference< XConnection > m_xConnection; public: - TableValidityCheck( const Reference& _rContext, const Reference< XConnection >& _rxConnection ) - :m_aContext( _rContext ) - ,m_xConnection( _rxConnection ) + TableValidityCheck( const Reference< XConnection >& _rxConnection ) + :m_xConnection( _rxConnection ) { } @@ -150,13 +146,11 @@ namespace sdbtools // QueryValidityCheck class QueryValidityCheck : public INameValidation { - const Reference m_aContext; const Reference< XConnection > m_xConnection; public: - QueryValidityCheck( const Reference& _rContext, const Reference< XConnection >& _rxConnection ) - :m_aContext( _rContext ) - ,m_xConnection( _rxConnection ) + QueryValidityCheck( const Reference< XConnection >& _rxConnection ) + :m_xConnection( _rxConnection ) { } @@ -229,9 +223,6 @@ namespace sdbtools const NameCheckFactory& operator=(const NameCheckFactory&) = delete; /** creates an INameValidation instance which can be used to check the existence of query or table names - @param _rContext - the component's context - @param _nCommandType the type of objects (CommandType::TABLE or CommandType::QUERY) of which names shall be checked for existence @@ -245,16 +236,12 @@ namespace sdbtools if the given command type is neither CommandType::TABLE or CommandType::QUERY */ static PNameValidation createExistenceCheck( - const Reference& _rContext, sal_Int32 _nCommandType, const Reference< XConnection >& _rxConnection ); /** creates an INameValidation instance which can be used to check the validity of a query or table name - @param _rContext - the component's context - @param _nCommandType the type of objects (CommandType::TABLE or CommandType::QUERY) of which names shall be validated @@ -268,7 +255,6 @@ namespace sdbtools if the given command type is neither CommandType::TABLE or CommandType::QUERY */ static PNameValidation createValidityCheck( - const Reference& _rContext, const sal_Int32 _nCommandType, const Reference< XConnection >& _rxConnection ); @@ -289,7 +275,7 @@ namespace sdbtools ); } - PNameValidation NameCheckFactory::createExistenceCheck( const Reference& _rContext, sal_Int32 _nCommandType, const Reference< XConnection >& _rxConnection ) + PNameValidation NameCheckFactory::createExistenceCheck( sal_Int32 _nCommandType, const Reference< XConnection >& _rxConnection ) { verifyCommandType( _nCommandType ); @@ -312,8 +298,8 @@ namespace sdbtools ); } - PNameValidation pTableCheck( new PlainExistenceCheck( _rContext, _rxConnection, xTables ) ); - PNameValidation pQueryCheck( new PlainExistenceCheck( _rContext, _rxConnection, xQueries ) ); + PNameValidation pTableCheck( new PlainExistenceCheck( _rxConnection, xTables ) ); + PNameValidation pQueryCheck( new PlainExistenceCheck( _rxConnection, xQueries ) ); PNameValidation pReturn; if ( aMeta.supportsSubqueriesInFrom() ) @@ -325,7 +311,7 @@ namespace sdbtools return pReturn; } - PNameValidation NameCheckFactory::createValidityCheck( const Reference& _rContext, sal_Int32 _nCommandType, const Reference< XConnection >& _rxConnection ) + PNameValidation NameCheckFactory::createValidityCheck( sal_Int32 _nCommandType, const Reference< XConnection >& _rxConnection ) { verifyCommandType( _nCommandType ); @@ -344,8 +330,8 @@ namespace sdbtools } if ( _nCommandType == CommandType::TABLE ) - return PNameValidation( new TableValidityCheck( _rContext, _rxConnection ) ); - return PNameValidation( new QueryValidityCheck( _rContext, _rxConnection ) ); + return PNameValidation( new TableValidityCheck( _rxConnection ) ); + return PNameValidation( new QueryValidityCheck( _rxConnection ) ); } // ObjectNames @@ -363,7 +349,7 @@ namespace sdbtools { EntryGuard aGuard( *this ); - PNameValidation pNameCheck( NameCheckFactory::createExistenceCheck( getContext(), CommandType, getConnection() ) ); + PNameValidation pNameCheck( NameCheckFactory::createExistenceCheck( CommandType, getConnection() ) ); OUString sBaseName( BaseName ); if ( sBaseName.isEmpty() ) @@ -399,7 +385,7 @@ namespace sdbtools { EntryGuard aGuard( *this ); - PNameValidation pNameCheck( NameCheckFactory::createExistenceCheck( getContext(), CommandType, getConnection()) ); + PNameValidation pNameCheck( NameCheckFactory::createExistenceCheck( CommandType, getConnection()) ); return !pNameCheck->validateName( Name ); } @@ -407,7 +393,7 @@ namespace sdbtools { EntryGuard aGuard( *this ); - PNameValidation pNameCheck( NameCheckFactory::createValidityCheck( getContext(), CommandType, getConnection()) ); + PNameValidation pNameCheck( NameCheckFactory::createValidityCheck( CommandType, getConnection()) ); return pNameCheck->validateName( Name ); } @@ -415,10 +401,10 @@ namespace sdbtools { EntryGuard aGuard( *this ); - PNameValidation pNameCheck( NameCheckFactory::createExistenceCheck( getContext(), CommandType, getConnection() ) ); + PNameValidation pNameCheck( NameCheckFactory::createExistenceCheck( CommandType, getConnection() ) ); pNameCheck->validateName_throw( Name ); - pNameCheck = NameCheckFactory::createValidityCheck( getContext(), CommandType, getConnection() ); + pNameCheck = NameCheckFactory::createValidityCheck( CommandType, getConnection() ); pNameCheck->validateName_throw( Name ); } diff --git a/editeng/source/editeng/eertfpar.cxx b/editeng/source/editeng/eertfpar.cxx index b64cc7bf10ed..96dac9e61b63 100644 --- a/editeng/source/editeng/eertfpar.cxx +++ b/editeng/source/editeng/eertfpar.cxx @@ -65,7 +65,7 @@ RtfImportInfo::~RtfImportInfo() EditRTFParser::EditRTFParser( SvStream& rIn, EditSelection aSel, SfxItemPool& rAttrPool, EditEngine* pEditEngine) : - SvxRTFParser(rAttrPool, rIn, nullptr), + SvxRTFParser(rAttrPool, rIn), aCurSel(std::move(aSel)), mpEditEngine(pEditEngine), aRTFMapMode(MapUnit::MapTwip), diff --git a/editeng/source/rtf/svxrtf.cxx b/editeng/source/rtf/svxrtf.cxx index 188e545d3ac6..9d5a0cf7fe50 100644 --- a/editeng/source/rtf/svxrtf.cxx +++ b/editeng/source/rtf/svxrtf.cxx @@ -57,14 +57,12 @@ static rtl_TextEncoding lcl_GetDefaultTextEncodingForRTF() // -------------- Methods -------------------- -SvxRTFParser::SvxRTFParser( SfxItemPool& rPool, SvStream& rIn, - uno::Reference const & i_xDocProps ) +SvxRTFParser::SvxRTFParser( SfxItemPool& rPool, SvStream& rIn ) : SvRTFParser( rIn, 5 ) , aPlainMap(rPool) , aPardMap(rPool) , pInsPos( nullptr ) , pAttrPool( &rPool ) - , m_xDocProps( i_xDocProps ) , pRTFDefaults( nullptr ) , nDfltFont( 0) , bNewDoc( true ) @@ -119,8 +117,6 @@ SvParserState SvxRTFParser::CallParser() bNewGroup = false; nDfltFont = 0; - sBaseURL.clear(); - // generate the correct WhichId table from the set WhichIds. BuildWhichTable(); diff --git a/filter/source/graphicfilter/icgm/cgm.cxx b/filter/source/graphicfilter/icgm/cgm.cxx index 758f4e0a2fa8..3befe6f0d750 100644 --- a/filter/source/graphicfilter/icgm/cgm.cxx +++ b/filter/source/graphicfilter/icgm/cgm.cxx @@ -63,7 +63,6 @@ CGM::CGM(uno::Reference< frame::XModel > const & rModel) , mnElementClass(0) , mnElementID(0) , mnElementSize(0) - , mpGDIMetaFile(nullptr) { pElement = new CGMElements; pCopyOfE = new CGMElements; diff --git a/filter/source/graphicfilter/icgm/cgm.hxx b/filter/source/graphicfilter/icgm/cgm.hxx index 2921ce726ca7..176da5e80608 100644 --- a/filter/source/graphicfilter/icgm/cgm.hxx +++ b/filter/source/graphicfilter/icgm/cgm.hxx @@ -135,7 +135,6 @@ class CGM ~CGM(); CGM(css::uno::Reference< css::frame::XModel > const & rModel); - GDIMetaFile* mpGDIMetaFile; sal_uInt32 GetBackGroundColor(); bool IsValid() const { return mbStatus; }; bool IsFinished() const { return mbIsFinished; }; diff --git a/formula/source/ui/dlg/formula.cxx b/formula/source/ui/dlg/formula.cxx index 2c21e5a584e7..ef446966f694 100644 --- a/formula/source/ui/dlg/formula.cxx +++ b/formula/source/ui/dlg/formula.cxx @@ -1160,7 +1160,6 @@ void FormulaDlg_Impl::SetData( sal_Int32 nFStart, sal_Int32 nNextFStart, sal_Int FormEditData* pData = m_pHelper->getFormEditData(); pData->SetFStart( nNextFStart ); pData->SetOffset( 0 ); - pData->SetEdFocus( 0 ); FillDialog(); } @@ -1314,7 +1313,6 @@ IMPL_LINK( FormulaDlg_Impl, FxHdl, ParaWin&, rPtr, void ) OUString aFormula = m_pHelper->getCurrentFormula(); sal_Int32 n1 = m_aFormulaHelper.GetArgStart( aFormula, nFormulaStrPos, nEdFocus + pData->GetOffset() ); - pData->SetEdFocus( nEdFocus ); pData->SaveValues(); pData->SetMode( (sal_uInt16) FORMULA_FORMDLG_FORMULA ); pData->SetFStart( n1 ); @@ -1961,7 +1959,6 @@ void FormEditData::Reset() nMode = 0; nFStart = 0; nOffset = 0; - nEdFocus = 0; bMatrix = false; xFocusWin.clear(); aSelection.Min() = 0; @@ -1974,7 +1971,6 @@ FormEditData& FormEditData::operator=( const FormEditData& r ) nMode = r.nMode; nFStart = r.nFStart; nOffset = r.nOffset; - nEdFocus = r.nEdFocus; aUndoStr = r.aUndoStr; bMatrix = r.bMatrix ; xFocusWin = r.xFocusWin; diff --git a/include/editeng/svxrtf.hxx b/include/editeng/svxrtf.hxx index e2c05b6dbcae..f33b3dc0e3a8 100644 --- a/include/editeng/svxrtf.hxx +++ b/include/editeng/svxrtf.hxx @@ -187,13 +187,11 @@ class EDITENG_DLLPUBLIC SvxRTFParser : public SvRTFParser RTFPlainAttrMapIds aPlainMap; RTFPardAttrMapIds aPardMap; std::vector aWhichMap; - OUString sBaseURL; EditPosition* pInsPos; SfxItemPool* pAttrPool; Color* pDfltColor; vcl::Font* pDfltFont; - css::uno::Reference< css::document::XDocumentProperties> m_xDocProps; SfxItemSet *pRTFDefaults; int nDfltFont; @@ -273,9 +271,7 @@ protected: // if no-one would like to have any twips virtual void CalcValue(); - SvxRTFParser( SfxItemPool& rAttrPool, - SvStream& rIn, - css::uno::Reference< css::document::XDocumentProperties> const & i_xDocProps ); + SvxRTFParser( SfxItemPool& rAttrPool, SvStream& rIn ); virtual ~SvxRTFParser() override; void SetNewDoc( bool bFlag ) { bNewDoc = bFlag; } diff --git a/include/formula/formdata.hxx b/include/formula/formdata.hxx index 651ebbe43445..1188ab884461 100644 --- a/include/formula/formdata.hxx +++ b/include/formula/formdata.hxx @@ -48,7 +48,6 @@ public: void SetMode( sal_uInt16 nNew ) { nMode = nNew; } void SetFStart( sal_Int32 nNew ) { nFStart = nNew; } void SetOffset( sal_uInt16 nNew ) { nOffset = nNew; } - void SetEdFocus( sal_uInt16 nNew ) { nEdFocus = nNew; } void SetUndoStr( const OUString& rNew ) { aUndoStr = rNew; } void SetMatrixFlag(bool bNew) { bMatrix=bNew;} void SetFocusWindow(const VclPtr& rWin) { xFocusWin=rWin;} @@ -62,7 +61,6 @@ private: sal_uInt16 nMode; // enum ScFormulaDlgMode sal_Int32 nFStart; sal_uInt16 nOffset; - sal_uInt16 nEdFocus; OUString aUndoStr; bool bMatrix; VclPtr xFocusWin; diff --git a/include/sfx2/charwin.hxx b/include/sfx2/charwin.hxx index 51af2d7f56be..ecfe66269466 100644 --- a/include/sfx2/charwin.hxx +++ b/include/sfx2/charwin.hxx @@ -57,7 +57,6 @@ private: Point maPosition; vcl::Font maFont; - Link maInsertCharHdl; Link maMouseClickHdl; Link maClearClickHdl; Link maClearAllClickHdl; diff --git a/include/svx/deflt3d.hxx b/include/svx/deflt3d.hxx index 56ddcd034543..8181907d3e16 100644 --- a/include/svx/deflt3d.hxx +++ b/include/svx/deflt3d.hxx @@ -38,13 +38,10 @@ class SAL_WARN_UNUSED SVX_DLLPUBLIC E3dDefaultAttributes private: // Compound object Color aDefaultAmbientColor; - bool bDefaultCreateNormals; - bool bDefaultCreateTexture; // Cube object basegfx::B3DPoint aDefaultCubePos; basegfx::B3DVector aDefaultCubeSize; - CubeFaces nDefaultCubeSideFlags; bool bDefaultCubePosIsCenter; // Sphere object diff --git a/svx/source/engine3d/deflt3d.cxx b/svx/source/engine3d/deflt3d.cxx index feb02a9ab00e..ba1ab8835ddb 100644 --- a/svx/source/engine3d/deflt3d.cxx +++ b/svx/source/engine3d/deflt3d.cxx @@ -33,14 +33,9 @@ E3dDefaultAttributes::E3dDefaultAttributes() void E3dDefaultAttributes::Reset() { - // Compound object - bDefaultCreateNormals = true; - bDefaultCreateTexture = true; - // Cube object aDefaultCubePos = basegfx::B3DPoint(-500.0, -500.0, -500.0); aDefaultCubeSize = basegfx::B3DVector(1000.0, 1000.0, 1000.0); - nDefaultCubeSideFlags = CubeFaces::Full; bDefaultCubePosIsCenter = false; // Sphere object -- cgit