From 5858f628829ccd14e4915c138d798e03dba20edc Mon Sep 17 00:00:00 2001 From: Muhammet Kara Date: Wed, 18 Mar 2020 13:56:43 +0300 Subject: Sidebar tdf#92768: Fix title & subtitle checkboxes on the ChartDeck Turns out the 2nd part of tdf#92768 was not implemented yet, so it is still necessary to remove the title/subtitle for good, otherwise we set the "Visibility" property, but nothing actually reads that when rendering. So the titles now work as they did before the regression. An uncheck action removes the title/subtitle, and a check action just makes the existing title/subtitle visible or creates a new one if it doesn't exist Change-Id: I23122d1be2d95af878b824ba194bd1aeed5f4f89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90692 Tested-by: Jenkins CollaboraOffice Reviewed-by: Andras Timar Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105737 Tested-by: Jenkins Reviewed-by: Jan Holesovsky --- chart2/source/controller/sidebar/ChartElementsPanel.cxx | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/chart2/source/controller/sidebar/ChartElementsPanel.cxx b/chart2/source/controller/sidebar/ChartElementsPanel.cxx index 4158924fbfb0..c380459cfd9f 100644 --- a/chart2/source/controller/sidebar/ChartElementsPanel.cxx +++ b/chart2/source/controller/sidebar/ChartElementsPanel.cxx @@ -663,7 +663,9 @@ void ChartElementsPanel::setTitleVisible(TitleHelper::eTitleType eTitle, bool bV } else { - TitleHelper::hideTitle(eTitle, mxModel); + // TODO tdf#92768 use TitleHelper::hideTitle() here once there is + // rendering suport for the property "Visible" + TitleHelper::removeTitle(eTitle, mxModel); } } -- cgit