From 5eac2e6bcc11c1a30cb29d2f1e0289e15e8f1d05 Mon Sep 17 00:00:00 2001 From: Stephan Bergmann Date: Fri, 7 Dec 2018 22:52:29 +0100 Subject: Remove misguided FALLTHROUGH comments ...between adjacent switch labels without any intervening statements Change-Id: Ieb8a0d9f71ea4382b5f7d005cdf7111d06aeb5d0 Reviewed-on: https://gerrit.libreoffice.org/64789 Tested-by: Jenkins Reviewed-by: Stephan Bergmann --- canvas/source/cairo/cairo_canvashelper_text.cxx | 1 - canvas/source/directx/dx_canvashelper.cxx | 11 --- .../source/directx/dx_canvashelper_texturefill.cxx | 1 - canvas/source/directx/dx_vcltools.cxx | 24 ----- canvas/source/opengl/ogl_canvashelper.cxx | 1 - canvas/source/vcl/canvashelper.cxx | 1 - canvas/source/vcl/canvashelper_texturefill.cxx | 1 - cppcanvas/source/mtfrenderer/implrenderer.cxx | 1 - cppcanvas/source/mtfrenderer/mtftools.cxx | 10 -- filter/source/svg/presentation_engine.js | 4 - sd/source/filter/ppt/pptinanimations.cxx | 2 - sdext/source/pdfimport/wrapper/wrapper.cxx | 2 - slideshow/source/engine/animationfactory.cxx | 101 --------------------- .../animationnodes/animationtransformnode.cxx | 1 - .../engine/slide/targetpropertiescreator.cxx | 7 -- .../engine/transitions/slidetransitionfactory.cxx | 2 - vcl/win/window/salframe.cxx | 1 - 17 files changed, 171 deletions(-) diff --git a/canvas/source/cairo/cairo_canvashelper_text.cxx b/canvas/source/cairo/cairo_canvashelper_text.cxx index e7ce4131b251..11d429a8801a 100644 --- a/canvas/source/cairo/cairo_canvashelper_text.cxx +++ b/canvas/source/cairo/cairo_canvashelper_text.cxx @@ -248,7 +248,6 @@ namespace cairocanvas switch( textDirection ) { case rendering::TextDirection::WEAK_LEFT_TO_RIGHT: - // FALLTHROUGH intended case rendering::TextDirection::STRONG_LEFT_TO_RIGHT: nLayoutMode |= ComplexTextLayoutFlags::BiDiStrong; nLayoutMode |= ComplexTextLayoutFlags::TextOriginLeft; diff --git a/canvas/source/directx/dx_canvashelper.cxx b/canvas/source/directx/dx_canvashelper.cxx index ecba3af57952..0db0f187d595 100644 --- a/canvas/source/directx/dx_canvashelper.cxx +++ b/canvas/source/directx/dx_canvashelper.cxx @@ -664,7 +664,6 @@ namespace dxcanvas switch( nMode ) { case rendering::CompositeOperation::OVER: - // FALLTHROUGH intended case rendering::CompositeOperation::CLEAR: aRet = Gdiplus::CompositingModeSourceOver; break; @@ -674,25 +673,15 @@ namespace dxcanvas break; case rendering::CompositeOperation::DESTINATION: - // FALLTHROUGH intended case rendering::CompositeOperation::UNDER: - // FALLTHROUGH intended case rendering::CompositeOperation::INSIDE: - // FALLTHROUGH intended case rendering::CompositeOperation::INSIDE_REVERSE: - // FALLTHROUGH intended case rendering::CompositeOperation::OUTSIDE: - // FALLTHROUGH intended case rendering::CompositeOperation::OUTSIDE_REVERSE: - // FALLTHROUGH intended case rendering::CompositeOperation::ATOP: - // FALLTHROUGH intended case rendering::CompositeOperation::ATOP_REVERSE: - // FALLTHROUGH intended case rendering::CompositeOperation::XOR: - // FALLTHROUGH intended case rendering::CompositeOperation::ADD: - // FALLTHROUGH intended case rendering::CompositeOperation::SATURATE: // TODO(F2): Problem, because GDI+ only knows about two compositing modes aRet = Gdiplus::CompositingModeSourceOver; diff --git a/canvas/source/directx/dx_canvashelper_texturefill.cxx b/canvas/source/directx/dx_canvashelper_texturefill.cxx index 8782114fbebe..df0d27f154ef 100644 --- a/canvas/source/directx/dx_canvashelper_texturefill.cxx +++ b/canvas/source/directx/dx_canvashelper_texturefill.cxx @@ -440,7 +440,6 @@ namespace dxcanvas break; case ::canvas::ParametricPolyPolygon::GradientType::Elliptical: - // FALLTHROUGH intended case ::canvas::ParametricPolyPolygon::GradientType::Rectangular: fillPolygonalGradient( rValues, rColors, diff --git a/canvas/source/directx/dx_vcltools.cxx b/canvas/source/directx/dx_vcltools.cxx index 07a71b330ae9..d91e60a99166 100644 --- a/canvas/source/directx/dx_vcltools.cxx +++ b/canvas/source/directx/dx_vcltools.cxx @@ -252,11 +252,8 @@ namespace dxcanvas // to hand-formulate the following // formats, too. case ScanlineFormat::N1BitMsbPal: - // FALLTHROUGH intended case ScanlineFormat::N4BitMsnPal: - // FALLTHROUGH intended case ScanlineFormat::N16BitTcLsbMask: - // FALLTHROUGH intended case ScanlineFormat::N32BitTcMask: { Scanline pAScan = pAlphaReadAccess->GetScanline( y ); @@ -281,23 +278,14 @@ namespace dxcanvas break; case ScanlineFormat::N1BitLsbPal: - // FALLTHROUGH intended case ScanlineFormat::N4BitLsnPal: - // FALLTHROUGH intended case ScanlineFormat::N8BitTcMask: - // FALLTHROUGH intended case ScanlineFormat::N24BitTcRgb: - // FALLTHROUGH intended case ScanlineFormat::N16BitTcMsbMask: - // FALLTHROUGH intended case ScanlineFormat::N32BitTcAbgr: - // FALLTHROUGH intended case ScanlineFormat::N32BitTcArgb: - // FALLTHROUGH intended case ScanlineFormat::N32BitTcBgra: - // FALLTHROUGH intended case ScanlineFormat::N32BitTcRgba: - // FALLTHROUGH intended default: ENSURE_OR_THROW( false, "::dxcanvas::tools::bitmapFromVCLBitmapEx(): " @@ -403,11 +391,8 @@ namespace dxcanvas // to hand-formulate the following // formats, too. case ScanlineFormat::N1BitMsbPal: - // FALLTHROUGH intended case ScanlineFormat::N4BitMsnPal: - // FALLTHROUGH intended case ScanlineFormat::N16BitTcLsbMask: - // FALLTHROUGH intended case ScanlineFormat::N32BitTcMask: { Scanline pMScan = pMaskReadAccess->GetScanline( y ); @@ -431,23 +416,14 @@ namespace dxcanvas break; case ScanlineFormat::N1BitLsbPal: - // FALLTHROUGH intended case ScanlineFormat::N4BitLsnPal: - // FALLTHROUGH intended case ScanlineFormat::N8BitTcMask: - // FALLTHROUGH intended case ScanlineFormat::N24BitTcRgb: - // FALLTHROUGH intended case ScanlineFormat::N16BitTcMsbMask: - // FALLTHROUGH intended case ScanlineFormat::N32BitTcAbgr: - // FALLTHROUGH intended case ScanlineFormat::N32BitTcArgb: - // FALLTHROUGH intended case ScanlineFormat::N32BitTcBgra: - // FALLTHROUGH intended case ScanlineFormat::N32BitTcRgba: - // FALLTHROUGH intended default: ENSURE_OR_THROW( false, "::dxcanvas::tools::bitmapFromVCLBitmapEx(): " diff --git a/canvas/source/opengl/ogl_canvashelper.cxx b/canvas/source/opengl/ogl_canvashelper.cxx index 41ecfebc31e4..f99047a18ccf 100644 --- a/canvas/source/opengl/ogl_canvashelper.cxx +++ b/canvas/source/opengl/ogl_canvashelper.cxx @@ -875,7 +875,6 @@ namespace oglcanvas o_action.meDstBlendMode=GL_ZERO; break; case rendering::CompositeOperation::UNDER: - // FALLTHROUGH intended - but correct?! case rendering::CompositeOperation::DESTINATION: o_action.meSrcBlendMode=GL_ZERO; o_action.meDstBlendMode=GL_ONE; diff --git a/canvas/source/vcl/canvashelper.cxx b/canvas/source/vcl/canvashelper.cxx index 282af010aa96..e913dfa667bf 100644 --- a/canvas/source/vcl/canvashelper.cxx +++ b/canvas/source/vcl/canvashelper.cxx @@ -579,7 +579,6 @@ namespace vclcanvas switch( textDirection ) { case rendering::TextDirection::WEAK_LEFT_TO_RIGHT: - // FALLTHROUGH intended case rendering::TextDirection::STRONG_LEFT_TO_RIGHT: nLayoutMode |= ComplexTextLayoutFlags::BiDiStrong; nLayoutMode |= ComplexTextLayoutFlags::TextOriginLeft; diff --git a/canvas/source/vcl/canvashelper_texturefill.cxx b/canvas/source/vcl/canvashelper_texturefill.cxx index c29fa6f3f12d..cdbceba7cff2 100644 --- a/canvas/source/vcl/canvashelper_texturefill.cxx +++ b/canvas/source/vcl/canvashelper_texturefill.cxx @@ -418,7 +418,6 @@ namespace vclcanvas break; case ::canvas::ParametricPolyPolygon::GradientType::Elliptical: - // FALLTHROUGH intended case ::canvas::ParametricPolyPolygon::GradientType::Rectangular: fillPolygonalGradient( rOutDev, rTextureTransform, diff --git a/cppcanvas/source/mtfrenderer/implrenderer.cxx b/cppcanvas/source/mtfrenderer/implrenderer.cxx index 999a96524da2..5c5b43fb3c89 100644 --- a/cppcanvas/source/mtfrenderer/implrenderer.cxx +++ b/cppcanvas/source/mtfrenderer/implrenderer.cxx @@ -1273,7 +1273,6 @@ namespace cppcanvas break; case MetaActionType::TEXTLANGUAGE: - // FALLTHROUGH intended case MetaActionType::REFPOINT: // handled via pCurrAct->Execute( &rVDev ) break; diff --git a/cppcanvas/source/mtfrenderer/mtftools.cxx b/cppcanvas/source/mtfrenderer/mtftools.cxx index 7b051ef2c5d4..882857959b7b 100644 --- a/cppcanvas/source/mtfrenderer/mtftools.cxx +++ b/cppcanvas/source/mtfrenderer/mtftools.cxx @@ -416,16 +416,12 @@ namespace cppcanvas switch( rTextLineInfo.mnOverlineStyle ) { case LINESTYLE_NONE: // nothing to do - // FALLTHROUGH intended case LINESTYLE_DONTKNOW: break; case LINESTYLE_DOUBLEWAVE: - // FALLTHROUGH intended case LINESTYLE_SMALLWAVE: - // FALLTHROUGH intended case LINESTYLE_BOLDWAVE: - // FALLTHROUGH intended case LINESTYLE_WAVE: appendWaveline( rTextLinesPolyPoly, @@ -498,16 +494,12 @@ namespace cppcanvas switch( rTextLineInfo.mnUnderlineStyle ) { case LINESTYLE_NONE: // nothing to do - // FALLTHROUGH intended case LINESTYLE_DONTKNOW: break; case LINESTYLE_DOUBLEWAVE: - // FALLTHROUGH intended case LINESTYLE_SMALLWAVE: - // FALLTHROUGH intended case LINESTYLE_BOLDWAVE: - // FALLTHROUGH intended case LINESTYLE_WAVE: appendWaveline( rTextLinesPolyPoly, @@ -579,12 +571,10 @@ namespace cppcanvas switch( rTextLineInfo.mnStrikeoutStyle ) { case STRIKEOUT_NONE: // nothing to do - // FALLTHROUGH intended case STRIKEOUT_DONTKNOW: break; case STRIKEOUT_SLASH: // TODO(Q1): we should handle this in the text layer - // FALLTHROUGH intended case STRIKEOUT_X: break; diff --git a/filter/source/svg/presentation_engine.js b/filter/source/svg/presentation_engine.js index 7c6c190f9347..51919f51e4ed 100644 --- a/filter/source/svg/presentation_engine.js +++ b/filter/source/svg/presentation_engine.js @@ -14802,9 +14802,7 @@ function createActivity( aActivityParamSet, aAnimationNode, aAnimation, aInterpo log( 'createActivity: unexpected calculation mode: ' + eCalcMode ); // FALLTHROUGH intended case CALC_MODE_PACED : - // FALLTHROUGH intended case CALC_MODE_SPLINE : - // FALLTHROUGH intended case CALC_MODE_LINEAR: return createValueListActivity( aActivityParamSet, aAnimationNode, @@ -14837,9 +14835,7 @@ function createActivity( aActivityParamSet, aAnimationNode, aAnimation, aInterpo log( 'createActivity: unexpected calculation mode: ' + eCalcMode ); // FALLTHROUGH intended case CALC_MODE_PACED : - // FALLTHROUGH intended case CALC_MODE_SPLINE : - // FALLTHROUGH intended case CALC_MODE_LINEAR: return createFromToByActivity( aActivityParamSet, aAnimationNode, diff --git a/sd/source/filter/ppt/pptinanimations.cxx b/sd/source/filter/ppt/pptinanimations.cxx index e90087c343bc..3262c9e734e6 100644 --- a/sd/source/filter/ppt/pptinanimations.cxx +++ b/sd/source/filter/ppt/pptinanimations.cxx @@ -1294,9 +1294,7 @@ sal_Int16 AnimationImporter::implGetColorSpace( sal_Int32 nMode, sal_Int32 /*nA* switch( nMode ) { case 2: // index - // FALLTHROUGH intended default: - // FALLTHROUGH intended case 0: // rgb return AnimationColorSpace::RGB; diff --git a/sdext/source/pdfimport/wrapper/wrapper.cxx b/sdext/source/pdfimport/wrapper/wrapper.cxx index 420e828198c2..89f6c83abff3 100644 --- a/sdext/source/pdfimport/wrapper/wrapper.cxx +++ b/sdext/source/pdfimport/wrapper/wrapper.cxx @@ -401,7 +401,6 @@ void Parser::readLineCap() switch( readInt32() ) { default: - // FALLTHROUGH intended case 0: nCap = rendering::PathCapType::BUTT; break; case 1: nCap = rendering::PathCapType::ROUND; break; case 2: nCap = rendering::PathCapType::SQUARE; break; @@ -434,7 +433,6 @@ void Parser::readLineJoin() switch( readInt32() ) { default: - // FALLTHROUGH intended case 0: nJoin = rendering::PathJoinType::MITER; break; case 1: nJoin = rendering::PathJoinType::ROUND; break; case 2: nJoin = rendering::PathJoinType::BEVEL; break; diff --git a/slideshow/source/engine/animationfactory.cxx b/slideshow/source/engine/animationfactory.cxx index 2451a71bb2dd..38f3eb0825f8 100644 --- a/slideshow/source/engine/animationfactory.cxx +++ b/slideshow/source/engine/animationfactory.cxx @@ -732,18 +732,13 @@ namespace slideshow switch( mapAttributeName( rAttrName ) ) { default: - // FALLTHROUGH intended case AttributeType::Invalid: return CLASS_UNKNOWN_PROPERTY; case AttributeType::CharColor: - // FALLTHROUGH intended case AttributeType::Color: - // FALLTHROUGH intended case AttributeType::DimColor: - // FALLTHROUGH intended case AttributeType::FillColor: - // FALLTHROUGH intended case AttributeType::LineColor: return CLASS_COLOR_PROPERTY; @@ -754,32 +749,20 @@ namespace slideshow return CLASS_BOOL_PROPERTY; case AttributeType::CharHeight: - // FALLTHROUGH intended case AttributeType::CharWeight: - // FALLTHROUGH intended case AttributeType::Height: - // FALLTHROUGH intended case AttributeType::Opacity: - // FALLTHROUGH intended case AttributeType::Rotate: - // FALLTHROUGH intended case AttributeType::SkewX: - // FALLTHROUGH intended case AttributeType::SkewY: - // FALLTHROUGH intended case AttributeType::Width: - // FALLTHROUGH intended case AttributeType::PosX: - // FALLTHROUGH intended case AttributeType::PosY: return CLASS_NUMBER_PROPERTY; case AttributeType::CharUnderline: - // FALLTHROUGH intended case AttributeType::FillStyle: - // FALLTHROUGH intended case AttributeType::LineStyle: - // FALLTHROUGH intended case AttributeType::CharPosture: return CLASS_ENUM_PROPERTY; } @@ -796,32 +779,21 @@ namespace slideshow switch( mapAttributeName( rAttrName ) ) { default: - // FALLTHROUGH intended case AttributeType::Invalid: ENSURE_OR_THROW( false, "AnimationFactory::createNumberPropertyAnimation(): Unknown attribute" ); break; case AttributeType::CharColor: - // FALLTHROUGH intended case AttributeType::CharFontName: - // FALLTHROUGH intended case AttributeType::CharPosture: - // FALLTHROUGH intended case AttributeType::CharUnderline: - // FALLTHROUGH intended case AttributeType::Color: - // FALLTHROUGH intended case AttributeType::DimColor: - // FALLTHROUGH intended case AttributeType::FillColor: - // FALLTHROUGH intended case AttributeType::FillStyle: - // FALLTHROUGH intended case AttributeType::LineColor: - // FALLTHROUGH intended case AttributeType::LineStyle: - // FALLTHROUGH intended case AttributeType::Visibility: ENSURE_OR_THROW( false, "AnimationFactory::createNumberPropertyAnimation(): Attribute type mismatch" ); @@ -952,44 +924,27 @@ namespace slideshow switch( mapAttributeName( rAttrName ) ) { default: - // FALLTHROUGH intended case AttributeType::Invalid: ENSURE_OR_THROW( false, "AnimationFactory::createEnumPropertyAnimation(): Unknown attribute" ); break; case AttributeType::CharColor: - // FALLTHROUGH intended case AttributeType::CharFontName: - // FALLTHROUGH intended case AttributeType::Color: - // FALLTHROUGH intended case AttributeType::DimColor: - // FALLTHROUGH intended case AttributeType::FillColor: - // FALLTHROUGH intended case AttributeType::LineColor: - // FALLTHROUGH intended case AttributeType::Visibility: - // FALLTHROUGH intended case AttributeType::CharHeight: - // FALLTHROUGH intended case AttributeType::CharWeight: - // FALLTHROUGH intended case AttributeType::Height: - // FALLTHROUGH intended case AttributeType::Opacity: - // FALLTHROUGH intended case AttributeType::Rotate: - // FALLTHROUGH intended case AttributeType::SkewX: - // FALLTHROUGH intended case AttributeType::SkewY: - // FALLTHROUGH intended case AttributeType::Width: - // FALLTHROUGH intended case AttributeType::PosX: - // FALLTHROUGH intended case AttributeType::PosY: ENSURE_OR_THROW( false, "AnimationFactory::createEnumPropertyAnimation(): Attribute type mismatch" ); @@ -1046,42 +1001,26 @@ namespace slideshow switch( mapAttributeName( rAttrName ) ) { default: - // FALLTHROUGH intended case AttributeType::Invalid: ENSURE_OR_THROW( false, "AnimationFactory::createColorPropertyAnimation(): Unknown attribute" ); break; case AttributeType::CharFontName: - // FALLTHROUGH intended case AttributeType::CharHeight: - // FALLTHROUGH intended case AttributeType::CharPosture: - // FALLTHROUGH intended case AttributeType::CharUnderline: - // FALLTHROUGH intended case AttributeType::CharWeight: - // FALLTHROUGH intended case AttributeType::FillStyle: - // FALLTHROUGH intended case AttributeType::Height: - // FALLTHROUGH intended case AttributeType::LineStyle: - // FALLTHROUGH intended case AttributeType::Opacity: - // FALLTHROUGH intended case AttributeType::Rotate: - // FALLTHROUGH intended case AttributeType::SkewX: - // FALLTHROUGH intended case AttributeType::SkewY: - // FALLTHROUGH intended case AttributeType::Visibility: - // FALLTHROUGH intended case AttributeType::Width: - // FALLTHROUGH intended case AttributeType::PosX: - // FALLTHROUGH intended case AttributeType::PosY: ENSURE_OR_THROW( false, "AnimationFactory::createColorPropertyAnimation(): Attribute type mismatch" ); @@ -1196,50 +1135,30 @@ namespace slideshow switch( mapAttributeName( rAttrName ) ) { default: - // FALLTHROUGH intended case AttributeType::Invalid: ENSURE_OR_THROW( false, "AnimationFactory::createStringPropertyAnimation(): Unknown attribute" ); break; case AttributeType::CharColor: - // FALLTHROUGH intended case AttributeType::CharHeight: - // FALLTHROUGH intended case AttributeType::CharUnderline: - // FALLTHROUGH intended case AttributeType::Color: - // FALLTHROUGH intended case AttributeType::DimColor: - // FALLTHROUGH intended case AttributeType::FillColor: - // FALLTHROUGH intended case AttributeType::Height: - // FALLTHROUGH intended case AttributeType::LineColor: - // FALLTHROUGH intended case AttributeType::Opacity: - // FALLTHROUGH intended case AttributeType::Rotate: - // FALLTHROUGH intended case AttributeType::SkewX: - // FALLTHROUGH intended case AttributeType::SkewY: - // FALLTHROUGH intended case AttributeType::Visibility: - // FALLTHROUGH intended case AttributeType::Width: - // FALLTHROUGH intended case AttributeType::PosX: - // FALLTHROUGH intended case AttributeType::PosY: - // FALLTHROUGH intended case AttributeType::CharPosture: - // FALLTHROUGH intended case AttributeType::CharWeight: - // FALLTHROUGH intended case AttributeType::FillStyle: - // FALLTHROUGH intended case AttributeType::LineStyle: ENSURE_OR_THROW( false, "AnimationFactory::createStringPropertyAnimation(): Attribute type mismatch" ); @@ -1268,50 +1187,30 @@ namespace slideshow switch( mapAttributeName( rAttrName ) ) { default: - // FALLTHROUGH intended case AttributeType::Invalid: ENSURE_OR_THROW( false, "AnimationFactory::createBoolPropertyAnimation(): Unknown attribute" ); break; case AttributeType::CharColor: - // FALLTHROUGH intended case AttributeType::CharFontName: - // FALLTHROUGH intended case AttributeType::CharHeight: - // FALLTHROUGH intended case AttributeType::CharPosture: - // FALLTHROUGH intended case AttributeType::CharWeight: - // FALLTHROUGH intended case AttributeType::Color: - // FALLTHROUGH intended case AttributeType::DimColor: - // FALLTHROUGH intended case AttributeType::FillColor: - // FALLTHROUGH intended case AttributeType::FillStyle: - // FALLTHROUGH intended case AttributeType::Height: - // FALLTHROUGH intended case AttributeType::LineColor: - // FALLTHROUGH intended case AttributeType::LineStyle: - // FALLTHROUGH intended case AttributeType::Opacity: - // FALLTHROUGH intended case AttributeType::Rotate: - // FALLTHROUGH intended case AttributeType::SkewX: - // FALLTHROUGH intended case AttributeType::SkewY: - // FALLTHROUGH intended case AttributeType::Width: - // FALLTHROUGH intended case AttributeType::PosX: - // FALLTHROUGH intended case AttributeType::PosY: - // FALLTHROUGH intended case AttributeType::CharUnderline: ENSURE_OR_THROW( false, "AnimationFactory::createBoolPropertyAnimation(): Attribute type mismatch" ); diff --git a/slideshow/source/engine/animationnodes/animationtransformnode.cxx b/slideshow/source/engine/animationnodes/animationtransformnode.cxx index 394349f5b707..d40f9400bf7d 100644 --- a/slideshow/source/engine/animationnodes/animationtransformnode.cxx +++ b/slideshow/source/engine/animationnodes/animationtransformnode.cxx @@ -51,7 +51,6 @@ AnimationActivitySharedPtr AnimationTransformNode::createActivity() const "Unknown transform type" ); case animations::AnimationTransformType::TRANSLATE: - // FALLTHROUGH intended case animations::AnimationTransformType::SCALE: return ActivitiesFactory::createAnimateActivity( aParms, diff --git a/slideshow/source/engine/slide/targetpropertiescreator.cxx b/slideshow/source/engine/slide/targetpropertiescreator.cxx index ac10b14d3b3e..29c28596e132 100644 --- a/slideshow/source/engine/slide/targetpropertiescreator.cxx +++ b/slideshow/source/engine/slide/targetpropertiescreator.cxx @@ -188,19 +188,12 @@ namespace internal break; case animations::AnimationNodeType::CUSTOM: - // FALLTHROUGH intended case animations::AnimationNodeType::ANIMATE: - // FALLTHROUGH intended case animations::AnimationNodeType::ANIMATEMOTION: - // FALLTHROUGH intended case animations::AnimationNodeType::ANIMATECOLOR: - // FALLTHROUGH intended case animations::AnimationNodeType::ANIMATETRANSFORM: - // FALLTHROUGH intended case animations::AnimationNodeType::TRANSITIONFILTER: - // FALLTHROUGH intended case animations::AnimationNodeType::AUDIO: - // FALLTHROUGH intended /*default: // ignore this node, no valuable content for now. break;*/ diff --git a/slideshow/source/engine/transitions/slidetransitionfactory.cxx b/slideshow/source/engine/transitions/slidetransitionfactory.cxx index db39e543b4a1..0492ce0761bd 100644 --- a/slideshow/source/engine/transitions/slidetransitionfactory.cxx +++ b/slideshow/source/engine/transitions/slidetransitionfactory.cxx @@ -1063,9 +1063,7 @@ NumberAnimationSharedPtr TransitionFactory::createSlideTransition( // TODO(F1): Implement toColor/fromColor fades case animations::TransitionSubType::FADETOCOLOR: - // FALLTHROUGH intended case animations::TransitionSubType::FADEFROMCOLOR: - // FALLTHROUGH intended case animations::TransitionSubType::FADEOVERCOLOR: if (pLeavingSlide) { // only generate, if fade diff --git a/vcl/win/window/salframe.cxx b/vcl/win/window/salframe.cxx index 50f9940ae2e9..99f86049c71e 100644 --- a/vcl/win/window/salframe.cxx +++ b/vcl/win/window/salframe.cxx @@ -5512,7 +5512,6 @@ static LRESULT CALLBACK SalFrameWndProc( HWND hWnd, UINT nMsg, WPARAM wParam, LP break; case WM_MOUSEWHEEL: - // FALLTHROUGH intended case WM_MOUSEHWHEEL: // protect against recursion, in case the message is returned // by IE or the external window -- cgit