From 62a9df7473f4213d6ac63faa0a7c0555212bfdee Mon Sep 17 00:00:00 2001 From: Miklos Vajna Date: Thu, 30 May 2019 21:20:25 +0200 Subject: find-unneded-includes: avoid replacing includes with forward-declarations Verified that e.g. writerfilter/source/dmapper/DomainMapper.cxx used to trigger advices to replace includes with forward-declarations, and now that's gone. See https://gerrit.libreoffice.org/#/c/72972/ for motivation, there are cases where a forward-declaration depends on the version of the external, while the include does not, so such changes have to be done with more care. Change-Id: I86d396ac743b3fc425868ffda26c0c9e85a00d0e Reviewed-on: https://gerrit.libreoffice.org/73221 Tested-by: Jenkins Reviewed-by: Miklos Vajna --- bin/find-unneeded-includes | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/find-unneeded-includes b/bin/find-unneeded-includes index aaa2b251434b..35784c0083e8 100755 --- a/bin/find-unneeded-includes +++ b/bin/find-unneeded-includes @@ -276,7 +276,7 @@ def tidy(compileCommands, paths): if assume: args = args.replace(assumeAbs, "-x c++ " + pathAbs) - invocation = "include-what-you-use " + args + invocation = "include-what-you-use -Xiwyu --no_fwd_decls " + args task_queue.put((invocation, moduleRules)) task_queue.join() -- cgit