From 6bc3539336a947553f51c3537284e39d4cff04bd Mon Sep 17 00:00:00 2001 From: Noel Date: Mon, 1 Mar 2021 13:37:10 +0200 Subject: loplugin:refcounting in chart2 Change-Id: I7f49a25fccf853b6e61c37f35c116888163153f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111746 Tested-by: Jenkins Reviewed-by: Noel Grandin --- chart2/source/controller/accessibility/AccessibleBase.cxx | 2 +- chart2/source/controller/accessibility/ChartElementFactory.cxx | 3 ++- chart2/source/controller/accessibility/ChartElementFactory.hxx | 4 +++- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/chart2/source/controller/accessibility/AccessibleBase.cxx b/chart2/source/controller/accessibility/AccessibleBase.cxx index 9e05f896b422..e5ca33bff4be 100644 --- a/chart2/source/controller/accessibility/AccessibleBase.cxx +++ b/chart2/source/controller/accessibility/AccessibleBase.cxx @@ -237,7 +237,7 @@ bool AccessibleBase::ImplUpdateChildren() aAccInfo.m_aOID = childToAdd; if ( childToAdd.isAutoGeneratedObject() ) { - AddChild( ChartElementFactory::CreateChartElement( aAccInfo ) ); + AddChild( ChartElementFactory::CreateChartElement( aAccInfo ).get() ); } else if ( childToAdd.isAdditionalShape() ) { diff --git a/chart2/source/controller/accessibility/ChartElementFactory.cxx b/chart2/source/controller/accessibility/ChartElementFactory.cxx index cd6c4eed340d..a173ac0f4b18 100644 --- a/chart2/source/controller/accessibility/ChartElementFactory.cxx +++ b/chart2/source/controller/accessibility/ChartElementFactory.cxx @@ -23,7 +23,8 @@ namespace chart { -AccessibleBase* ChartElementFactory::CreateChartElement(const AccessibleElementInfo& rAccInfo) +rtl::Reference +ChartElementFactory::CreateChartElement(const AccessibleElementInfo& rAccInfo) { ObjectIdentifier aOID(rAccInfo.m_aOID); ObjectType eType(aOID.getObjectType()); diff --git a/chart2/source/controller/accessibility/ChartElementFactory.hxx b/chart2/source/controller/accessibility/ChartElementFactory.hxx index 0177809c40cf..08ae64598bc7 100644 --- a/chart2/source/controller/accessibility/ChartElementFactory.hxx +++ b/chart2/source/controller/accessibility/ChartElementFactory.hxx @@ -18,6 +18,8 @@ */ #pragma once +#include + namespace chart { class AccessibleBase; @@ -29,7 +31,7 @@ public: /** @return a newly created object (using the new operator) that corresponds to the given unique id */ - static AccessibleBase* CreateChartElement(const AccessibleElementInfo& rAccInfo); + static rtl::Reference CreateChartElement(const AccessibleElementInfo& rAccInfo); }; } // namespace chart -- cgit