From 836e504c859a5b67f7ab7ba842785951d41058cd Mon Sep 17 00:00:00 2001 From: Eike Rathke Date: Wed, 2 Jul 2014 22:24:52 +0200 Subject: resolved fdo#80166 check input against date acceptance pattern plausibility ... to prevent confusion of #.### input with D.M that then later is discarded as invalid date input instead of accepted as valid numeric input. Change-Id: I178e28b7ef3b26d04eecc73e5e5c61ee41f89e32 --- svl/source/numbers/zforfind.cxx | 31 ++++++++++++++++++++++++++++++- 1 file changed, 30 insertions(+), 1 deletion(-) diff --git a/svl/source/numbers/zforfind.cxx b/svl/source/numbers/zforfind.cxx index d63fd56a72a5..c2946c3776fb 100644 --- a/svl/source/numbers/zforfind.cxx +++ b/svl/source/numbers/zforfind.cxx @@ -1174,6 +1174,8 @@ bool ImpSvNumberInputScan::IsAcceptedDatePattern( sal_uInt16 nStartPatternAt ) } nDatePatternStart = nStartPatternAt; // remember start particle + const sal_Int32 nMonthsInYear = pFormatter->GetCalendar()->getNumberOfMonthsInYear(); + for (sal_Int32 nPattern=0; nPattern < sDateAcceptancePatterns.getLength(); ++nPattern) { sal_uInt16 nNext = nDatePatternStart; @@ -1183,12 +1185,39 @@ bool ImpSvNumberInputScan::IsAcceptedDatePattern( sal_uInt16 nStartPatternAt ) sal_Int32 nPat = 0; for ( ; nPat < rPat.getLength() && bOk && nNext < nAnzStrings; ++nPat, ++nNext) { - switch (rPat[nPat]) + const sal_Unicode c = rPat[nPat]; + switch (c) { case 'Y': case 'M': case 'D': bOk = IsNum[nNext]; + if (bOk && (c == 'M' || c == 'D')) + { + // Check the D and M cases for plausibility. This also + // prevents recognition of date instead of number with a + // numeric group input if date separator is identical to + // group separator, for example with D.M as a pattern and + // #.### as a group. + sal_Int32 nMaxLen, nMaxVal; + switch (c) + { + case 'M': + nMaxLen = 2; + nMaxVal = nMonthsInYear; + break; + case 'D': + nMaxLen = 2; + nMaxVal = 31; + break; + } + bOk = (sStrArray[nNext].getLength() <= nMaxLen); + if (bOk) + { + sal_Int32 nNum = sStrArray[nNext].toInt32(); + bOk = (1 <= nNum && nNum <= nMaxVal); + } + } if (bOk) ++nDatePatternNumbers; break; -- cgit