From b5876bfcb69a65c87d602bae687b3c0634c0a1e7 Mon Sep 17 00:00:00 2001 From: Markus Mohrhard Date: Wed, 15 Jun 2016 20:15:20 +0200 Subject: passing a NULL pointer to fileno is not allowed See crash reports at http://crashreport.libreoffice.org/stats/signature/do_msvcr_magic+0x7 and documentation at https://msdn.microsoft.com/en-us/library/zs6wbdhx.aspx Change-Id: Ia9166d3b9fa10b87585821504e39cdfecbd22eda Reviewed-on: https://gerrit.libreoffice.org/26317 Reviewed-by: Michael Stahl Tested-by: Markus Mohrhard --- jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx | 3 +++ 1 file changed, 3 insertions(+) diff --git a/jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx b/jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx index fad3c0a9309e..43ddc827fefa 100644 --- a/jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx +++ b/jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx @@ -548,6 +548,9 @@ static void do_msvcr_magic(rtl_uString *jvm_dll) FILE *f = _wfopen(reinterpret_cast(Module->buffer), L"rb"); + if (!f) + return; + if (fstat(fileno(f), &st) == -1) { fclose(f); -- cgit