From bdacf96e3a52c30675c6cc0cbe037870cbeb4dda Mon Sep 17 00:00:00 2001 From: Stephan Bergmann Date: Tue, 10 May 2016 17:08:02 +0200 Subject: Add SAL_FALLTHROUGH, where apparently appropriate Change-Id: Id6e230d026184ab243e994a17515f2e5539d3646 --- basic/source/sbx/sbxbool.cxx | 1 + basic/source/sbx/sbxbyte.cxx | 1 + basic/source/sbx/sbxchar.cxx | 1 + basic/source/sbx/sbxdate.cxx | 1 + basic/source/sbx/sbxdbl.cxx | 1 + basic/source/sbx/sbxdec.cxx | 1 + basic/source/sbx/sbxint.cxx | 3 +++ basic/source/sbx/sbxlng.cxx | 1 + basic/source/sbx/sbxsng.cxx | 1 + basic/source/sbx/sbxstr.cxx | 1 + basic/source/sbx/sbxuint.cxx | 1 + basic/source/sbx/sbxulng.cxx | 1 + 12 files changed, 14 insertions(+) diff --git a/basic/source/sbx/sbxbool.cxx b/basic/source/sbx/sbxbool.cxx index 563c9f47070b..8e7e9ccad9fe 100644 --- a/basic/source/sbx/sbxbool.cxx +++ b/basic/source/sbx/sbxbool.cxx @@ -29,6 +29,7 @@ enum SbxBOOL ImpGetBool( const SbxValues* p ) { case SbxNULL: SbxBase::SetError( ERRCODE_SBX_CONVERSION ); + SAL_FALLTHROUGH; case SbxEMPTY: nRes = SbxFALSE; break; case SbxCHAR: diff --git a/basic/source/sbx/sbxbyte.cxx b/basic/source/sbx/sbxbyte.cxx index adaf634c25e8..5527a56f0e5b 100644 --- a/basic/source/sbx/sbxbyte.cxx +++ b/basic/source/sbx/sbxbyte.cxx @@ -30,6 +30,7 @@ start: { case SbxNULL: SbxBase::SetError( ERRCODE_SBX_CONVERSION ); + SAL_FALLTHROUGH; case SbxEMPTY: nRes = 0; break; case SbxCHAR: diff --git a/basic/source/sbx/sbxchar.cxx b/basic/source/sbx/sbxchar.cxx index 52bd101178fb..d03bcb9a9ff8 100644 --- a/basic/source/sbx/sbxchar.cxx +++ b/basic/source/sbx/sbxchar.cxx @@ -30,6 +30,7 @@ start: { case SbxNULL: SbxBase::SetError( ERRCODE_SBX_CONVERSION ); + SAL_FALLTHROUGH; case SbxEMPTY: nRes = 0; break; case SbxCHAR: diff --git a/basic/source/sbx/sbxdate.cxx b/basic/source/sbx/sbxdate.cxx index b678f220c2e4..4ed7ed034ca5 100644 --- a/basic/source/sbx/sbxdate.cxx +++ b/basic/source/sbx/sbxdate.cxx @@ -39,6 +39,7 @@ double ImpGetDate( const SbxValues* p ) { case SbxNULL: SbxBase::SetError( ERRCODE_SBX_CONVERSION ); + SAL_FALLTHROUGH; case SbxEMPTY: nRes = 0; break; diff --git a/basic/source/sbx/sbxdbl.cxx b/basic/source/sbx/sbxdbl.cxx index c0997d03dc2b..cfe964097ad7 100644 --- a/basic/source/sbx/sbxdbl.cxx +++ b/basic/source/sbx/sbxdbl.cxx @@ -31,6 +31,7 @@ double ImpGetDouble( const SbxValues* p ) { case SbxNULL: SbxBase::SetError( ERRCODE_SBX_CONVERSION ); + SAL_FALLTHROUGH; case SbxEMPTY: nRes = 0; break; case SbxCHAR: diff --git a/basic/source/sbx/sbxdec.cxx b/basic/source/sbx/sbxdec.cxx index b073ea12dc2d..22d7ba29b5e0 100644 --- a/basic/source/sbx/sbxdec.cxx +++ b/basic/source/sbx/sbxdec.cxx @@ -423,6 +423,7 @@ start: { case SbxNULL: SbxBase::SetError( ERRCODE_SBX_CONVERSION ); + SAL_FALLTHROUGH; case SbxEMPTY: pnDecRes->setShort( 0 ); break; case SbxCHAR: diff --git a/basic/source/sbx/sbxint.cxx b/basic/source/sbx/sbxint.cxx index 60eccdc0559f..c2d6fbe3d3eb 100644 --- a/basic/source/sbx/sbxint.cxx +++ b/basic/source/sbx/sbxint.cxx @@ -35,6 +35,7 @@ start: { case SbxNULL: SbxBase::SetError( ERRCODE_SBX_CONVERSION ); + SAL_FALLTHROUGH; case SbxEMPTY: nRes = 0; break; case SbxCHAR: @@ -390,6 +391,7 @@ start: { case SbxNULL: SbxBase::SetError( ERRCODE_SBX_CONVERSION ); + SAL_FALLTHROUGH; case SbxEMPTY: nRes = 0; break; case SbxCHAR: @@ -649,6 +651,7 @@ start: { case SbxNULL: SbxBase::SetError( ERRCODE_SBX_CONVERSION ); + SAL_FALLTHROUGH; case SbxEMPTY: nRes = 0; break; case SbxCHAR: diff --git a/basic/source/sbx/sbxlng.cxx b/basic/source/sbx/sbxlng.cxx index 94c6f43b7360..b173e8cc3d84 100644 --- a/basic/source/sbx/sbxlng.cxx +++ b/basic/source/sbx/sbxlng.cxx @@ -30,6 +30,7 @@ start: { case SbxNULL: SbxBase::SetError( ERRCODE_SBX_CONVERSION ); + SAL_FALLTHROUGH; case SbxEMPTY: nRes = 0; break; case SbxCHAR: diff --git a/basic/source/sbx/sbxsng.cxx b/basic/source/sbx/sbxsng.cxx index 723d1f2335b4..74402c593ebe 100644 --- a/basic/source/sbx/sbxsng.cxx +++ b/basic/source/sbx/sbxsng.cxx @@ -30,6 +30,7 @@ start: { case SbxNULL: SbxBase::SetError( ERRCODE_SBX_CONVERSION ); + SAL_FALLTHROUGH; case SbxEMPTY: nRes = 0; break; case SbxCHAR: diff --git a/basic/source/sbx/sbxstr.cxx b/basic/source/sbx/sbxstr.cxx index 1bdc6fa03764..404036d6b5bd 100644 --- a/basic/source/sbx/sbxstr.cxx +++ b/basic/source/sbx/sbxstr.cxx @@ -40,6 +40,7 @@ OUString ImpGetString( const SbxValues* p ) { case SbxNULL: SbxBase::SetError( ERRCODE_SBX_CONVERSION ); + SAL_FALLTHROUGH; case SbxEMPTY: break; case SbxCHAR: diff --git a/basic/source/sbx/sbxuint.cxx b/basic/source/sbx/sbxuint.cxx index b689c9ff06a6..89cf8bba6a68 100644 --- a/basic/source/sbx/sbxuint.cxx +++ b/basic/source/sbx/sbxuint.cxx @@ -30,6 +30,7 @@ start: { case SbxNULL: SbxBase::SetError( ERRCODE_SBX_CONVERSION ); + SAL_FALLTHROUGH; case SbxEMPTY: nRes = 0; break; case SbxCHAR: diff --git a/basic/source/sbx/sbxulng.cxx b/basic/source/sbx/sbxulng.cxx index 44be56ece975..dd79eeac8be7 100644 --- a/basic/source/sbx/sbxulng.cxx +++ b/basic/source/sbx/sbxulng.cxx @@ -30,6 +30,7 @@ start: { case SbxNULL: SbxBase::SetError( ERRCODE_SBX_CONVERSION ); + SAL_FALLTHROUGH; case SbxEMPTY: nRes = 0; break; case SbxCHAR: -- cgit