From c6ef03093eb76274851744ecf463a373a814a47e Mon Sep 17 00:00:00 2001 From: Stephan Bergmann Date: Thu, 7 Jul 2016 15:58:15 +0200 Subject: loplugin:passstuffbyref also for {css::uno,rtl}::Reference Change-Id: I2707d16e6dd7bc5617094963933fced147a496e8 --- sc/inc/nameuno.hxx | 6 ++-- sc/inc/xmlwrap.hxx | 2 +- sc/qa/extras/new_cond_format.cxx | 22 ++++++------- sc/qa/unit/helper/xpath.cxx | 4 +-- sc/qa/unit/helper/xpath.hxx | 4 +-- sc/source/core/inc/addinlis.hxx | 2 +- sc/source/core/tool/addinlis.cxx | 2 +- sc/source/filter/chart/chart_imp.cxx | 2 +- sc/source/filter/excel/xechart.cxx | 54 +++++++++++++++--------------- sc/source/filter/excel/xeescher.cxx | 10 +++--- sc/source/filter/excel/xichart.cxx | 26 +++++++-------- sc/source/filter/excel/xlchart.cxx | 2 +- sc/source/filter/excel/xlescher.cxx | 2 +- sc/source/filter/ftools/fapihelper.cxx | 2 +- sc/source/filter/inc/fapihelper.hxx | 2 +- sc/source/filter/inc/xcl97esc.hxx | 6 ++-- sc/source/filter/inc/xechart.hxx | 60 +++++++++++++++++----------------- sc/source/filter/inc/xeescher.hxx | 10 +++--- sc/source/filter/inc/xichart.hxx | 24 +++++++------- sc/source/filter/inc/xlchart.hxx | 2 +- sc/source/filter/inc/xlescher.hxx | 2 +- sc/source/filter/xcl97/xcl97esc.cxx | 6 ++-- sc/source/filter/xml/xmlexprt.cxx | 6 ++-- sc/source/filter/xml/xmlexprt.hxx | 2 +- sc/source/ui/inc/condformatuno.hxx | 18 +++++----- sc/source/ui/inc/spelleng.hxx | 2 +- sc/source/ui/unoobj/condformatuno.cxx | 26 +++++++-------- sc/source/ui/unoobj/nameuno.cxx | 4 +-- sc/source/ui/vba/vbadialog.hxx | 2 +- sc/source/ui/vba/vbaoleobject.cxx | 2 +- sc/source/ui/vba/vbaoleobject.hxx | 2 +- sc/source/ui/vba/vbaoutline.hxx | 2 +- sc/source/ui/vba/vbaworkbook.cxx | 2 +- sc/source/ui/vba/vbaworkbook.hxx | 2 +- sc/source/ui/vba/vbaworksheet.cxx | 2 +- sc/source/ui/vba/vbaworksheet.hxx | 2 +- sc/source/ui/view/drawvie4.cxx | 2 +- sc/source/ui/view/spelleng.cxx | 2 +- 38 files changed, 165 insertions(+), 165 deletions(-) diff --git a/sc/inc/nameuno.hxx b/sc/inc/nameuno.hxx index 1e1fceb21a88..ecdedee8adfc 100644 --- a/sc/inc/nameuno.hxx +++ b/sc/inc/nameuno.hxx @@ -68,8 +68,8 @@ friend class ScVbaName; SCTAB GetTab_Impl(); public: - ScNamedRangeObj( rtl::Reference< ScNamedRangesObj > xParent, ScDocShell* pDocSh, const OUString& rNm, - css::uno::Reference< css::container::XNamed > xSheet = css::uno::Reference< css::container::XNamed > ()); + ScNamedRangeObj( rtl::Reference< ScNamedRangesObj > const & xParent, ScDocShell* pDocSh, const OUString& rNm, + css::uno::Reference< css::container::XNamed > const & xSheet = css::uno::Reference< css::container::XNamed > ()); virtual ~ScNamedRangeObj(); virtual void Notify( SfxBroadcaster& rBC, const SfxHint& rHint ) override; @@ -318,7 +318,7 @@ private: css::uno::Reference< css::container::XNamed > mxSheet; public: - ScLocalNamedRangesObj(ScDocShell* pDocSh, css::uno::Reference< css::container::XNamed > xNamed ); + ScLocalNamedRangesObj(ScDocShell* pDocSh, css::uno::Reference< css::container::XNamed > const & xNamed ); virtual ~ScLocalNamedRangesObj(); }; diff --git a/sc/inc/xmlwrap.hxx b/sc/inc/xmlwrap.hxx index d0e88122fb22..7179bd843870 100644 --- a/sc/inc/xmlwrap.hxx +++ b/sc/inc/xmlwrap.hxx @@ -91,7 +91,7 @@ public: class ScXMLChartExportWrapper { public: - ScXMLChartExportWrapper( css::uno::Reference< css::frame::XModel > xModel, SfxMedium& rMed ); + ScXMLChartExportWrapper( css::uno::Reference< css::frame::XModel > const & xModel, SfxMedium& rMed ); bool Export(); private: diff --git a/sc/qa/extras/new_cond_format.cxx b/sc/qa/extras/new_cond_format.cxx index 0ac9888d539b..bd5bdeecc40e 100644 --- a/sc/qa/extras/new_cond_format.cxx +++ b/sc/qa/extras/new_cond_format.cxx @@ -101,7 +101,7 @@ void ScConditionalFormatTest::testRequestCondFormatListFromSheet() namespace { -uno::Reference getConditionalFormatList(uno::Reference xInterface) +uno::Reference getConditionalFormatList(uno::Reference const & xInterface) { uno::Reference xSheet(xInterface, uno::UNO_QUERY_THROW); uno::Reference xProps(xSheet, uno::UNO_QUERY_THROW); @@ -186,7 +186,7 @@ void ScConditionalFormatTest::testCondFormatXIndex() namespace { -void testAxisPosition(uno::Reference xPropSet, sal_Int32 ePos) +void testAxisPosition(uno::Reference const & xPropSet, sal_Int32 ePos) { sal_Int32 eAxisPos; uno::Any aAny = xPropSet->getPropertyValue("AxisPosition"); @@ -194,7 +194,7 @@ void testAxisPosition(uno::Reference xPropSet, sal_Int32 eP CPPUNIT_ASSERT_EQUAL(ePos, eAxisPos); } -void testShowValue(uno::Reference xPropSet, bool bShowVal) +void testShowValue(uno::Reference const & xPropSet, bool bShowVal) { bool bShow; uno::Any aAny = xPropSet->getPropertyValue("ShowValue"); @@ -202,7 +202,7 @@ void testShowValue(uno::Reference xPropSet, bool bShowVal) CPPUNIT_ASSERT_EQUAL(bShowVal, bShow); } -void testUseGradient(uno::Reference xPropSet, bool bUseGradient) +void testUseGradient(uno::Reference const & xPropSet, bool bUseGradient) { bool bGradient; uno::Any aAny = xPropSet->getPropertyValue("UseGradient"); @@ -210,7 +210,7 @@ void testUseGradient(uno::Reference xPropSet, bool bUseGrad CPPUNIT_ASSERT_EQUAL(bUseGradient, bGradient); } -void testPositiveColor(uno::Reference xPropSet, Color aColor) +void testPositiveColor(uno::Reference const & xPropSet, Color aColor) { sal_Int32 nColor = 0; uno::Any aAny = xPropSet->getPropertyValue("Color"); @@ -218,7 +218,7 @@ void testPositiveColor(uno::Reference xPropSet, Color aColo CPPUNIT_ASSERT_EQUAL(aColor.GetColor(), sal_uInt32(nColor)); } -void testNegativeColor(uno::Reference xPropSet, Color aColor) +void testNegativeColor(uno::Reference const & xPropSet, Color aColor) { sal_Int32 nColor = 0; uno::Any aAny = xPropSet->getPropertyValue("NegativeColor"); @@ -226,7 +226,7 @@ void testNegativeColor(uno::Reference xPropSet, Color aColo CPPUNIT_ASSERT_EQUAL(aColor.GetColor(), sal_uInt32(nColor)); } -void testAxisColor(uno::Reference xPropSet, Color aColor) +void testAxisColor(uno::Reference const & xPropSet, Color aColor) { sal_Int32 nColor = 0; uno::Any aAny = xPropSet->getPropertyValue("AxisColor"); @@ -234,7 +234,7 @@ void testAxisColor(uno::Reference xPropSet, Color aColor) CPPUNIT_ASSERT_EQUAL(aColor.GetColor(), sal_uInt32(nColor)); } -void testDataBarEntryValue(uno::Reference xEntry, +void testDataBarEntryValue(uno::Reference const & xEntry, const OUString& rExpectedValue, sal_Int32 nType) { switch (nType) @@ -253,7 +253,7 @@ void testDataBarEntryValue(uno::Reference xEntry, } } -void testDataBarEntries(uno::Reference xPropSet, +void testDataBarEntries(uno::Reference const & xPropSet, const OUString& rExpectedMinString, sal_Int32 nExpectedMinType, const OUString& rExpectedMaxString, sal_Int32 nExpectedMaxType) { @@ -366,7 +366,7 @@ void ScConditionalFormatTest::testDataBarProperties() namespace { -void testColorScaleEntry(uno::Reference xEntry, +void testColorScaleEntry(uno::Reference const & xEntry, sal_Int32 nType, const OUString& rString, sal_uInt32 nColor) { CPPUNIT_ASSERT_EQUAL(nType, xEntry->getType()); @@ -386,7 +386,7 @@ void testColorScaleEntry(uno::Reference xEntry, } } -void testColorScaleEntries(uno::Reference xPropSet, sal_Int32 nEntries, +void testColorScaleEntries(uno::Reference const & xPropSet, sal_Int32 nEntries, sal_Int32 nMinType, const OUString& rMinString, sal_uInt32 nMinColor, sal_Int32 nMediumType, const OUString& rMediumString, sal_uInt32 nMediumColor, sal_Int32 nMaxType, const OUString& rMaxString, sal_uInt32 nMaxColor) diff --git a/sc/qa/unit/helper/xpath.cxx b/sc/qa/unit/helper/xpath.cxx index 8056d4d4aac0..2117b749b326 100644 --- a/sc/qa/unit/helper/xpath.cxx +++ b/sc/qa/unit/helper/xpath.cxx @@ -18,14 +18,14 @@ #include -xmlDocPtr XPathHelper::parseExport(ScDocShell& rShell, uno::Reference xSFactory, const OUString& rFile, sal_Int32 nFormat) +xmlDocPtr XPathHelper::parseExport(ScDocShell& rShell, uno::Reference const & xSFactory, const OUString& rFile, sal_Int32 nFormat) { std::shared_ptr pTempFile = ScBootstrapFixture::exportTo(&rShell, nFormat); return parseExport(pTempFile, xSFactory, rFile); } -xmlDocPtr XPathHelper::parseExport(std::shared_ptr pTempFile, uno::Reference xSFactory, const OUString& rFile) +xmlDocPtr XPathHelper::parseExport(std::shared_ptr pTempFile, uno::Reference const & xSFactory, const OUString& rFile) { // Read the XML stream we're interested in. uno::Reference xNameAccess = packages::zip::ZipFileAccess::createWithURL(comphelper::getComponentContext(xSFactory), pTempFile->GetURL()); diff --git a/sc/qa/unit/helper/xpath.hxx b/sc/qa/unit/helper/xpath.hxx index f53f9276f6a8..91a81e1253c3 100644 --- a/sc/qa/unit/helper/xpath.hxx +++ b/sc/qa/unit/helper/xpath.hxx @@ -44,7 +44,7 @@ namespace XPathHelper * test several files in the same exported xml file you need to export the file manually * and call the parseExport method that takes a TempFile */ - SCQAHELPER_DLLPUBLIC xmlDocPtr parseExport(ScDocShell& rShell, uno::Reference< lang::XMultiServiceFactory> xSFactory, + SCQAHELPER_DLLPUBLIC xmlDocPtr parseExport(ScDocShell& rShell, uno::Reference< lang::XMultiServiceFactory> const & xSFactory, const OUString& rFile, sal_Int32 nFormat); /** @@ -53,7 +53,7 @@ namespace XPathHelper * Should be used when the same exported file is used for testing different files in * the same zip file. */ - SCQAHELPER_DLLPUBLIC xmlDocPtr parseExport(std::shared_ptr pTempFile, uno::Reference< lang::XMultiServiceFactory> xSFactory, + SCQAHELPER_DLLPUBLIC xmlDocPtr parseExport(std::shared_ptr pTempFile, uno::Reference< lang::XMultiServiceFactory> const & xSFactory, const OUString& rFile); } diff --git a/sc/source/core/inc/addinlis.hxx b/sc/source/core/inc/addinlis.hxx index ef9f7ba8f7da..0cd32e9c5102 100644 --- a/sc/source/core/inc/addinlis.hxx +++ b/sc/source/core/inc/addinlis.hxx @@ -42,7 +42,7 @@ private: static ::std::list aAllListeners; // always allocated via CreateListener - ScAddInListener( css::uno::Reference xVR, + ScAddInListener( css::uno::Reference const & xVR, ScDocument* pD ); public: diff --git a/sc/source/core/tool/addinlis.cxx b/sc/source/core/tool/addinlis.cxx index 75b0d5ac3699..845b5567e4aa 100644 --- a/sc/source/core/tool/addinlis.cxx +++ b/sc/source/core/tool/addinlis.cxx @@ -46,7 +46,7 @@ ScAddInListener* ScAddInListener::CreateListener( return pNew; } -ScAddInListener::ScAddInListener( uno::Reference xVR, ScDocument* pDoc ) : +ScAddInListener::ScAddInListener( uno::Reference const & xVR, ScDocument* pDoc ) : xVolRes( xVR ) { pDocs = new ScAddInDocs(); diff --git a/sc/source/filter/chart/chart_imp.cxx b/sc/source/filter/chart/chart_imp.cxx index 8a61be61e586..72d2c980d4b4 100644 --- a/sc/source/filter/chart/chart_imp.cxx +++ b/sc/source/filter/chart/chart_imp.cxx @@ -16,7 +16,7 @@ using namespace com::sun::star; -ScXMLChartExportWrapper::ScXMLChartExportWrapper( css::uno::Reference< css::frame::XModel > xModel, SfxMedium& rMed ): +ScXMLChartExportWrapper::ScXMLChartExportWrapper( css::uno::Reference< css::frame::XModel > const & xModel, SfxMedium& rMed ): mxModel(xModel), mrMedium(rMed) { diff --git a/sc/source/filter/excel/xechart.cxx b/sc/source/filter/excel/xechart.cxx index 2b2c3a6e7214..d6eee66871c6 100644 --- a/sc/source/filter/excel/xechart.cxx +++ b/sc/source/filter/excel/xechart.cxx @@ -329,7 +329,7 @@ const XclChFormatInfo& XclExpChRoot::GetFormatInfo( XclChObjectType eObjType ) c return mxChData->mxFmtInfoProv->GetFormatInfo( eObjType ); } -void XclExpChRoot::InitConversion( css::uno::Reference< css::chart2::XChartDocument > xChartDoc, const Rectangle& rChartRect ) const +void XclExpChRoot::InitConversion( css::uno::Reference< css::chart2::XChartDocument > const & xChartDoc, const Rectangle& rChartRect ) const { mxChData->InitConversion( GetRoot(), xChartDoc, rChartRect ); } @@ -886,7 +886,7 @@ XclExpChSourceLink::XclExpChSourceLink( const XclExpChRoot& rRoot, sal_uInt8 nDe maData.mnLinkType = EXC_CHSRCLINK_DIRECTLY; } -sal_uInt16 XclExpChSourceLink::ConvertDataSequence( Reference< XDataSequence > xDataSeq, bool bSplitToColumns, sal_uInt16 nDefCount ) +sal_uInt16 XclExpChSourceLink::ConvertDataSequence( Reference< XDataSequence > const & xDataSeq, bool bSplitToColumns, sal_uInt16 nDefCount ) { mxLinkFmla.reset(); maData.mnLinkType = EXC_CHSRCLINK_DEFAULT; @@ -1176,7 +1176,7 @@ void XclExpChText::SetRotation( sal_uInt16 nRotation ) ::insert_value( maData.mnFlags, XclTools::GetXclOrientFromRot( nRotation ), 8, 3 ); } -void XclExpChText::ConvertTitle( Reference< XTitle > xTitle, sal_uInt16 nTarget, const OUString* pSubTitle ) +void XclExpChText::ConvertTitle( Reference< XTitle > const & xTitle, sal_uInt16 nTarget, const OUString* pSubTitle ) { switch( nTarget ) { @@ -1412,7 +1412,7 @@ void XclExpChText::WriteBody( XclExpStream& rStrm ) namespace { /** Creates and returns an Excel text object from the passed title. */ -XclExpChTextRef lclCreateTitle( const XclExpChRoot& rRoot, Reference< XTitled > xTitled, sal_uInt16 nTarget, +XclExpChTextRef lclCreateTitle( const XclExpChRoot& rRoot, Reference< XTitled > const & xTitled, sal_uInt16 nTarget, const OUString* pSubTitle = nullptr ) { Reference< XTitle > xTitle; @@ -1645,7 +1645,7 @@ XclExpChSerTrendLine::XclExpChSerTrendLine( const XclExpChRoot& rRoot ) : { } -bool XclExpChSerTrendLine::Convert( Reference< XRegressionCurve > xRegCurve, sal_uInt16 nSeriesIdx ) +bool XclExpChSerTrendLine::Convert( Reference< XRegressionCurve > const & xRegCurve, sal_uInt16 nSeriesIdx ) { if( !xRegCurve.is() ) return false; @@ -1812,7 +1812,7 @@ void XclExpChSerErrorBar::WriteBody( XclExpStream& rStrm ) namespace { /** Returns the property set of the specified data point. */ -ScfPropertySet lclGetPointPropSet( Reference< XDataSeries > xDataSeries, sal_Int32 nPointIdx ) +ScfPropertySet lclGetPointPropSet( Reference< XDataSeries > const & xDataSeries, sal_Int32 nPointIdx ) { ScfPropertySet aPropSet; try @@ -1843,7 +1843,7 @@ XclExpChSeries::XclExpChSeries( const XclExpChRoot& rRoot, sal_uInt16 nSeriesIdx } bool XclExpChSeries::ConvertDataSeries( - Reference< XDiagram > xDiagram, Reference< XDataSeries > xDataSeries, + Reference< XDiagram > const & xDiagram, Reference< XDataSeries > const & xDataSeries, const XclChExtTypeInfo& rTypeInfo, sal_uInt16 nGroupIdx, sal_uInt16 nFormatIdx ) { bool bOk = false; @@ -1963,7 +1963,7 @@ bool XclExpChSeries::ConvertDataSeries( return bOk; } -bool XclExpChSeries::ConvertStockSeries( css::uno::Reference< css::chart2::XDataSeries > xDataSeries, +bool XclExpChSeries::ConvertStockSeries( css::uno::Reference< css::chart2::XDataSeries > const & xDataSeries, const OUString& rValueRole, sal_uInt16 nGroupIdx, sal_uInt16 nFormatIdx, bool bCloseSymbol ) { bool bOk = false; @@ -2005,7 +2005,7 @@ bool XclExpChSeries::ConvertStockSeries( css::uno::Reference< css::chart2::XData return bOk; } -bool XclExpChSeries::ConvertTrendLine( const XclExpChSeries& rParent, Reference< XRegressionCurve > xRegCurve ) +bool XclExpChSeries::ConvertTrendLine( const XclExpChSeries& rParent, Reference< XRegressionCurve > const & xRegCurve ) { InitFromParent( rParent ); @@ -2039,7 +2039,7 @@ bool XclExpChSeries::ConvertErrorBar( const XclExpChSeries& rParent, const ScfPr return bOk; } -void XclExpChSeries::ConvertCategSequence( Reference< XLabeledDataSequence > xCategSeq ) +void XclExpChSeries::ConvertCategSequence( Reference< XLabeledDataSequence > const & xCategSeq ) { if( xCategSeq.is() ) maData.mnCategCount = mxCategLink->ConvertDataSequence( xCategSeq->getValues(), false ); @@ -2071,7 +2071,7 @@ void XclExpChSeries::InitFromParent( const XclExpChSeries& rParent ) maData.mnValueCount = rParent.maData.mnValueCount; } -void XclExpChSeries::CreateTrendLines( css::uno::Reference< css::chart2::XDataSeries > xDataSeries ) +void XclExpChSeries::CreateTrendLines( css::uno::Reference< css::chart2::XDataSeries > const & xDataSeries ) { Reference< XRegressionCurveContainer > xRegCurveCont( xDataSeries, UNO_QUERY ); if( xRegCurveCont.is() ) @@ -2127,7 +2127,7 @@ XclExpChType::XclExpChType( const XclExpChRoot& rRoot ) : { } -void XclExpChType::Convert( Reference< XDiagram > xDiagram, Reference< XChartType > xChartType, +void XclExpChType::Convert( Reference< XDiagram > const & xDiagram, Reference< XChartType > const & xChartType, sal_Int32 nApiAxesSetIdx, bool bSwappedAxesSet, bool bHasXLabels ) { if( xChartType.is() ) @@ -2406,7 +2406,7 @@ XclExpChTypeGroup::XclExpChTypeGroup( const XclExpChRoot& rRoot, sal_uInt16 nGro } void XclExpChTypeGroup::ConvertType( - Reference< XDiagram > xDiagram, Reference< XChartType > xChartType, + Reference< XDiagram > const & xDiagram, Reference< XChartType > const & xChartType, sal_Int32 nApiAxesSetIdx, bool b3dChart, bool bSwappedAxesSet, bool bHasXLabels ) { // chart type settings @@ -2431,7 +2431,7 @@ void XclExpChTypeGroup::ConvertType( } void XclExpChTypeGroup::ConvertSeries( - Reference< XDiagram > xDiagram, Reference< XChartType > xChartType, + Reference< XDiagram > const & xDiagram, Reference< XChartType > const & xChartType, sal_Int32 nGroupAxesSetIdx, bool bPercent, bool bConnectBars ) { Reference< XDataSeriesContainer > xSeriesCont( xChartType, UNO_QUERY ); @@ -2501,7 +2501,7 @@ void XclExpChTypeGroup::ConvertSeries( } } -void XclExpChTypeGroup::ConvertCategSequence( Reference< XLabeledDataSequence > xCategSeq ) +void XclExpChTypeGroup::ConvertCategSequence( Reference< XLabeledDataSequence > const & xCategSeq ) { for( size_t nIdx = 0, nSize = maSeries.GetSize(); nIdx < nSize; ++nIdx ) maSeries.GetRecord( nIdx )->ConvertCategSequence( xCategSeq ); @@ -2535,7 +2535,7 @@ sal_uInt16 XclExpChTypeGroup::GetFreeFormatIdx() const } void XclExpChTypeGroup::CreateDataSeries( - Reference< XDiagram > xDiagram, Reference< XDataSeries > xDataSeries ) + Reference< XDiagram > const & xDiagram, Reference< XDataSeries > const & xDataSeries ) { // let chart create series object with correct series index XclExpChSeriesRef xSeries = GetChartData().CreateSeries(); @@ -2549,7 +2549,7 @@ void XclExpChTypeGroup::CreateDataSeries( } void XclExpChTypeGroup::CreateAllStockSeries( - Reference< XChartType > xChartType, Reference< XDataSeries > xDataSeries ) + Reference< XChartType > const & xChartType, Reference< XDataSeries > const & xDataSeries ) { // create existing series objects bool bHasOpen = CreateStockSeries( xDataSeries, EXC_CHPROP_ROLE_OPENVALUES, false ); @@ -2586,7 +2586,7 @@ void XclExpChTypeGroup::CreateAllStockSeries( } } -bool XclExpChTypeGroup::CreateStockSeries( Reference< XDataSeries > xDataSeries, +bool XclExpChTypeGroup::CreateStockSeries( Reference< XDataSeries > const & xDataSeries, const OUString& rValueRole, bool bCloseSymbol ) { bool bOk = false; @@ -2889,7 +2889,7 @@ void XclExpChTick::WriteBody( XclExpStream& rStrm ) namespace { /** Returns an API axis object from the passed coordinate system. */ -Reference< XAxis > lclGetApiAxis( Reference< XCoordinateSystem > xCoordSystem, +Reference< XAxis > lclGetApiAxis( Reference< XCoordinateSystem > const & xCoordSystem, sal_Int32 nApiAxisDim, sal_Int32 nApiAxesSetIdx ) { Reference< XAxis > xAxis; @@ -2903,7 +2903,7 @@ Reference< XAxis > lclGetApiAxis( Reference< XCoordinateSystem > xCoordSystem, return xAxis; } -Reference< cssc::XAxis > lclGetApiChart1Axis( Reference< XChartDocument > xChartDoc, +Reference< cssc::XAxis > lclGetApiChart1Axis( Reference< XChartDocument > const & xChartDoc, sal_Int32 nApiAxisDim, sal_Int32 nApiAxesSetIdx ) { Reference< cssc::XAxis > xChart1Axis; @@ -2949,8 +2949,8 @@ void XclExpChAxis::SetRotation( sal_uInt16 nRotation ) mxTick->SetRotation( nRotation ); } -void XclExpChAxis::Convert( Reference< XAxis > xAxis, Reference< XAxis > xCrossingAxis, - Reference< cssc::XAxis > xChart1Axis, const XclChExtTypeInfo& rTypeInfo ) +void XclExpChAxis::Convert( Reference< XAxis > const & xAxis, Reference< XAxis > const & xCrossingAxis, + Reference< cssc::XAxis > const & xChart1Axis, const XclChExtTypeInfo& rTypeInfo ) { ScfPropertySet aAxisProp( xAxis ); bool bCategoryAxis = ((GetAxisType() == EXC_CHAXIS_X) && rTypeInfo.mbCategoryAxis) || (GetAxisType() == EXC_CHAXIS_Z); @@ -3023,7 +3023,7 @@ void XclExpChAxis::Convert( Reference< XAxis > xAxis, Reference< XAxis > xCrossi } } -void XclExpChAxis::ConvertWall( css::uno::Reference< css::chart2::XDiagram > xDiagram ) +void XclExpChAxis::ConvertWall( css::uno::Reference< css::chart2::XDiagram > const & xDiagram ) { if( xDiagram.is() ) switch( GetAxisType() ) { @@ -3080,7 +3080,7 @@ XclExpChAxesSet::XclExpChAxesSet( const XclExpChRoot& rRoot, sal_uInt16 nAxesSet maData.maRect.mnHeight = 2633; } -sal_uInt16 XclExpChAxesSet::Convert( Reference< XDiagram > xDiagram, sal_uInt16 nFirstGroupIdx ) +sal_uInt16 XclExpChAxesSet::Convert( Reference< XDiagram > const & xDiagram, sal_uInt16 nFirstGroupIdx ) { /* First unused chart type group index is passed to be able to continue counting of chart type groups for secondary axes set. */ @@ -3266,7 +3266,7 @@ XclExpChTypeGroupRef XclExpChAxesSet::GetLastTypeGroup() const void XclExpChAxesSet::ConvertAxis( XclExpChAxisRef& rxChAxis, sal_uInt16 nAxisType, XclExpChTextRef& rxChAxisTitle, sal_uInt16 nTitleTarget, - Reference< XCoordinateSystem > xCoordSystem, const XclChExtTypeInfo& rTypeInfo, + Reference< XCoordinateSystem > const & xCoordSystem, const XclChExtTypeInfo& rTypeInfo, sal_Int32 nCrossingAxisDim ) { // create and convert axis object @@ -3308,7 +3308,7 @@ static void lcl_getChartSubTitle(const Reference& xChartDoc, } XclExpChChart::XclExpChChart( const XclExpRoot& rRoot, - Reference< XChartDocument > xChartDoc, const Rectangle& rChartRect ) : + Reference< XChartDocument > const & xChartDoc, const Rectangle& rChartRect ) : XclExpChGroupBase( XclExpChRoot( rRoot, *this ), EXC_CHFRBLOCK_TYPE_CHART, EXC_ID_CHCHART, 16 ) { Size aPtSize = OutputDevice::LogicToLogic( rChartRect.GetSize(), MapMode( MAP_100TH_MM ), MapMode( MAP_POINT ) ); @@ -3468,7 +3468,7 @@ void XclExpChartDrawing::Save( XclExpStream& rStrm ) mxObjRecs->Save( rStrm ); } -XclExpChart::XclExpChart( const XclExpRoot& rRoot, Reference< XModel > xModel, const Rectangle& rChartRect ) : +XclExpChart::XclExpChart( const XclExpRoot& rRoot, Reference< XModel > const & xModel, const Rectangle& rChartRect ) : XclExpSubStream( EXC_BOF_CHART ), XclExpRoot( rRoot ) { diff --git a/sc/source/filter/excel/xeescher.cxx b/sc/source/filter/excel/xeescher.cxx index 99ad68eea835..8c538b939463 100644 --- a/sc/source/filter/excel/xeescher.cxx +++ b/sc/source/filter/excel/xeescher.cxx @@ -459,7 +459,7 @@ XclExpControlHelper::~XclExpControlHelper() { } -void XclExpControlHelper::ConvertSheetLinks( Reference< XShape > xShape ) +void XclExpControlHelper::ConvertSheetLinks( Reference< XShape > const & xShape ) { mxCellLink.reset(); mxSrcRange.reset(); @@ -531,7 +531,7 @@ void XclExpControlHelper::WriteFormulaSubRec( XclExpStream& rStrm, sal_uInt16 nS //delete for exporting OCX //#if EXC_EXP_OCX_CTRL -XclExpOcxControlObj::XclExpOcxControlObj( XclExpObjectManager& rObjMgr, Reference< XShape > xShape, +XclExpOcxControlObj::XclExpOcxControlObj( XclExpObjectManager& rObjMgr, Reference< XShape > const & xShape, const Rectangle* pChildAnchor, const OUString& rClassName, sal_uInt32 nStrmStart, sal_uInt32 nStrmSize ) : XclObj( rObjMgr, EXC_OBJTYPE_PICTURE, true ), XclExpControlHelper( rObjMgr.GetRoot() ), @@ -636,7 +636,7 @@ void XclExpOcxControlObj::WriteSubRecs( XclExpStream& rStrm ) //#else -XclExpTbxControlObj::XclExpTbxControlObj( XclExpObjectManager& rRoot, Reference< XShape > xShape , const Rectangle* pChildAnchor ) : +XclExpTbxControlObj::XclExpTbxControlObj( XclExpObjectManager& rRoot, Reference< XShape > const & xShape , const Rectangle* pChildAnchor ) : XclObj( rRoot, EXC_OBJTYPE_UNKNOWN, true ), XclMacroHelper( rRoot ), meEventType( EXC_TBX_EVENT_ACTION ), @@ -1065,7 +1065,7 @@ void XclExpTbxControlObj::WriteSbs( XclExpStream& rStrm ) //#endif -XclExpChartObj::XclExpChartObj( XclExpObjectManager& rObjMgr, Reference< XShape > xShape, const Rectangle* pChildAnchor ) : +XclExpChartObj::XclExpChartObj( XclExpObjectManager& rObjMgr, Reference< XShape > const & xShape, const Rectangle* pChildAnchor ) : XclObj( rObjMgr, EXC_OBJTYPE_CHART ), XclExpRoot( rObjMgr.GetRoot() ), mxShape( xShape ) { @@ -1371,7 +1371,7 @@ XclMacroHelper::SetMacroLink( const OUString& rMacroName ) return false; } -XclExpShapeObj::XclExpShapeObj( XclExpObjectManager& rRoot, css::uno::Reference< css::drawing::XShape > xShape, ScDocument* pDoc ) : +XclExpShapeObj::XclExpShapeObj( XclExpObjectManager& rRoot, css::uno::Reference< css::drawing::XShape > const & xShape, ScDocument* pDoc ) : XclObjAny( rRoot, xShape, pDoc ), XclMacroHelper( rRoot ) { diff --git a/sc/source/filter/excel/xichart.cxx b/sc/source/filter/excel/xichart.cxx index 09bd891da9c5..8b2f0150d96d 100644 --- a/sc/source/filter/excel/xichart.cxx +++ b/sc/source/filter/excel/xichart.cxx @@ -1973,7 +1973,7 @@ void XclImpChSeries::FinalizeDataFormats() namespace { /** Returns the property set of the specified data point. */ -ScfPropertySet lclGetPointPropSet( Reference< XDataSeries > xDataSeries, sal_uInt16 nPointIdx ) +ScfPropertySet lclGetPointPropSet( Reference< XDataSeries > const & xDataSeries, sal_uInt16 nPointIdx ) { ScfPropertySet aPropSet; try @@ -2143,7 +2143,7 @@ XclImpChDataFormatRef XclImpChSeries::CreateDataFormat( sal_uInt16 nPointIdx, sa return xDataFmt; } -void XclImpChSeries::ConvertTrendLines( Reference< XDataSeries > xDataSeries ) const +void XclImpChSeries::ConvertTrendLines( Reference< XDataSeries > const & xDataSeries ) const { Reference< XRegressionCurveContainer > xRegCurveCont( xDataSeries, UNO_QUERY ); if( xRegCurveCont.is() ) @@ -2358,7 +2358,7 @@ Reference< XCoordinateSystem > XclImpChType::CreateCoordSystem( bool b3dChart ) return xCoordSystem; } -Reference< XChartType > XclImpChType::CreateChartType( Reference< XDiagram > xDiagram, bool b3dChart ) const +Reference< XChartType > XclImpChType::CreateChartType( Reference< XDiagram > const & xDiagram, bool b3dChart ) const { OUString aService = OUString::createFromAscii( maTypeInfo.mpcServiceName ); Reference< XChartType > xChartType( ScfApiHelper::CreateInstance( aService ), UNO_QUERY ); @@ -2763,7 +2763,7 @@ Reference< XCoordinateSystem > XclImpChTypeGroup::CreateCoordSystem() const return maType.CreateCoordSystem( Is3dChart() ); } -Reference< XChartType > XclImpChTypeGroup::CreateChartType( Reference< XDiagram > xDiagram, sal_Int32 nApiAxesSetIdx ) const +Reference< XChartType > XclImpChTypeGroup::CreateChartType( Reference< XDiagram > const & xDiagram, sal_Int32 nApiAxesSetIdx ) const { OSL_ENSURE( IsValidGroup(), "XclImpChTypeGroup::CreateChartType - type group without series" ); @@ -2834,8 +2834,8 @@ void XclImpChTypeGroup::ReadChDataFormat( XclImpStream& rStrm ) mxGroupFmt = xDataFmt; } -void XclImpChTypeGroup::InsertDataSeries( Reference< XChartType > xChartType, - Reference< XDataSeries > xSeries, sal_Int32 nApiAxesSetIdx ) const +void XclImpChTypeGroup::InsertDataSeries( Reference< XChartType > const & xChartType, + Reference< XDataSeries > const & xSeries, sal_Int32 nApiAxesSetIdx ) const { Reference< XDataSeriesContainer > xSeriesCont( xChartType, UNO_QUERY ); if( xSeriesCont.is() && xSeries.is() ) @@ -2865,7 +2865,7 @@ void XclImpChTypeGroup::InsertDataSeries( Reference< XChartType > xChartType, } } -void XclImpChTypeGroup::CreateDataSeries( Reference< XChartType > xChartType, sal_Int32 nApiAxesSetIdx ) const +void XclImpChTypeGroup::CreateDataSeries( Reference< XChartType > const & xChartType, sal_Int32 nApiAxesSetIdx ) const { bool bSpline = false; for( XclImpChSeriesVec::const_iterator aIt = maSeries.begin(), aEnd = maSeries.end(); aIt != aEnd; ++aIt ) @@ -2882,7 +2882,7 @@ void XclImpChTypeGroup::CreateDataSeries( Reference< XChartType > xChartType, sa } } -void XclImpChTypeGroup::CreateStockSeries( Reference< XChartType > xChartType, sal_Int32 nApiAxesSetIdx ) const +void XclImpChTypeGroup::CreateStockSeries( Reference< XChartType > const & xChartType, sal_Int32 nApiAxesSetIdx ) const { // create the data series object Reference< XDataSeries > xDataSeries( ScfApiHelper::CreateInstance( SERVICE_CHART2_DATASERIES ), UNO_QUERY ); @@ -3583,7 +3583,7 @@ OUString XclImpChAxesSet::GetSingleSeriesTitle() const return (maTypeGroups.size() == 1) ? maTypeGroups.begin()->second->GetSingleSeriesTitle() : OUString(); } -void XclImpChAxesSet::Convert( Reference< XDiagram > xDiagram ) const +void XclImpChAxesSet::Convert( Reference< XDiagram > const & xDiagram ) const { if( IsValidAxesSet() && xDiagram.is() ) { @@ -3675,7 +3675,7 @@ void XclImpChAxesSet::ReadChTypeGroup( XclImpStream& rStrm ) itr, XclImpChTypeGroupMap::value_type(nGroupIdx, xTypeGroup)); } -Reference< XCoordinateSystem > XclImpChAxesSet::CreateCoordSystem( Reference< XDiagram > xDiagram ) const +Reference< XCoordinateSystem > XclImpChAxesSet::CreateCoordSystem( Reference< XDiagram > const & xDiagram ) const { Reference< XCoordinateSystem > xCoordSystem; @@ -3730,7 +3730,7 @@ Reference< XCoordinateSystem > XclImpChAxesSet::CreateCoordSystem( Reference< XD void XclImpChAxesSet::ConvertAxis( XclImpChAxisRef xChAxis, XclImpChTextRef xChAxisTitle, - Reference< XCoordinateSystem > xCoordSystem, const XclImpChAxis* pCrossingAxis ) const + Reference< XCoordinateSystem > const & xCoordSystem, const XclImpChAxis* pCrossingAxis ) const { if( xChAxis ) { @@ -3773,7 +3773,7 @@ Reference< XAxis > XclImpChAxesSet::CreateAxis( const XclImpChAxis& rChAxis, con return xAxis; } -void XclImpChAxesSet::ConvertBackground( Reference< XDiagram > xDiagram ) const +void XclImpChAxesSet::ConvertBackground( Reference< XDiagram > const & xDiagram ) const { XclImpChTypeGroupRef xTypeGroup = GetFirstTypeGroup(); if( xTypeGroup && xTypeGroup->Is3dWallChart() ) @@ -4333,7 +4333,7 @@ sal_Size XclImpChart::GetProgressSize() const (mxChartDrawing ? mxChartDrawing->GetProgressSize() : 0); } -void XclImpChart::Convert( Reference< XModel > xModel, XclImpDffConverter& rDffConv, const OUString& rObjName, const Rectangle& rChartRect ) const +void XclImpChart::Convert( Reference< XModel > const & xModel, XclImpDffConverter& rDffConv, const OUString& rObjName, const Rectangle& rChartRect ) const { Reference< XChartDocument > xChartDoc( xModel, UNO_QUERY ); if( xChartDoc.is() ) diff --git a/sc/source/filter/excel/xlchart.cxx b/sc/source/filter/excel/xlchart.cxx index 1daed0f0d31d..d4ad17ed2d1e 100644 --- a/sc/source/filter/excel/xlchart.cxx +++ b/sc/source/filter/excel/xlchart.cxx @@ -547,7 +547,7 @@ const XclChTypeInfo& XclChTypeInfoProvider::GetTypeInfoFromService( const OUStri // Property helpers =========================================================== -XclChObjectTable::XclChObjectTable( Reference< XMultiServiceFactory > xFactory, +XclChObjectTable::XclChObjectTable( Reference< XMultiServiceFactory > const & xFactory, const OUString& rServiceName, const OUString& rObjNameBase ) : mxFactory( xFactory ), maServiceName( rServiceName ), diff --git a/sc/source/filter/excel/xlescher.cxx b/sc/source/filter/excel/xlescher.cxx index e13ff854c598..70a4d79dcb15 100644 --- a/sc/source/filter/excel/xlescher.cxx +++ b/sc/source/filter/excel/xlescher.cxx @@ -287,7 +287,7 @@ void XclObjTextData::ReadTxo8( XclImpStream& rStrm ) mnFormatSize = rStrm.ReaduInt16(); } -Reference< XControlModel > XclControlHelper::GetControlModel( Reference< XShape > xShape ) +Reference< XControlModel > XclControlHelper::GetControlModel( Reference< XShape > const & xShape ) { Reference< XControlModel > xCtrlModel; Reference< XControlShape > xCtrlShape( xShape, UNO_QUERY ); diff --git a/sc/source/filter/ftools/fapihelper.cxx b/sc/source/filter/ftools/fapihelper.cxx index 8c57961dea42..3ad19a1fe4f3 100644 --- a/sc/source/filter/ftools/fapihelper.cxx +++ b/sc/source/filter/ftools/fapihelper.cxx @@ -135,7 +135,7 @@ ScfPropertySet::~ScfPropertySet() xPropSetOpt->enableChangeListenerNotification(true); } -void ScfPropertySet::Set( Reference< XPropertySet > xPropSet ) +void ScfPropertySet::Set( Reference< XPropertySet > const & xPropSet ) { mxPropSet = xPropSet; mxMultiPropSet.set( mxPropSet, UNO_QUERY ); diff --git a/sc/source/filter/inc/fapihelper.hxx b/sc/source/filter/inc/fapihelper.hxx index fa5f404b48bc..362a42090371 100644 --- a/sc/source/filter/inc/fapihelper.hxx +++ b/sc/source/filter/inc/fapihelper.hxx @@ -122,7 +122,7 @@ public: ~ScfPropertySet(); /** Sets the passed UNO property set and releases the old UNO property set. */ - void Set( css::uno::Reference< css::beans::XPropertySet > xPropSet ); + void Set( css::uno::Reference< css::beans::XPropertySet > const & xPropSet ); /** Queries the passed interface for an XPropertySet and releases the old UNO property set. */ template< typename InterfaceType > inline void Set( css::uno::Reference< InterfaceType > xInterface ) diff --git a/sc/source/filter/inc/xcl97esc.hxx b/sc/source/filter/inc/xcl97esc.hxx index a3895c7c5efc..1aa85010123a 100644 --- a/sc/source/filter/inc/xcl97esc.hxx +++ b/sc/source/filter/inc/xcl97esc.hxx @@ -102,21 +102,21 @@ public: /** Creates an OCX form control OBJ record from the passed form control. @descr Writes the form control data to the 'Ctls' stream. */ std::unique_ptr CreateOCXCtrlObj( - css::uno::Reference< css::drawing::XShape > xShape, + css::uno::Reference< css::drawing::XShape > const & xShape, const Rectangle* pChildAnchor ); private: tools::SvRef mxCtlsStrm; /// The 'Ctls' stream. /** Creates a TBX form control OBJ record from the passed form control. */ std::unique_ptr CreateTBXCtrlObj( - css::uno::Reference< css::drawing::XShape > xShape, + css::uno::Reference< css::drawing::XShape > const & xShape, const Rectangle* pChildAnchor ); private: /** Tries to get the name of a Basic macro from a control. */ void ConvertTbxMacro( XclExpTbxControlObj& rTbxCtrlObj, - css::uno::Reference< css::awt::XControlModel > xCtrlModel ); + css::uno::Reference< css::awt::XControlModel > const & xCtrlModel ); void DeleteCurrAppData(); diff --git a/sc/source/filter/inc/xechart.hxx b/sc/source/filter/inc/xechart.hxx index 37cdf1125d48..8baa58360796 100644 --- a/sc/source/filter/inc/xechart.hxx +++ b/sc/source/filter/inc/xechart.hxx @@ -99,7 +99,7 @@ public: const XclChFormatInfo& GetFormatInfo( XclChObjectType eObjType ) const; /** Starts the API chart document conversion. Must be called once before all API conversion. */ - void InitConversion( css::uno::Reference< css::chart2::XChartDocument > xChartDoc, + void InitConversion( css::uno::Reference< css::chart2::XChartDocument > const & xChartDoc, const Rectangle& rChartRect ) const; /** Finishes the API chart document conversion. Must be called once after all API conversion. */ void FinishConversion() const; @@ -389,7 +389,7 @@ public: void ConvertString( const OUString& aString ); /** Converts the passed source link, returns the number of linked values. */ - sal_uInt16 ConvertDataSequence( css::uno::Reference< css::chart2::data::XDataSequence > xDataSeq, + sal_uInt16 ConvertDataSequence( css::uno::Reference< css::chart2::data::XDataSequence > const & xDataSeq, bool bSplitToColumns, sal_uInt16 nDefCount = 0 ); /** Converts the passed sequence of formatted string objects, returns leading font index. */ sal_uInt16 ConvertStringSequence( const css::uno::Sequence< css::uno::Reference< css::chart2::XFormattedString > >& rStringSeq ); @@ -497,7 +497,7 @@ public: virtual void SetRotation( sal_uInt16 nRotation ) override; /** Converts all text settings of the passed title text object. */ - void ConvertTitle( css::uno::Reference< css::chart2::XTitle > xTitle, sal_uInt16 nTarget, const OUString* pSubTitle = nullptr ); + void ConvertTitle( css::uno::Reference< css::chart2::XTitle > const & xTitle, sal_uInt16 nTarget, const OUString* pSubTitle = nullptr ); /** Converts all text settings of the passed legend. */ void ConvertLegend( const ScfPropertySet& rPropSet ); /** Converts all settings of the passed data point caption text object. */ @@ -651,7 +651,7 @@ public: explicit XclExpChSerTrendLine( const XclExpChRoot& rRoot ); /** Converts the passed trend line, returns true if trend line type is supported. */ - bool Convert( css::uno::Reference< css::chart2::XRegressionCurve > xRegCurve, + bool Convert( css::uno::Reference< css::chart2::XRegressionCurve > const & xRegCurve, sal_uInt16 nSeriesIdx ); /** Returns formatting information of the trend line, created in Convert(). */ @@ -701,22 +701,22 @@ public: /** Converts the passed data series (source links and formatting). */ bool ConvertDataSeries( - css::uno::Reference< css::chart2::XDiagram > xDiagram, - css::uno::Reference< css::chart2::XDataSeries > xDataSeries, + css::uno::Reference< css::chart2::XDiagram > const & xDiagram, + css::uno::Reference< css::chart2::XDataSeries > const & xDataSeries, const XclChExtTypeInfo& rTypeInfo, sal_uInt16 nGroupIdx, sal_uInt16 nFormatIdx ); /** Converts the passed data series for stock charts. */ bool ConvertStockSeries( - css::uno::Reference< css::chart2::XDataSeries > xDataSeries, + css::uno::Reference< css::chart2::XDataSeries > const & xDataSeries, const OUString& rValueRole, sal_uInt16 nGroupIdx, sal_uInt16 nFormatIdx, bool bCloseSymbol ); /** Converts the passed error bar settings (called at trend line child series). */ bool ConvertTrendLine( const XclExpChSeries& rParent, - css::uno::Reference< css::chart2::XRegressionCurve > xRegCurve ); + css::uno::Reference< css::chart2::XRegressionCurve > const & xRegCurve ); /** Converts the passed error bar settings (called at error bar child series). */ bool ConvertErrorBar( const XclExpChSeries& rParent, const ScfPropertySet& rPropSet, sal_uInt8 nBarId ); /** Converts and inserts category ranges for all inserted series. */ - void ConvertCategSequence( css::uno::Reference< css::chart2::data::XLabeledDataSequence > xCategSeq ); + void ConvertCategSequence( css::uno::Reference< css::chart2::data::XLabeledDataSequence > const & xCategSeq ); /** Writes all embedded records. */ virtual void WriteSubRecords( XclExpStream& rStrm ) override; @@ -725,7 +725,7 @@ private: /** Initializes members of this series to represent a child of the passed series. */ void InitFromParent( const XclExpChSeries& rParent ); /** Tries to create trend line series objects (called at parent series). */ - void CreateTrendLines( css::uno::Reference< css::chart2::XDataSeries > xDataSeries ); + void CreateTrendLines( css::uno::Reference< css::chart2::XDataSeries > const & xDataSeries ); /** Tries to create positive and negative error bar series objects (called at parent series). */ void CreateErrorBars( const ScfPropertySet& rPropSet, const OUString& rBarPropName, @@ -765,8 +765,8 @@ public: explicit XclExpChType( const XclExpChRoot& rRoot ); /** Converts the passed chart type and the contained data series. */ - void Convert( css::uno::Reference< css::chart2::XDiagram > xDiagram, - css::uno::Reference< css::chart2::XChartType > xChartType, + void Convert( css::uno::Reference< css::chart2::XDiagram > const & xDiagram, + css::uno::Reference< css::chart2::XChartType > const & xChartType, sal_Int32 nApiAxesSetIdx, bool bSwappedAxesSet, bool bHasXLabels ); /** Sets stacking mode (standard or percent) for the series in this chart type group. */ void SetStacked( bool bPercent ); @@ -874,15 +874,15 @@ public: explicit XclExpChTypeGroup( const XclExpChRoot& rRoot, sal_uInt16 nGroupIdx ); /** Converts the passed chart type to Excel type settings. */ - void ConvertType( css::uno::Reference< css::chart2::XDiagram > xDiagram, - css::uno::Reference< css::chart2::XChartType > xChartType, + void ConvertType( css::uno::Reference< css::chart2::XDiagram > const & xDiagram, + css::uno::Reference< css::chart2::XChartType > const & xChartType, sal_Int32 nApiAxesSetIdx, bool b3dChart, bool bSwappedAxesSet, bool bHasXLabels ); /** Converts and inserts all series from the passed chart type. */ - void ConvertSeries( css::uno::Reference< css::chart2::XDiagram > xDiagram, - css::uno::Reference< css::chart2::XChartType > xChartType, + void ConvertSeries( css::uno::Reference< css::chart2::XDiagram > const & xDiagram, + css::uno::Reference< css::chart2::XChartType > const & xChartType, sal_Int32 nGroupAxesSetIdx, bool bPercent, bool bConnectorLines ); /** Converts and inserts category ranges for all inserted series. */ - void ConvertCategSequence( css::uno::Reference< css::chart2::data::XLabeledDataSequence > xCategSeq ); + void ConvertCategSequence( css::uno::Reference< css::chart2::data::XLabeledDataSequence > const & xCategSeq ); /** Creates a legend object and converts all legend settings. */ void ConvertLegend( const ScfPropertySet& rPropSet ); @@ -908,13 +908,13 @@ private: /** Returns an unused format index to be used for the next created series. */ sal_uInt16 GetFreeFormatIdx() const; /** Creates all data series of any chart type except stock charts. */ - void CreateDataSeries( css::uno::Reference< css::chart2::XDiagram > xDiagram, - css::uno::Reference< css::chart2::XDataSeries > xDataSeries ); + void CreateDataSeries( css::uno::Reference< css::chart2::XDiagram > const & xDiagram, + css::uno::Reference< css::chart2::XDataSeries > const & xDataSeries ); /** Creates all data series of a stock chart. */ - void CreateAllStockSeries( css::uno::Reference< css::chart2::XChartType > xChartType, - css::uno::Reference< css::chart2::XDataSeries > xDataSeries ); + void CreateAllStockSeries( css::uno::Reference< css::chart2::XChartType > const & xChartType, + css::uno::Reference< css::chart2::XDataSeries > const & xDataSeries ); /** Creates a single data series of a stock chart. */ - bool CreateStockSeries( css::uno::Reference< css::chart2::XDataSeries > xDataSeries, + bool CreateStockSeries( css::uno::Reference< css::chart2::XDataSeries > const & xDataSeries, const OUString& rValueRole, bool bCloseSymbol ); virtual void WriteBody( XclExpStream& rStrm ) override; @@ -1021,12 +1021,12 @@ public: virtual void SetRotation( sal_uInt16 nRotation ) override; /** Converts formatting and scaling settings from the passed axis. */ - void Convert( css::uno::Reference< css::chart2::XAxis > xAxis, - css::uno::Reference< css::chart2::XAxis > xCrossingAxis, - css::uno::Reference< css::chart::XAxis > xChart1Axis, + void Convert( css::uno::Reference< css::chart2::XAxis > const & xAxis, + css::uno::Reference< css::chart2::XAxis > const & xCrossingAxis, + css::uno::Reference< css::chart::XAxis > const & xChart1Axis, const XclChExtTypeInfo& rTypeInfo ); /** Converts and writes 3D wall/floor properties from the passed diagram. */ - void ConvertWall( css::uno::Reference< css::chart2::XDiagram > xDiagram ); + void ConvertWall( css::uno::Reference< css::chart2::XDiagram > const & xDiagram ); /** Returns the type of this axis. */ inline sal_uInt16 GetAxisType() const { return maData.mnType; } @@ -1067,7 +1067,7 @@ public: /** Converts the passed diagram to chart record data. @return First unused chart type group index. */ - sal_uInt16 Convert( css::uno::Reference< css::chart2::XDiagram > xDiagram, + sal_uInt16 Convert( css::uno::Reference< css::chart2::XDiagram > const & xDiagram, sal_uInt16 nFirstGroupIdx ); /** Returns true, if this axes set exists (returns false if this is a dummy object). */ @@ -1091,7 +1091,7 @@ private: /** Converts a complete axis object including axis title. */ void ConvertAxis( XclExpChAxisRef& rxChAxis, sal_uInt16 nAxisType, XclExpChTextRef& rxChAxisTitle, sal_uInt16 nTitleTarget, - css::uno::Reference< css::chart2::XCoordinateSystem > xCoordSystem, + css::uno::Reference< css::chart2::XCoordinateSystem > const & xCoordSystem, const XclChExtTypeInfo& rTypeInfo, sal_Int32 nCrossingAxisDim ); @@ -1126,7 +1126,7 @@ class XclExpChChart : public XclExpChGroupBase { public: explicit XclExpChChart( const XclExpRoot& rRoot, - css::uno::Reference< css::chart2::XChartDocument > xChartDoc, + css::uno::Reference< css::chart2::XChartDocument > const & xChartDoc, const Rectangle& rChartRect ); /** Creates, registers and returns a new data series object. */ @@ -1182,7 +1182,7 @@ class XclExpChart : public XclExpSubStream, protected XclExpRoot { public: explicit XclExpChart( const XclExpRoot& rRoot, - css::uno::Reference< css::frame::XModel > xModel, + css::uno::Reference< css::frame::XModel > const & xModel, const Rectangle& rChartRect ); }; diff --git a/sc/source/filter/inc/xeescher.hxx b/sc/source/filter/inc/xeescher.hxx index 2113e1e52ae2..bd94a98dbfb2 100644 --- a/sc/source/filter/inc/xeescher.hxx +++ b/sc/source/filter/inc/xeescher.hxx @@ -169,7 +169,7 @@ public: protected: /** Tries to get spreadsheet cell link and source range link from the passed shape. */ void ConvertSheetLinks( - css::uno::Reference< css::drawing::XShape > xShape ); + css::uno::Reference< css::drawing::XShape > const & xShape ); /** Returns the Excel token array of the cell link, or 0, if no link present. */ inline const XclTokenArray* GetCellLinkTokArr() const { return mxCellLink.get(); } @@ -211,7 +211,7 @@ public: class XclExpShapeObj : public XclObjAny, public XclMacroHelper { public: - explicit XclExpShapeObj( XclExpObjectManager& rRoot, css::uno::Reference< css::drawing::XShape > xShape, ScDocument* pDoc ); + explicit XclExpShapeObj( XclExpObjectManager& rRoot, css::uno::Reference< css::drawing::XShape > const & xShape, ScDocument* pDoc ); virtual ~XclExpShapeObj(); private: virtual void WriteSubRecs( XclExpStream& rStrm ) override; @@ -226,7 +226,7 @@ class XclExpOcxControlObj : public XclObj, public XclExpControlHelper public: explicit XclExpOcxControlObj( XclExpObjectManager& rObjMgr, - css::uno::Reference< css::drawing::XShape > xShape, + css::uno::Reference< css::drawing::XShape > const & xShape, const Rectangle* pChildAnchor, const OUString& rClassName, sal_uInt32 nStrmStart, sal_uInt32 nStrmSize ); @@ -248,7 +248,7 @@ class XclExpTbxControlObj : public XclObj, public XclMacroHelper public: explicit XclExpTbxControlObj( XclExpObjectManager& rObjMgr, - css::uno::Reference< css::drawing::XShape > xShape, + css::uno::Reference< css::drawing::XShape > const & xShape, const Rectangle* pChildAnchor ); /** Sets the name of a macro attached to this control. @@ -291,7 +291,7 @@ class XclExpChartObj : public XclObj, protected XclExpRoot public: explicit XclExpChartObj( XclExpObjectManager& rObjMgr, - css::uno::Reference< css::drawing::XShape > xShape, + css::uno::Reference< css::drawing::XShape > const & xShape, const Rectangle* pChildAnchor ); virtual ~XclExpChartObj(); diff --git a/sc/source/filter/inc/xichart.hxx b/sc/source/filter/inc/xichart.hxx index cd16646e6b41..9d3d9a0f194d 100644 --- a/sc/source/filter/inc/xichart.hxx +++ b/sc/source/filter/inc/xichart.hxx @@ -813,7 +813,7 @@ private: XclImpChDataFormatRef CreateDataFormat( sal_uInt16 nPointIdx, sal_uInt16 nFormatIdx ); /** Converts all trend lines and inserts them into the passed API data series object. */ - void ConvertTrendLines( css::uno::Reference< css::chart2::XDataSeries > xDataSeries ) const; + void ConvertTrendLines( css::uno::Reference< css::chart2::XDataSeries > const & xDataSeries ) const; /** Tries to create an error bar API object from the specified Excel error bars. */ css::uno::Reference< css::beans::XPropertySet > CreateErrorBar( sal_uInt8 nPosBarId, sal_uInt8 nNegBarId ) const; @@ -869,7 +869,7 @@ public: CreateCoordSystem( bool b3dChart ) const; /** Creates and returns an object that represents the contained chart type. */ css::uno::Reference< css::chart2::XChartType > - CreateChartType( css::uno::Reference< css::chart2::XDiagram > xDiagram, bool b3dChart ) const; + CreateChartType( css::uno::Reference< css::chart2::XDiagram > const & xDiagram, bool b3dChart ) const; private: XclChType maData; /// Contents of the chart type record. @@ -1008,7 +1008,7 @@ public: CreateCoordSystem() const; /** Creates and returns an object that represents the contained chart type. */ css::uno::Reference< css::chart2::XChartType > - CreateChartType( css::uno::Reference< css::chart2::XDiagram > xDiagram, sal_Int32 nApiAxesSetIdx ) const; + CreateChartType( css::uno::Reference< css::chart2::XDiagram > const & xDiagram, sal_Int32 nApiAxesSetIdx ) const; /** Creates a labeled data sequence object for axis categories. */ css::uno::Reference< css::chart2::data::XLabeledDataSequence > CreateCategSequence() const; @@ -1027,14 +1027,14 @@ private: inline bool HasDropBars() const { return !m_DropBars.empty(); } /** Inserts the passed series into the chart type. Adds additional properties to the series. */ - void InsertDataSeries( css::uno::Reference< css::chart2::XChartType > xChartType, - css::uno::Reference< css::chart2::XDataSeries > xSeries, + void InsertDataSeries( css::uno::Reference< css::chart2::XChartType > const & xChartType, + css::uno::Reference< css::chart2::XDataSeries > const & xSeries, sal_Int32 nApiAxesSetIdx ) const; /** Creates all data series of any chart type except stock charts. */ - void CreateDataSeries( css::uno::Reference< css::chart2::XChartType > xChartType, + void CreateDataSeries( css::uno::Reference< css::chart2::XChartType > const & xChartType, sal_Int32 nApiAxesSetIdx ) const; /** Creates all data series of a stock chart. */ - void CreateStockSeries( css::uno::Reference< css::chart2::XChartType > xChartType, + void CreateStockSeries( css::uno::Reference< css::chart2::XChartType > const & xChartType, sal_Int32 nApiAxesSetIdx ) const; private: @@ -1224,7 +1224,7 @@ public: OUString GetSingleSeriesTitle() const; /** Creates a coordinate system and converts all series and axis settings. */ - void Convert( css::uno::Reference< css::chart2::XDiagram > xDiagram ) const; + void Convert( css::uno::Reference< css::chart2::XDiagram > const & xDiagram ) const; /** Converts the manual positions of all axis titles. */ void ConvertTitlePositions() const; @@ -1240,16 +1240,16 @@ private: /** Creates a coordinate system that contains all chart types for this axes set. */ css::uno::Reference< css::chart2::XCoordinateSystem > - CreateCoordSystem( css::uno::Reference< css::chart2::XDiagram > xDiagram ) const; + CreateCoordSystem( css::uno::Reference< css::chart2::XDiagram > const & xDiagram ) const; /** Creates and inserts an axis into the container and registers the coordinate system. */ void ConvertAxis( XclImpChAxisRef xChAxis, XclImpChTextRef xChAxisTitle, - css::uno::Reference< css::chart2::XCoordinateSystem > xCoordSystem, + css::uno::Reference< css::chart2::XCoordinateSystem > const & xCoordSystem, const XclImpChAxis* pCrossingAxis ) const; /** Creates and returns an API axis object. */ css::uno::Reference< css::chart2::XAxis > CreateAxis( const XclImpChAxis& rChAxis, const XclImpChAxis* pCrossingAxis ) const; /** Writes all properties of the background area to the passed diagram. */ - void ConvertBackground( css::uno::Reference< css::chart2::XDiagram > xDiagram ) const; + void ConvertBackground( css::uno::Reference< css::chart2::XDiagram > const & xDiagram ) const; private: typedef ::std::map XclImpChTypeGroupMap; @@ -1396,7 +1396,7 @@ public: inline bool IsPivotChart() const { return mbIsPivotChart; } /** Creates the chart object in the passed component. */ - void Convert( css::uno::Reference< css::frame::XModel > xModel, + void Convert( css::uno::Reference< css::frame::XModel > const & xModel, XclImpDffConverter& rDffConv, const OUString& rObjName, const Rectangle& rChartRect ) const; diff --git a/sc/source/filter/inc/xlchart.hxx b/sc/source/filter/inc/xlchart.hxx index 0007685e956a..152d876c76ac 100644 --- a/sc/source/filter/inc/xlchart.hxx +++ b/sc/source/filter/inc/xlchart.hxx @@ -1281,7 +1281,7 @@ typedef css::uno::Reference< css::drawing::XShape > class XclChObjectTable { public: - explicit XclChObjectTable( css::uno::Reference< css::lang::XMultiServiceFactory > xFactory, + explicit XclChObjectTable( css::uno::Reference< css::lang::XMultiServiceFactory > const & xFactory, const OUString& rServiceName, const OUString& rObjNameBase ); /** Returns a named formatting object from the chart document. */ diff --git a/sc/source/filter/inc/xlescher.hxx b/sc/source/filter/inc/xlescher.hxx index dd007ce66e8a..3f8bde8a6c5d 100644 --- a/sc/source/filter/inc/xlescher.hxx +++ b/sc/source/filter/inc/xlescher.hxx @@ -421,7 +421,7 @@ class XclControlHelper public: /** Returns the API control model from the passed API shape object. */ static css::uno::Reference< css::awt::XControlModel > - GetControlModel( css::uno::Reference< css::drawing::XShape > xShape ); + GetControlModel( css::uno::Reference< css::drawing::XShape > const & xShape ); /** Fills the macro descriptor according to the passed macro name. */ static bool FillMacroDescriptor( diff --git a/sc/source/filter/xcl97/xcl97esc.cxx b/sc/source/filter/xcl97/xcl97esc.cxx index bd845597a939..6b48b87df8b2 100644 --- a/sc/source/filter/xcl97/xcl97esc.cxx +++ b/sc/source/filter/xcl97/xcl97esc.cxx @@ -405,7 +405,7 @@ void XclEscherEx::EndDocument() mpOutStrm->Seek( 0 ); } -std::unique_ptr XclEscherEx::CreateOCXCtrlObj( Reference< XShape > xShape, const Rectangle* pChildAnchor ) +std::unique_ptr XclEscherEx::CreateOCXCtrlObj( Reference< XShape > const & xShape, const Rectangle* pChildAnchor ) { ::std::unique_ptr< XclExpOcxControlObj > xOcxCtrl; @@ -435,7 +435,7 @@ std::unique_ptr XclEscherEx::CreateOCXCtrlObj( Reference< X return xOcxCtrl; } -std::unique_ptr XclEscherEx::CreateTBXCtrlObj( Reference< XShape > xShape, const Rectangle* pChildAnchor ) +std::unique_ptr XclEscherEx::CreateTBXCtrlObj( Reference< XShape > const & xShape, const Rectangle* pChildAnchor ) { ::std::unique_ptr< XclExpTbxControlObj > xTbxCtrl( new XclExpTbxControlObj( mrObjMgr, xShape, pChildAnchor ) ); if( xTbxCtrl->GetObjType() == EXC_OBJTYPE_UNKNOWN ) @@ -450,7 +450,7 @@ std::unique_ptr XclEscherEx::CreateTBXCtrlObj( Reference< X return xTbxCtrl; } -void XclEscherEx::ConvertTbxMacro( XclExpTbxControlObj& rTbxCtrlObj, Reference< XControlModel > xCtrlModel ) +void XclEscherEx::ConvertTbxMacro( XclExpTbxControlObj& rTbxCtrlObj, Reference< XControlModel > const & xCtrlModel ) { SdrPage* pSdrPage = GetSdrPage( GetCurrScTab() ); if( xCtrlModel.is() && GetDocShell() && pSdrPage ) try diff --git a/sc/source/filter/xml/xmlexprt.cxx b/sc/source/filter/xml/xmlexprt.cxx index 38b168feb343..6cb41f5171fc 100644 --- a/sc/source/filter/xml/xmlexprt.cxx +++ b/sc/source/filter/xml/xmlexprt.cxx @@ -2178,7 +2178,7 @@ void ScXMLExport::AddStyleFromRow(const uno::Reference& xRo } } -static uno::Any lcl_GetEnumerated( uno::Reference xEnumAccess, sal_Int32 nIndex ) +static uno::Any lcl_GetEnumerated( uno::Reference const & xEnumAccess, sal_Int32 nIndex ) { uno::Any aRet; uno::Reference xEnum( xEnumAccess->createEnumeration() ); @@ -2644,7 +2644,7 @@ void ScXMLExport::ExportMasterStyles_() GetPageExport()->exportMasterStyles( true ); } -void ScXMLExport::CollectInternalShape( uno::Reference< drawing::XShape > xShape ) +void ScXMLExport::CollectInternalShape( uno::Reference< drawing::XShape > const & xShape ) { // detective objects and notes if( SvxShape* pShapeImp = SvxShape::getImplementation( xShape ) ) @@ -3040,7 +3040,7 @@ void writeContent( void flushParagraph( ScXMLExport& rExport, const OUString& rParaText, - rtl::Reference xMapper, rtl::Reference xStylePool, + rtl::Reference const & xMapper, rtl::Reference const & xStylePool, const ScXMLEditAttributeMap& rAttrMap, std::vector::const_iterator it, std::vector::const_iterator itEnd ) { diff --git a/sc/source/filter/xml/xmlexprt.hxx b/sc/source/filter/xml/xmlexprt.hxx index 6d9b70376af1..114d322f1fb4 100644 --- a/sc/source/filter/xml/xmlexprt.hxx +++ b/sc/source/filter/xml/xmlexprt.hxx @@ -140,7 +140,7 @@ class ScXMLExport : public SvXMLExport virtual void ExportContent_() override; virtual void ExportMeta_() override; - void CollectInternalShape( css::uno::Reference< css::drawing::XShape > xShape ); + void CollectInternalShape( css::uno::Reference< css::drawing::XShape > const & xShape ); static css::table::CellRangeAddress GetEndAddress(const css::uno::Reference& xTable, const sal_Int32 nTable); diff --git a/sc/source/ui/inc/condformatuno.hxx b/sc/source/ui/inc/condformatuno.hxx index c4cf9b703011..7bf0e7cd57ba 100644 --- a/sc/source/ui/inc/condformatuno.hxx +++ b/sc/source/ui/inc/condformatuno.hxx @@ -85,7 +85,7 @@ class ScCondFormatObj : public cppu::WeakImplHelper { public: - ScCondFormatObj(ScDocShell* pDocShell, rtl::Reference xCondFormats, sal_Int32 nKey); + ScCondFormatObj(ScDocShell* pDocShell, rtl::Reference const & xCondFormats, sal_Int32 nKey); virtual ~ScCondFormatObj(); @@ -168,7 +168,7 @@ class ScConditionEntryObj : public cppu::WeakImplHelper xParent, + ScConditionEntryObj(rtl::Reference const & xParent, const ScCondFormatEntry* pFormat); virtual ~ScConditionEntryObj(); @@ -227,7 +227,7 @@ class ScColorScaleFormatObj : public cppu::WeakImplHelper xParent, const ScColorScaleFormat* pFormat); + ScColorScaleFormatObj(rtl::Reference const & xParent, const ScColorScaleFormat* pFormat); virtual ~ScColorScaleFormatObj(); // XConditionEntry @@ -283,7 +283,7 @@ private: class ScColorScaleEntryObj : public cppu::WeakImplHelper { public: - ScColorScaleEntryObj(rtl::Reference xParent, size_t nPos); + ScColorScaleEntryObj(rtl::Reference const & xParent, size_t nPos); virtual ~ScColorScaleEntryObj(); @@ -316,7 +316,7 @@ class ScDataBarFormatObj : public cppu::WeakImplHelper { public: - ScDataBarFormatObj(rtl::Reference xParent, + ScDataBarFormatObj(rtl::Reference const & xParent, const ScDataBarFormat* pFormat); virtual ~ScDataBarFormatObj(); @@ -372,7 +372,7 @@ private: class ScDataBarEntryObj : public cppu::WeakImplHelper { public: - ScDataBarEntryObj(rtl::Reference xParent, size_t nPos); + ScDataBarEntryObj(rtl::Reference const & xParent, size_t nPos); virtual ~ScDataBarEntryObj(); @@ -399,7 +399,7 @@ class ScIconSetFormatObj : public cppu::WeakImplHelper { public: - ScIconSetFormatObj(rtl::Reference xParent, + ScIconSetFormatObj(rtl::Reference const & xParent, const ScIconSetFormat* pFormat); virtual ~ScIconSetFormatObj(); @@ -455,7 +455,7 @@ private: class ScIconSetEntryObj : public cppu::WeakImplHelper { public: - ScIconSetEntryObj(rtl::Reference xParent, size_t nPos); + ScIconSetEntryObj(rtl::Reference const & xParent, size_t nPos); virtual ~ScIconSetEntryObj(); @@ -482,7 +482,7 @@ class ScCondDateFormatObj : public cppu::WeakImplHelper { public: - ScCondDateFormatObj(rtl::Reference xParent, + ScCondDateFormatObj(rtl::Reference const & xParent, const ScCondDateFormatEntry* pFormat); virtual ~ScCondDateFormatObj(); diff --git a/sc/source/ui/inc/spelleng.hxx b/sc/source/ui/inc/spelleng.hxx index edc9225738cf..c5211ab46d42 100644 --- a/sc/source/ui/inc/spelleng.hxx +++ b/sc/source/ui/inc/spelleng.hxx @@ -99,7 +99,7 @@ public: ScViewData& rViewData, ScDocument* pUndoDoc, ScDocument* pRedoDoc, - css::uno::Reference< css::linguistic2::XSpellChecker1 > xSpeller ); + css::uno::Reference< css::linguistic2::XSpellChecker1 > const & xSpeller ); /** Checks spelling of all cells in the selection or sheet. */ virtual void ConvertAll( EditView& rEditView ) override; diff --git a/sc/source/ui/unoobj/condformatuno.cxx b/sc/source/ui/unoobj/condformatuno.cxx index b598649c2278..bf402f013301 100644 --- a/sc/source/ui/unoobj/condformatuno.cxx +++ b/sc/source/ui/unoobj/condformatuno.cxx @@ -409,7 +409,7 @@ ScConditionalFormatList* ScCondFormatsObj::getCoreObject() namespace { uno::Reference createConditionEntry(const ScFormatEntry* pEntry, - rtl::Reference xParent) + rtl::Reference const & xParent) { switch (pEntry->GetType()) { @@ -441,7 +441,7 @@ uno::Reference createConditionEntry(const ScFormatEntry* pE } -ScCondFormatObj::ScCondFormatObj(ScDocShell* pDocShell, rtl::Reference xCondFormats, +ScCondFormatObj::ScCondFormatObj(ScDocShell* pDocShell, rtl::Reference const & xCondFormats, sal_Int32 nKey): mxCondFormatList(xCondFormats), mpDocShell(pDocShell), @@ -682,7 +682,7 @@ bool isObjectStillAlive(ScConditionalFormat* pFormat, const ScFormatEntry* pEntr } -ScConditionEntryObj::ScConditionEntryObj(rtl::Reference xParent, +ScConditionEntryObj::ScConditionEntryObj(rtl::Reference const & xParent, const ScCondFormatEntry* pFormat): mpDocShell(xParent->getDocShell()), mxParent(xParent), @@ -865,7 +865,7 @@ void SAL_CALL ScConditionEntryObj::removeVetoableChangeListener( const OUString& SAL_WARN("sc", "not implemented"); } -ScColorScaleFormatObj::ScColorScaleFormatObj(rtl::Reference xParent, +ScColorScaleFormatObj::ScColorScaleFormatObj(rtl::Reference const & xParent, const ScColorScaleFormat* pFormat): mxParent(xParent), maPropSet(getColorScalePropSet()), @@ -902,7 +902,7 @@ uno::Reference SAL_CALL ScColorScaleFormatObj::getPrope namespace { -void setColorScaleEntry(ScColorScaleEntry* pEntry, uno::Reference xEntry) +void setColorScaleEntry(ScColorScaleEntry* pEntry, uno::Reference const & xEntry) { ScColorScaleEntryType eType = ScColorScaleEntryType(); sal_Int32 nApiType = xEntry->getType(); @@ -1041,7 +1041,7 @@ void SAL_CALL ScColorScaleFormatObj::removeVetoableChangeListener( const OUStrin SAL_WARN("sc", "not implemented"); } -ScColorScaleEntryObj::ScColorScaleEntryObj(rtl::Reference xParent, +ScColorScaleEntryObj::ScColorScaleEntryObj(rtl::Reference const & xParent, size_t nPos): mxParent(xParent), mnPos(nPos) @@ -1137,7 +1137,7 @@ void ScColorScaleEntryObj::setFormula(const OUString& rFormula) } -ScDataBarFormatObj::ScDataBarFormatObj(rtl::Reference xParent, +ScDataBarFormatObj::ScDataBarFormatObj(rtl::Reference const & xParent, const ScDataBarFormat* pFormat): mxParent(xParent), maPropSet(getDataBarPropSet()), @@ -1175,7 +1175,7 @@ uno::Reference SAL_CALL ScDataBarFormatObj::getProperty namespace { -void setDataBarEntry(ScColorScaleEntry* pEntry, uno::Reference xEntry) +void setDataBarEntry(ScColorScaleEntry* pEntry, uno::Reference const & xEntry) { ScColorScaleEntryType eType = ScColorScaleEntryType(); sal_Int32 nApiType = xEntry->getType(); @@ -1451,7 +1451,7 @@ void SAL_CALL ScDataBarFormatObj::removeVetoableChangeListener( const OUString&, SAL_WARN("sc", "not implemented"); } -ScDataBarEntryObj::ScDataBarEntryObj(rtl::Reference xParent, +ScDataBarEntryObj::ScDataBarEntryObj(rtl::Reference const & xParent, size_t nPos): mxParent(xParent), mnPos(nPos) @@ -1537,7 +1537,7 @@ void ScDataBarEntryObj::setFormula(const OUString& rFormula) } -ScIconSetFormatObj::ScIconSetFormatObj(rtl::Reference xParent, +ScIconSetFormatObj::ScIconSetFormatObj(rtl::Reference const & xParent, const ScIconSetFormat* pFormat): mxParent(xParent), maPropSet(getIconSetPropSet()), @@ -1575,7 +1575,7 @@ uno::Reference SAL_CALL ScIconSetFormatObj::getProperty namespace { -void setIconSetEntry(ScIconSetFormat* pFormat, uno::Reference xEntry, size_t nPos) +void setIconSetEntry(ScIconSetFormat* pFormat, uno::Reference const & xEntry, size_t nPos) { ScIconSetFormatData* pData = pFormat->GetIconSetData(); ScColorScaleEntryType eType = ScColorScaleEntryType(); @@ -1770,7 +1770,7 @@ void SAL_CALL ScIconSetFormatObj::removeVetoableChangeListener( const OUString&, SAL_WARN("sc", "not implemented"); } -ScIconSetEntryObj::ScIconSetEntryObj(rtl::Reference xParent, +ScIconSetEntryObj::ScIconSetEntryObj(rtl::Reference const & xParent, size_t nPos): mxParent(xParent), mnPos(nPos) @@ -1860,7 +1860,7 @@ void ScIconSetEntryObj::setFormula(const OUString& rFormula) } } -ScCondDateFormatObj::ScCondDateFormatObj(rtl::Reference xParent, +ScCondDateFormatObj::ScCondDateFormatObj(rtl::Reference const & xParent, const ScCondDateFormatEntry* pFormat): mxParent(xParent), maPropSet(getCondDatePropSet()), diff --git a/sc/source/ui/unoobj/nameuno.cxx b/sc/source/ui/unoobj/nameuno.cxx index 5c60a5b2d496..df1c88d67842 100644 --- a/sc/source/ui/unoobj/nameuno.cxx +++ b/sc/source/ui/unoobj/nameuno.cxx @@ -81,7 +81,7 @@ static bool lcl_UserVisibleName(const ScRangeData& rData) return !rData.HasType(ScRangeData::Type::Database); } -ScNamedRangeObj::ScNamedRangeObj( rtl::Reference< ScNamedRangesObj > xParent, ScDocShell* pDocSh, const OUString& rNm, Reference xSheet): +ScNamedRangeObj::ScNamedRangeObj( rtl::Reference< ScNamedRangesObj > const & xParent, ScDocShell* pDocSh, const OUString& rNm, Reference const & xSheet): mxParent(xParent), pDocShell( pDocSh ), aName( rNm ), @@ -867,7 +867,7 @@ SCTAB ScGlobalNamedRangesObj::GetTab_Impl() return -1; } -ScLocalNamedRangesObj::ScLocalNamedRangesObj( ScDocShell* pDocSh, uno::Reference xSheet ) +ScLocalNamedRangesObj::ScLocalNamedRangesObj( ScDocShell* pDocSh, uno::Reference const & xSheet ) : ScNamedRangesObj(pDocSh), mxSheet(xSheet) { diff --git a/sc/source/ui/vba/vbadialog.hxx b/sc/source/ui/vba/vbadialog.hxx index 8d63ee7f5756..376d9198673e 100644 --- a/sc/source/ui/vba/vbadialog.hxx +++ b/sc/source/ui/vba/vbadialog.hxx @@ -29,7 +29,7 @@ typedef cppu::ImplInheritanceHelper< VbaDialogBase, ov::excel::XDialog > ScVbaDi class ScVbaDialog : public ScVbaDialog_BASE { public: - ScVbaDialog( const css::uno::Reference< ov::XHelperInterface >& xParent, const css::uno::Reference< css::uno::XComponentContext > xContext, const css::uno::Reference< css::frame::XModel >& xModel, sal_Int32 nIndex ):ScVbaDialog_BASE( xParent, xContext, xModel, nIndex ) {} + ScVbaDialog( const css::uno::Reference< ov::XHelperInterface >& xParent, const css::uno::Reference< css::uno::XComponentContext > & xContext, const css::uno::Reference< css::frame::XModel >& xModel, sal_Int32 nIndex ):ScVbaDialog_BASE( xParent, xContext, xModel, nIndex ) {} virtual ~ScVbaDialog() {} // Methods diff --git a/sc/source/ui/vba/vbaoleobject.cxx b/sc/source/ui/vba/vbaoleobject.cxx index 45a2ddd72846..f08eab946af9 100644 --- a/sc/source/ui/vba/vbaoleobject.cxx +++ b/sc/source/ui/vba/vbaoleobject.cxx @@ -33,7 +33,7 @@ using namespace com::sun::star; using namespace ooo::vba; ScVbaOLEObject::ScVbaOLEObject( const uno::Reference< XHelperInterface >& xParent, const uno::Reference< uno::XComponentContext >& xContext, - css::uno::Reference< css::drawing::XControlShape > xControlShape ) + css::uno::Reference< css::drawing::XControlShape > const & xControlShape ) : OLEObjectImpl_BASE( xParent, xContext ) { //init m_xWindowPeer diff --git a/sc/source/ui/vba/vbaoleobject.hxx b/sc/source/ui/vba/vbaoleobject.hxx index 3f4c37c7552e..e9285496035e 100644 --- a/sc/source/ui/vba/vbaoleobject.hxx +++ b/sc/source/ui/vba/vbaoleobject.hxx @@ -35,7 +35,7 @@ protected: css::uno::Reference< ov::msforms::XControl> m_xControl; public: ScVbaOLEObject( const css::uno::Reference< ov::XHelperInterface >& xParent, const css::uno::Reference< css::uno::XComponentContext >& xContext, - css::uno::Reference< css::drawing::XControlShape > xControlShape ); + css::uno::Reference< css::drawing::XControlShape > const & xControlShape ); // XOLEObject Attributes virtual css::uno::Reference< css::uno::XInterface > SAL_CALL getObject() throw (css::uno::RuntimeException, std::exception) override; diff --git a/sc/source/ui/vba/vbaoutline.hxx b/sc/source/ui/vba/vbaoutline.hxx index 6bd791d827c3..c2771d6aa9f4 100644 --- a/sc/source/ui/vba/vbaoutline.hxx +++ b/sc/source/ui/vba/vbaoutline.hxx @@ -31,7 +31,7 @@ class ScVbaOutline : public ScVbaOutline_BASE css::uno::Reference< css::sheet::XSheetOutline > mxOutline; public: ScVbaOutline( const css::uno::Reference< ov::XHelperInterface >& xParent, const css::uno::Reference< css::uno::XComponentContext >& xContext, - css::uno::Reference outline): ScVbaOutline_BASE( xParent, xContext) , mxOutline(outline) + css::uno::Reference const & outline): ScVbaOutline_BASE( xParent, xContext) , mxOutline(outline) {} virtual ~ScVbaOutline(){} diff --git a/sc/source/ui/vba/vbaworkbook.cxx b/sc/source/ui/vba/vbaworkbook.cxx index 6b97d3b7bb90..4547cc234a72 100644 --- a/sc/source/ui/vba/vbaworkbook.cxx +++ b/sc/source/ui/vba/vbaworkbook.cxx @@ -203,7 +203,7 @@ ScVbaWorkbook::init() ResetColors(); } -ScVbaWorkbook::ScVbaWorkbook( const css::uno::Reference< ov::XHelperInterface >& xParent, const css::uno::Reference< css::uno::XComponentContext >& xContext, css::uno::Reference< css::frame::XModel > xModel ) : ScVbaWorkbook_BASE( xParent, xContext, xModel ) +ScVbaWorkbook::ScVbaWorkbook( const css::uno::Reference< ov::XHelperInterface >& xParent, const css::uno::Reference< css::uno::XComponentContext >& xContext, css::uno::Reference< css::frame::XModel > const & xModel ) : ScVbaWorkbook_BASE( xParent, xContext, xModel ) { init(); } diff --git a/sc/source/ui/vba/vbaworkbook.hxx b/sc/source/ui/vba/vbaworkbook.hxx index 49d434ced9f8..80b89523cebc 100644 --- a/sc/source/ui/vba/vbaworkbook.hxx +++ b/sc/source/ui/vba/vbaworkbook.hxx @@ -36,7 +36,7 @@ class ScVbaWorkbook : public ScVbaWorkbook_BASE public: ScVbaWorkbook( const css::uno::Reference< ov::XHelperInterface >& xParent, const css::uno::Reference< css::uno::XComponentContext >& xContext, - css::uno::Reference< css::frame::XModel > xModel ); + css::uno::Reference< css::frame::XModel > const & xModel ); ScVbaWorkbook( css::uno::Sequence< css::uno::Any > const& aArgs, css::uno::Reference< css::uno::XComponentContext >const& xContext ); virtual ~ScVbaWorkbook() {} diff --git a/sc/source/ui/vba/vbaworksheet.cxx b/sc/source/ui/vba/vbaworksheet.cxx index 415c0eaf4858..d9051aab94ab 100644 --- a/sc/source/ui/vba/vbaworksheet.cxx +++ b/sc/source/ui/vba/vbaworksheet.cxx @@ -240,7 +240,7 @@ ScVbaWorksheet::createSheetCopyInNewDoc(const OUString& aCurrSheetName) } css::uno::Reference< ov::excel::XWorksheet > -ScVbaWorksheet::createSheetCopy(uno::Reference xSheet, bool bAfter) +ScVbaWorksheet::createSheetCopy(uno::Reference const & xSheet, bool bAfter) { OUString aCurrSheetName = getName(); ScVbaWorksheet* pDestSheet = excel::getImplFromDocModuleWrapper( xSheet ); diff --git a/sc/source/ui/vba/vbaworksheet.hxx b/sc/source/ui/vba/vbaworksheet.hxx index cb670d8df813..2a6b66e51b55 100644 --- a/sc/source/ui/vba/vbaworksheet.hxx +++ b/sc/source/ui/vba/vbaworksheet.hxx @@ -78,7 +78,7 @@ public: { return mxSheet; } static const css::uno::Sequence& getUnoTunnelId(); css::uno::Reference< ov::excel::XWorksheet > createSheetCopyInNewDoc( const OUString& ); - css::uno::Reference< ov::excel::XWorksheet > createSheetCopy(css::uno::Reference< ov::excel::XWorksheet> xSheet, bool bAfter); + css::uno::Reference< ov::excel::XWorksheet > createSheetCopy(css::uno::Reference< ov::excel::XWorksheet> const & xSheet, bool bAfter); // Attributes virtual OUString SAL_CALL getName() throw (css::uno::RuntimeException, std::exception) override; diff --git a/sc/source/ui/view/drawvie4.cxx b/sc/source/ui/view/drawvie4.cxx index dbc8ef80fd00..cbbc3af03f1c 100644 --- a/sc/source/ui/view/drawvie4.cxx +++ b/sc/source/ui/view/drawvie4.cxx @@ -136,7 +136,7 @@ void ScDrawView::BeginDrag( vcl::Window* pWindow, const Point& rStartPos ) namespace { -void getRangeFromDataSource( uno::Reference< chart2::data::XDataSource > xDataSource, std::vector& rRangeRep) +void getRangeFromDataSource( uno::Reference< chart2::data::XDataSource > const & xDataSource, std::vector& rRangeRep) { uno::Sequence > xSeqs = xDataSource->getDataSequences(); for (sal_Int32 i = 0, n = xSeqs.getLength(); i < n; ++i) diff --git a/sc/source/ui/view/spelleng.cxx b/sc/source/ui/view/spelleng.cxx index ffb20f53a761..93767c6755dd 100644 --- a/sc/source/ui/view/spelleng.cxx +++ b/sc/source/ui/view/spelleng.cxx @@ -277,7 +277,7 @@ void ScConversionEngineBase::FillFromCell( SCCOL nCol, SCROW nRow, SCTAB nTab ) ScSpellingEngine::ScSpellingEngine( SfxItemPool* pEnginePoolP, ScViewData& rViewData, ScDocument* pUndoDoc, ScDocument* pRedoDoc, - css::uno::Reference< css::linguistic2::XSpellChecker1 > xSpeller ) : + css::uno::Reference< css::linguistic2::XSpellChecker1 > const & xSpeller ) : ScConversionEngineBase( pEnginePoolP, rViewData, pUndoDoc, pRedoDoc ) { SetSpeller( xSpeller ); -- cgit