From cbea6a709f33babfb490ab1bd07cde8cc08114ac Mon Sep 17 00:00:00 2001 From: Caolán McNamara Date: Wed, 22 Jul 2015 13:51:19 +0100 Subject: xstUsrInitl contains max 9 chars Change-Id: Ia40d037d7af6cd3a283aa12948e4c5565dcb2ae6 --- sw/qa/core/data/ww8/pass/crash-1.doc | Bin 0 -> 10240 bytes sw/source/filter/ww8/ww8par.cxx | 11 +++++++---- 2 files changed, 7 insertions(+), 4 deletions(-) create mode 100644 sw/qa/core/data/ww8/pass/crash-1.doc diff --git a/sw/qa/core/data/ww8/pass/crash-1.doc b/sw/qa/core/data/ww8/pass/crash-1.doc new file mode 100644 index 000000000000..9f6b25348c64 Binary files /dev/null and b/sw/qa/core/data/ww8/pass/crash-1.doc differ diff --git a/sw/source/filter/ww8/ww8par.cxx b/sw/source/filter/ww8/ww8par.cxx index 4d82b50b72aa..02d26f4cbf9d 100644 --- a/sw/source/filter/ww8/ww8par.cxx +++ b/sw/source/filter/ww8/ww8par.cxx @@ -2170,15 +2170,18 @@ long SwWW8ImplReader::Read_And(WW8PLCFManResult* pRes) if (pA) sAuthor = *pA; else - sAuthor = OUString(pDescri->xstUsrInitl + 1, pDescri->xstUsrInitl[0], - RTL_TEXTENCODING_MS_1252); + { + const sal_uInt8 nLen = std::min(pDescri->xstUsrInitl[0], + SAL_N_ELEMENTS(pDescri->xstUsrInitl)-1); + sAuthor = OUString(pDescri->xstUsrInitl + 1, nLen, RTL_TEXTENCODING_MS_1252); + } } else { const WW8_ATRD* pDescri = static_cast(pSD->GetData()); - { - const sal_uInt16 nLen = SVBT16ToShort(pDescri->xstUsrInitl[0]); + const sal_uInt16 nLen = std::min(SVBT16ToShort(pDescri->xstUsrInitl[0]), + SAL_N_ELEMENTS(pDescri->xstUsrInitl)-1); OUStringBuffer aBuf; aBuf.setLength(nLen); for(sal_uInt16 nIdx = 1; nIdx <= nLen; ++nIdx) -- cgit