From cdbb588dce1448eeb5d099e24eae781cbba4578f Mon Sep 17 00:00:00 2001 From: Andras Timar Date: Fri, 7 Feb 2025 14:27:59 +0100 Subject: Respect document specific settings – cool#11103 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The purpose of this CheckConfigOptions function is to reset formula separators, when there is a clash with decimal separator. However, ignoring other settings that are coming from the document can cause issues, like that we saw with LOKit, where StringRefAddressSyntax of a German XLSX document was reset to default CONV_UNSPECIFIED, and function =INDIREKT("Sheet1!A1") which was according to CONV_XL_A1 stopped working, and gave error #BEZUG (#REF). Change-Id: I7693deed436ad4e54569a21cc3faeaafceeb459c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181250 Tested-by: Jenkins CollaboraOffice Reviewed-by: Andras Timar --- sc/source/ui/docshell/docsh6.cxx | 1 + 1 file changed, 1 insertion(+) diff --git a/sc/source/ui/docshell/docsh6.cxx b/sc/source/ui/docshell/docsh6.cxx index 0e147f14c3fe..d9ab7e78354b 100644 --- a/sc/source/ui/docshell/docsh6.cxx +++ b/sc/source/ui/docshell/docsh6.cxx @@ -491,6 +491,7 @@ void ScDocShell::CheckConfigOptions() // One of arg separators conflicts with the current decimal // separator. Reset them to default. ScFormulaOptions aNew = rOpt; + aNew.GetCalcConfig().MergeDocumentSpecific(m_pDocument->GetCalcConfig()); aNew.ResetFormulaSeparators(); SetFormulaOptions(aNew); pScMod->SetFormulaOptions(aNew); -- cgit