From d261d883b2149b37bdee739ee92bbea11b1fb7a1 Mon Sep 17 00:00:00 2001 From: Gabor Kelemen Date: Thu, 21 Feb 2019 07:30:53 +0100 Subject: tdf#42949 Fix IWYU warnings in sd/source/filter/*/*cxx Also a few hxx files had missing headers and obsolete fw decls Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I9a35c566d30678af445da3fec9570af235afb353 Reviewed-on: https://gerrit.libreoffice.org/68131 Tested-by: Jenkins Reviewed-by: Miklos Vajna --- include/filter/msfilter/svdfppt.hxx | 1 + sd/IwyuFilter_sd.yaml | 19 ++++++++++++ sd/inc/animations.hxx | 4 +++ sd/source/filter/cgm/sdcgmfilter.cxx | 3 -- sd/source/filter/eppt/eppt.cxx | 16 +--------- sd/source/filter/eppt/epptooxml.hxx | 11 +------ sd/source/filter/eppt/epptso.cxx | 46 +++++---------------------- sd/source/filter/eppt/pptexanimations.cxx | 8 ++--- sd/source/filter/eppt/pptx-animations.cxx | 4 --- sd/source/filter/eppt/pptx-epptbase.cxx | 37 +++------------------- sd/source/filter/eppt/pptx-epptooxml.cxx | 14 --------- sd/source/filter/eppt/pptx-text.cxx | 4 +-- sd/source/filter/grf/sdgrffilter.cxx | 23 -------------- sd/source/filter/html/HtmlOptionsDialog.cxx | 9 ------ sd/source/filter/html/htmlattr.cxx | 1 - sd/source/filter/html/htmlex.cxx | 17 ---------- sd/source/filter/html/pubdlg.cxx | 12 ++------ sd/source/filter/html/sdhtmlfilter.cxx | 13 -------- sd/source/filter/pdf/sdpdffilter.cxx | 48 ----------------------------- sd/source/filter/ppt/ppt97animations.cxx | 3 -- sd/source/filter/ppt/pptin.cxx | 24 ++------------- sd/source/filter/ppt/pptinanimations.cxx | 6 ---- sd/source/filter/ppt/pptinanimations.hxx | 5 ++- sd/source/filter/sdfilter.cxx | 8 ++--- sd/source/filter/sdpptwrp.cxx | 7 +---- sd/source/filter/xml/sdtransform.cxx | 3 -- sd/source/filter/xml/sdxmlwrp.cxx | 9 ------ 27 files changed, 53 insertions(+), 302 deletions(-) diff --git a/include/filter/msfilter/svdfppt.hxx b/include/filter/msfilter/svdfppt.hxx index 59fa807c35ff..78fbeecee368 100644 --- a/include/filter/msfilter/svdfppt.hxx +++ b/include/filter/msfilter/svdfppt.hxx @@ -34,6 +34,7 @@ #include #include #include +#include #include #include #include diff --git a/sd/IwyuFilter_sd.yaml b/sd/IwyuFilter_sd.yaml index 5a3bd62b3d8c..ee20735d14da 100644 --- a/sd/IwyuFilter_sd.yaml +++ b/sd/IwyuFilter_sd.yaml @@ -381,3 +381,22 @@ blacklist: sd/source/core/text/textapi.cxx: # Needed for macro defines - editeng/unoprnms.hxx + sd/source/filter/eppt/epptso.cxx: + # Needed for direct member access + - com/sun/star/table/XTable.hpp + sd/source/filter/eppt/pptx-epptooxml.cxx: + # Needed for direct member access + - com/sun/star/task/XStatusIndicator.hpp + - com/sun/star/frame/XModel.hpp + sd/source/filter/eppt/pptx-text.cxx: + # Needed for direct member access + - com/sun/star/awt/XBitmap.hpp + - com/sun/star/beans/XPropertyState.hpp + - com/sun/star/style/TabStop.hpp + - com/sun/star/graphic/XGraphic.hpp + sd/source/filter/xml/sdxmlwrp.cxx: + # Needed for implicit dtor + - editeng/outlobj.hxx + sd/source/filter/xml/sdtransform.cxx: + # Needed for implicit dtor + - editeng/outlobj.hxx diff --git a/sd/inc/animations.hxx b/sd/inc/animations.hxx index 9d9505c5f0e0..f5f8abf95917 100644 --- a/sd/inc/animations.hxx +++ b/sd/inc/animations.hxx @@ -22,6 +22,10 @@ #include "sddllapi.h" +#include + +namespace com::sun::star::animations { class XAnimationNode; } + namespace sd { diff --git a/sd/source/filter/cgm/sdcgmfilter.cxx b/sd/source/filter/cgm/sdcgmfilter.cxx index c8841c42fdb5..80b11519d45a 100644 --- a/sd/source/filter/cgm/sdcgmfilter.cxx +++ b/sd/source/filter/cgm/sdcgmfilter.cxx @@ -18,12 +18,9 @@ */ #include -#include #include #include -#include #include -#include #include #include diff --git a/sd/source/filter/eppt/eppt.cxx b/sd/source/filter/eppt/eppt.cxx index a953c2bc8910..7a378baa3bbf 100644 --- a/sd/source/filter/eppt/eppt.cxx +++ b/sd/source/filter/eppt/eppt.cxx @@ -22,21 +22,11 @@ #include "pptexanimations.hxx" #include #include -#include -#include -#include -#include #include #include -#include -#include #include #include #include -#include -#include -#include -#include #include #include #include @@ -49,12 +39,8 @@ #include #include #include -#include -#include #include #include -#include -#include #include #include #include @@ -64,7 +50,7 @@ #include #include -#include +class SfxObjectShell; // complete SfxObjectShell for SaveVBA under -fsanitize=function using namespace com::sun::star; diff --git a/sd/source/filter/eppt/epptooxml.hxx b/sd/source/filter/eppt/epptooxml.hxx index 52289a48b11f..5d6be2286af9 100644 --- a/sd/source/filter/eppt/epptooxml.hxx +++ b/sd/source/filter/eppt/epptooxml.hxx @@ -27,17 +27,8 @@ using ::sax_fastparser::FSHelperPtr; -namespace com { namespace sun { namespace star { - namespace animations { - class XAnimate; - class XAnimationNode; - } -}}} - namespace oox { - namespace drawingml { - class ShapeExport; - } + namespace core { struct LayoutInfo diff --git a/sd/source/filter/eppt/epptso.cxx b/sd/source/filter/eppt/epptso.cxx index 17692924be74..7d6ee3090263 100644 --- a/sd/source/filter/eppt/epptso.cxx +++ b/sd/source/filter/eppt/epptso.cxx @@ -20,68 +20,38 @@ #include #include -#include - #include #include -#include #include "eppt.hxx" #include "text.hxx" #include "epptdef.hxx" #include "escherex.hxx" #include -#include -#include -#include #include +#include #include -#include -#include #include -#include -#include #include +#include #include -#include -#include -#include -#include -#include -#include #include #include -#include -#include -#include -#include -#include +#include +#include #include #include -#include -#include -#include -#include -#include +#include #include #include -#include -#include -#include -#include -#include #include -#include #include -#include -#include -#include #include -#include -#include +#include #include #include #include -#include +#include +#include #include #include diff --git a/sd/source/filter/eppt/pptexanimations.cxx b/sd/source/filter/eppt/pptexanimations.cxx index bf9c12891a39..cf2ed32f21f2 100644 --- a/sd/source/filter/eppt/pptexanimations.cxx +++ b/sd/source/filter/eppt/pptexanimations.cxx @@ -49,18 +49,14 @@ #include #include #include -#include -#include #include -#include -#include -#include #include "pptexanimations.hxx" #include "pptexsoundcollection.hxx" #include "../ppt/pptanimations.hxx" #include -#include +#include +#include #include diff --git a/sd/source/filter/eppt/pptx-animations.cxx b/sd/source/filter/eppt/pptx-animations.cxx index 65125b98e2e3..23a2ba7c2378 100644 --- a/sd/source/filter/eppt/pptx-animations.cxx +++ b/sd/source/filter/eppt/pptx-animations.cxx @@ -18,11 +18,9 @@ */ #include -#include #include #include "epptooxml.hxx" #include -#include #include #include @@ -46,7 +44,6 @@ #include #include #include -#include #include #include #include @@ -54,7 +51,6 @@ #include #include #include -#include #include #include #include diff --git a/sd/source/filter/eppt/pptx-epptbase.cxx b/sd/source/filter/eppt/pptx-epptbase.cxx index e63c90884e7e..da99752ae3d5 100644 --- a/sd/source/filter/eppt/pptx-epptbase.cxx +++ b/sd/source/filter/eppt/pptx-epptbase.cxx @@ -17,44 +17,21 @@ * the License at http://www.apache.org/licenses/LICENSE-2.0 . */ -#include "eppt.hxx" +#include "epptbase.hxx" #include "epptdef.hxx" -#include "pptexanimations.hxx" #include "../ppt/pptanimations.hxx" #include -#include -#include -#include -#include -#include -#include -#include -#include +#include #include #include #include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include +#include +#include #include #include #include #include -#include -#include -#include -#include -#include #include #include #include @@ -66,12 +43,6 @@ #include #include #include -#include -#include -#include -#include -#include -#include using namespace com::sun::star; diff --git a/sd/source/filter/eppt/pptx-epptooxml.cxx b/sd/source/filter/eppt/pptx-epptooxml.cxx index ee6fb0b81569..cdec562c51ba 100644 --- a/sd/source/filter/eppt/pptx-epptooxml.cxx +++ b/sd/source/filter/eppt/pptx-epptooxml.cxx @@ -18,33 +18,23 @@ */ #include -#include -#include #include #include #include #include #include #include "epptooxml.hxx" -#include "epptdef.hxx" #include #include #include -#include -#include #include #include #include -#include -#include #include #include -#include #include -#include #include -#include #include #include #include @@ -58,14 +48,10 @@ #include #include -#include -#include -#include "pptexanimations.hxx" #include "pptx-animations.hxx" #include "../ppt/pptanimations.hxx" -#include #include #include #include diff --git a/sd/source/filter/eppt/pptx-text.cxx b/sd/source/filter/eppt/pptx-text.cxx index e3fb70e4b6a1..3b858a6dc556 100644 --- a/sd/source/filter/eppt/pptx-text.cxx +++ b/sd/source/filter/eppt/pptx-text.cxx @@ -46,16 +46,14 @@ #include #include #include -#include #include -#include #include #include #include #include -#include #include +#include using namespace css; diff --git a/sd/source/filter/grf/sdgrffilter.cxx b/sd/source/filter/grf/sdgrffilter.cxx index b643f883ae16..7da570315bbb 100644 --- a/sd/source/filter/grf/sdgrffilter.cxx +++ b/sd/source/filter/grf/sdgrffilter.cxx @@ -18,37 +18,20 @@ */ #include -#include -#include -#include -#include -#include -#include #include #include -#include -#include #include #include #include -#include #include -#include #include #include #include -#include -#include - -#include #include -#include -#include #include -#include #include #include @@ -57,15 +40,9 @@ #include #include #include -#include #include -#include -#include #include -#include -#include #include -#include #include #include #include diff --git a/sd/source/filter/html/HtmlOptionsDialog.cxx b/sd/source/filter/html/HtmlOptionsDialog.cxx index 092554f0e58c..9135e4016732 100644 --- a/sd/source/filter/html/HtmlOptionsDialog.cxx +++ b/sd/source/filter/html/HtmlOptionsDialog.cxx @@ -17,11 +17,6 @@ * the License at http://www.apache.org/licenses/LICENSE-2.0 . */ -#include -#include -#include -#include -#include #include #include #include @@ -34,18 +29,14 @@ #include #include -#include - using namespace com::sun::star::uno; using namespace com::sun::star::lang; using namespace com::sun::star::document; using namespace com::sun::star::beans; -using namespace com::sun::star::container; using namespace com::sun::star::ui::dialogs; #include #include -#include class SdHtmlOptionsDialog : public cppu::WeakImplHelper < diff --git a/sd/source/filter/html/htmlattr.cxx b/sd/source/filter/html/htmlattr.cxx index b40313b614ff..686a35666c12 100644 --- a/sd/source/filter/html/htmlattr.cxx +++ b/sd/source/filter/html/htmlattr.cxx @@ -18,7 +18,6 @@ */ #include "htmlattr.hxx" -#include "htmlex.hxx" #include #include #include diff --git a/sd/source/filter/html/htmlex.cxx b/sd/source/filter/html/htmlex.cxx index 94d55a5e79b5..55b2c1820979 100644 --- a/sd/source/filter/html/htmlex.cxx +++ b/sd/source/filter/html/htmlex.cxx @@ -19,30 +19,20 @@ #include "htmlex.hxx" #include -#include -#include #include #include -#include #include #include #include #include #include -#include #include #include -#include -#include -#include -#include #include #include #include #include -#include -#include #include #include #include @@ -50,11 +40,8 @@ #include #include #include -#include #include -#include #include -#include #include #include #include @@ -68,10 +55,7 @@ #include #include #include -#include #include -#include -#include #include #include #include @@ -82,7 +66,6 @@ #include "htmlpublishmode.hxx" #include #include -#include #include #include #include diff --git a/sd/source/filter/html/pubdlg.cxx b/sd/source/filter/html/pubdlg.cxx index 4ceea567d0af..3cbc42135894 100644 --- a/sd/source/filter/html/pubdlg.cxx +++ b/sd/source/filter/html/pubdlg.cxx @@ -24,28 +24,20 @@ #include #include #include -#include -#include -#include -#include -#include +#include #include #include -#include -#include #include -#include +#include #include #include #include -#include #include #include #include #include #include -#include #include #include "htmlattr.hxx" #include "htmlex.hxx" diff --git a/sd/source/filter/html/sdhtmlfilter.cxx b/sd/source/filter/html/sdhtmlfilter.cxx index 670980d45ce0..a722d1c53d53 100644 --- a/sd/source/filter/html/sdhtmlfilter.cxx +++ b/sd/source/filter/html/sdhtmlfilter.cxx @@ -17,23 +17,10 @@ * the License at http://www.apache.org/licenses/LICENSE-2.0 . */ -#include -#include -#include -#include -#include #include -#include #include #include -#include -#include -#include -#include -#include -#include -#include #include "htmlex.hxx" #include diff --git a/sd/source/filter/pdf/sdpdffilter.cxx b/sd/source/filter/pdf/sdpdffilter.cxx index db7af07b58ce..8474410f0b15 100644 --- a/sd/source/filter/pdf/sdpdffilter.cxx +++ b/sd/source/filter/pdf/sdpdffilter.cxx @@ -17,59 +17,12 @@ * the License at http://www.apache.org/licenses/LICENSE-2.0 . */ -#include -#include -#include -#include -#include -#include - -#include -#include -#include -#include -#include -#include #include -#include -#include #include -#include - -#include -#include -#include -#include -#include - -#include -#include - -#include -#include -#include -#include -#include #include #include -#include #include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include #include #include @@ -82,7 +35,6 @@ using namespace ::com::sun::star::beans; using namespace ::com::sun::star::graphic; using namespace ::com::sun::star::io; using namespace ::com::sun::star::ucb; -using namespace com::sun::star::ui::dialogs; using namespace ::sfx2; SdPdfFilter::SdPdfFilter(SfxMedium& rMedium, ::sd::DrawDocShell& rDocShell) diff --git a/sd/source/filter/ppt/ppt97animations.cxx b/sd/source/filter/ppt/ppt97animations.cxx index 6b65319ba2f3..c2ec7c1bb4b6 100644 --- a/sd/source/filter/ppt/ppt97animations.cxx +++ b/sd/source/filter/ppt/ppt97animations.cxx @@ -21,13 +21,10 @@ #include #include -#include #include #include #include -#include #include -#include #include #include #include diff --git a/sd/source/filter/ppt/pptin.cxx b/sd/source/filter/ppt/pptin.cxx index 161137e2d143..957f052925c7 100644 --- a/sd/source/filter/ppt/pptin.cxx +++ b/sd/source/filter/ppt/pptin.cxx @@ -17,42 +17,27 @@ * the License at http://www.apache.org/licenses/LICENSE-2.0 . */ -#include #include #include #include #include -#include #include #include #include #include #include -#include #include #include #include -#include #include -#include -#include -#include -#include -#include -#include -#include #include -#include -#include -#include -#include +#include #include #include #include #include "pptin.hxx" -#include #include #include #include @@ -61,8 +46,6 @@ #include #include #include -#include -#include #include #include #include @@ -75,17 +58,15 @@ #include #include -#include #include #include #include #include #include -#include + #define MAX_USER_MOVE 2 -#include #include "pptanimations.hxx" #include "pptinanimations.hxx" #include "ppt97animations.hxx" @@ -98,7 +79,6 @@ #include #include -#include #include diff --git a/sd/source/filter/ppt/pptinanimations.cxx b/sd/source/filter/ppt/pptinanimations.cxx index 6b7c253291fa..e4f0db29015d 100644 --- a/sd/source/filter/ppt/pptinanimations.cxx +++ b/sd/source/filter/ppt/pptinanimations.cxx @@ -46,11 +46,6 @@ #include #include #include -#include -#include -#include -#include -#include #include #include #include @@ -60,7 +55,6 @@ #include #include -#include #include #include #include diff --git a/sd/source/filter/ppt/pptinanimations.hxx b/sd/source/filter/ppt/pptinanimations.hxx index beac67618acc..7964304c1abb 100644 --- a/sd/source/filter/ppt/pptinanimations.hxx +++ b/sd/source/filter/ppt/pptinanimations.hxx @@ -20,7 +20,10 @@ #ifndef INCLUDED_SD_SOURCE_FILTER_PPT_PPTINANIMATIONS_HXX #define INCLUDED_SD_SOURCE_FILTER_PPT_PPTINANIMATIONS_HXX -#include +#include + +#include +#include #ifdef DBG_ANIM_LOG #include diff --git a/sd/source/filter/sdfilter.cxx b/sd/source/filter/sdfilter.cxx index fbffe2cf5ed9..abed23b79780 100644 --- a/sd/source/filter/sdfilter.cxx +++ b/sd/source/filter/sdfilter.cxx @@ -17,21 +17,19 @@ * the License at http://www.apache.org/licenses/LICENSE-2.0 . */ -#include - #include +#include #include #include #include -#include -#include +#include +#include #include #include #include -#include #include diff --git a/sd/source/filter/sdpptwrp.cxx b/sd/source/filter/sdpptwrp.cxx index feb9adaa15c9..edc21c482d45 100644 --- a/sd/source/filter/sdpptwrp.cxx +++ b/sd/source/filter/sdpptwrp.cxx @@ -19,18 +19,13 @@ #include #include -#include -#include #include -#include #include #include +#include #include -#include "ppt/pptin.hxx" -#include #include -#include using namespace ::com::sun::star::uno; diff --git a/sd/source/filter/xml/sdtransform.cxx b/sd/source/filter/xml/sdtransform.cxx index 6ede79796b5b..fa0cced78971 100644 --- a/sd/source/filter/xml/sdtransform.cxx +++ b/sd/source/filter/xml/sdtransform.cxx @@ -19,7 +19,6 @@ #include #include -#include #include #include @@ -28,11 +27,9 @@ #include #include #include -#include #include #include -#include #include "sdtransform.hxx" using namespace ::com::sun::star::style; diff --git a/sd/source/filter/xml/sdxmlwrp.cxx b/sd/source/filter/xml/sdxmlwrp.cxx index 91591779e4cf..6c038cb5dac6 100644 --- a/sd/source/filter/xml/sdxmlwrp.cxx +++ b/sd/source/filter/xml/sdxmlwrp.cxx @@ -18,7 +18,6 @@ */ #include -#include #include #include #include @@ -42,7 +41,6 @@ #include #include -#include #include #include #include @@ -51,21 +49,14 @@ #include #include #include -#include -#include #include -#include #include #include -#include -#include #include -#include #include #include #include -#include #include #include #include -- cgit