From d7d09fd881ff56ea1a7b6863cafb298387f20f98 Mon Sep 17 00:00:00 2001 From: Caolán McNamara Date: Fri, 7 Aug 2020 09:47:21 +0100 Subject: cid#1465673 Unchecked return value MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Change-Id: I6213d9c0f0450b5e600553c18deb5fbef3a05230 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100295 Tested-by: Jenkins Reviewed-by: Caolán McNamara --- dbaccess/source/ui/querydesign/ConnectionLine.cxx | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/dbaccess/source/ui/querydesign/ConnectionLine.cxx b/dbaccess/source/ui/querydesign/ConnectionLine.cxx index 791f89247a52..5411e22e9457 100644 --- a/dbaccess/source/ui/querydesign/ConnectionLine.cxx +++ b/dbaccess/source/ui/querydesign/ConnectionLine.cxx @@ -82,13 +82,20 @@ namespace { const OTableWindowListBox* pListBox = _pWin->GetListBox(); _rNewConPos.setY( _pWin->GetPosPixel().Y() ); + + std::unique_ptr xEntry; + const weld::TreeView& rTreeView = pListBox->get_widget(); + if (_nEntry != -1) { _rNewConPos.AdjustY(pListBox->GetPosPixel().Y() ); - const weld::TreeView& rTreeView = pListBox->get_widget(); - std::unique_ptr xEntry = rTreeView.make_iterator(); - rTreeView.get_iter_first(*xEntry); - rTreeView.iter_nth_sibling(*xEntry, _nEntry); + xEntry = rTreeView.make_iterator(); + if (!rTreeView.get_iter_first(*xEntry) || !rTreeView.iter_nth_sibling(*xEntry, _nEntry)) + xEntry.reset(); + } + + if (xEntry) + { auto nEntryPos = rTreeView.get_row_area(*xEntry).Center().Y(); if( nEntryPos >= 0 ) -- cgit