From e7f96e960cd0e0fe0c25662920bd34b096aad398 Mon Sep 17 00:00:00 2001 From: kubak Date: Wed, 24 Apr 2024 12:21:59 +0200 Subject: MSI: Fix use of illegal character "@" ICE03 ERROR Invalid identifier; Example: flt14.mo gid_file_res_flt_lang__libreoffice_program_resource_ca@valen_dcb80460e flt.mo 55482 2051 16384 13967 We use the illegal "@" sign. Changing to underscore "_". https: //learn.microsoft.com/en-us/windows/win32/msi/identifier Change-Id: I50c40a3cde3f4b57b71ddda9876f27db08aa0970 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166580 Tested-by: Jenkins Reviewed-by: Mike Kaganski --- solenv/bin/modules/installer/windows/file.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/solenv/bin/modules/installer/windows/file.pm b/solenv/bin/modules/installer/windows/file.pm index 9c5e76c52643..a4184ff112fa 100644 --- a/solenv/bin/modules/installer/windows/file.pm +++ b/solenv/bin/modules/installer/windows/file.pm @@ -248,7 +248,8 @@ sub get_file_component_name $componentname = lc($componentname); # componentnames always lowercase $componentname =~ s/\-/\_/g; # converting "-" to "_" - $componentname =~ s/\./\_/g; # converting "-" to "_" + $componentname =~ s/\./\_/g; # converting "." to "_" + $componentname =~ s/\@/\_/g; # converting "@" to "_" # Attention: Maximum length for the componentname is 72 # %installer::globals::allcomponents_in_this_database : reset for each database -- cgit