From ed8a337cf6d13eda49d394558d83766131f83e54 Mon Sep 17 00:00:00 2001 From: Kohei Yoshida Date: Thu, 16 Mar 2017 18:55:42 -0400 Subject: tdf#104383: prevent crash during file load. Apparently xView may be null sometimes. Change-Id: Icef81159eeaf5c9bdb0a91e036019b820952d20b Reviewed-on: https://gerrit.libreoffice.org/35304 Tested-by: Jenkins Reviewed-by: Kohei Yoshida --- sc/source/ui/vba/vbarange.cxx | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/sc/source/ui/vba/vbarange.cxx b/sc/source/ui/vba/vbarange.cxx index 2eb8a4588c88..6a35cd4ece88 100644 --- a/sc/source/ui/vba/vbarange.cxx +++ b/sc/source/ui/vba/vbarange.cxx @@ -4233,8 +4233,20 @@ ScVbaRange::ApplicationRange( const uno::Reference< uno::XComponentContext >& xC } } - uno::Reference< sheet::XSpreadsheetView > xView( getCurrentExcelDoc(xContext)->getCurrentController(), uno::UNO_QUERY ); - uno::Reference< table::XCellRange > xSheetRange( xView->getActiveSheet(), uno::UNO_QUERY_THROW ); + uno::Reference xSheetRange; + + try + { + uno::Reference xView( + getCurrentExcelDoc(xContext)->getCurrentController(), uno::UNO_QUERY_THROW); + + xSheetRange.set(xView->getActiveSheet(), uno::UNO_QUERY_THROW); + } + catch (const uno::Exception&) + { + return uno::Reference(); + } + ScVbaRange* pRange = new ScVbaRange( excel::getUnoSheetModuleObj( xSheetRange ), xContext, xSheetRange ); uno::Reference< excel::XRange > xVbSheetRange( pRange ); return pRange->Range( Cell1, Cell2, true ); -- cgit