From edd0d35590fc368c6c06a9bb5c108aacbc742371 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Thu, 26 Apr 2018 16:07:46 +0200 Subject: loplugin:countusersofdefaultparams Change-Id: I84868b3115c534a8240394283cc3beedf8cb3a80 Reviewed-on: https://gerrit.libreoffice.org/53543 Tested-by: Jenkins Reviewed-by: Noel Grandin --- basctl/source/basicide/basdoc.hxx | 2 +- compilerplugins/clang/test/sallogareas.cxx | 8 -------- connectivity/source/drivers/macab/MacabDriver.cxx | 2 +- cui/source/inc/CommandCategoryListBox.hxx | 6 +++--- cui/source/inc/cfgutil.hxx | 2 +- cui/source/inc/cuicharmap.hxx | 2 +- include/filter/msfilter/msdffimp.hxx | 2 +- include/sfx2/objsh.hxx | 2 +- include/svl/itemset.hxx | 2 +- include/svl/zforlist.hxx | 2 +- include/svtools/htmlout.hxx | 2 +- include/svx/hlnkitem.hxx | 2 +- include/svx/svdhdl.hxx | 2 +- include/svx/svdmodel.hxx | 2 +- include/svx/svdpage.hxx | 2 +- include/tools/diagnose_ex.h | 2 +- include/vcl/GraphicObject.hxx | 2 +- include/vcl/bitmap.hxx | 2 +- include/vcl/floatwin.hxx | 2 +- sc/inc/filter.hxx | 2 +- sc/inc/rangeutl.hxx | 2 +- sc/inc/scabstdlg.hxx | 2 +- sc/source/core/data/table3.cxx | 4 ++-- sc/source/filter/inc/ftools.hxx | 2 +- sc/source/ui/attrdlg/scdlgfact.hxx | 2 +- sc/source/ui/inc/csvtablebox.hxx | 2 +- sc/source/ui/inc/docsh.hxx | 3 +-- sc/source/ui/inc/impex.hxx | 2 +- sc/source/ui/inc/tabvwsh.hxx | 4 ++-- sd/inc/drawdoc.hxx | 2 +- sd/source/ui/inc/DrawDocShell.hxx | 2 +- sd/workben/custompanel/ctp_panel.cxx | 8 ++++---- sfx2/source/notebookbar/NotebookbarPopup.hxx | 2 +- slideshow/source/engine/shapes/viewshape.cxx | 2 +- starmath/inc/document.hxx | 2 +- store/source/storbase.hxx | 2 +- sw/inc/crsrsh.hxx | 2 +- sw/inc/docsh.hxx | 2 +- sw/inc/docufld.hxx | 2 +- sw/inc/pam.hxx | 6 +++--- sw/inc/swcrsr.hxx | 4 ++-- sw/source/core/undo/untbl.cxx | 2 +- sw/source/filter/html/svxcss1.hxx | 2 +- sw/source/filter/html/wrthtml.hxx | 2 +- sw/source/filter/ww8/ww8scan.hxx | 2 +- sw/source/uibase/inc/frmdlg.hxx | 2 +- sw/source/uibase/inc/wrtsh.hxx | 2 +- toolkit/inc/helper/btndlg.hxx | 2 +- vcl/inc/messagedialog.hxx | 5 ++--- writerfilter/source/dmapper/DomainMapper_Impl.hxx | 2 +- 50 files changed, 60 insertions(+), 70 deletions(-) diff --git a/basctl/source/basicide/basdoc.hxx b/basctl/source/basicide/basdoc.hxx index be56f09e588f..6fbc64836e3c 100644 --- a/basctl/source/basicide/basdoc.hxx +++ b/basctl/source/basicide/basdoc.hxx @@ -35,7 +35,7 @@ class DocShell: public SfxObjectShell protected: virtual void Draw( OutputDevice *, const JobSetup & rSetup, - sal_uInt16 nAspect = ASPECT_CONTENT ) override; + sal_uInt16 nAspect ) override; virtual void FillClass( SvGlobalName * pClassName, SotClipboardFormatId * pFormat, OUString * pAppName, diff --git a/compilerplugins/clang/test/sallogareas.cxx b/compilerplugins/clang/test/sallogareas.cxx index eb3f1a70fa2f..e3a58be70be6 100644 --- a/compilerplugins/clang/test/sallogareas.cxx +++ b/compilerplugins/clang/test/sallogareas.cxx @@ -45,14 +45,6 @@ int main() { DBG_UNHANDLED_EXCEPTION("xmloff"); } - try - { - func1(); - } - catch (std::exception const&) - { - DBG_UNHANDLED_EXCEPTION(); // expected-error {{missing log area [loplugin:sallogareas]}} - } } /* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */ diff --git a/connectivity/source/drivers/macab/MacabDriver.cxx b/connectivity/source/drivers/macab/MacabDriver.cxx index 076d6072be97..855b78d2fe92 100644 --- a/connectivity/source/drivers/macab/MacabDriver.cxx +++ b/connectivity/source/drivers/macab/MacabDriver.cxx @@ -193,7 +193,7 @@ MacabDriver::MacabDriver( } catch( const Exception& ) { - DBG_UNHANDLED_EXCEPTION(); + DBG_UNHANDLED_EXCEPTION("connectivity.macab"); } osl_atomic_decrement( &m_refCount ); } diff --git a/cui/source/inc/CommandCategoryListBox.hxx b/cui/source/inc/CommandCategoryListBox.hxx index 779189ed39f5..8d85169ed0d5 100644 --- a/cui/source/inc/CommandCategoryListBox.hxx +++ b/cui/source/inc/CommandCategoryListBox.hxx @@ -53,7 +53,7 @@ public: const css::uno::Sequence< css::frame::DispatchInformation >& xCommands, const VclPtr& pFunctionListBox, const OUString& filterTerm, - SaveInData *pCurrentSaveInData = nullptr ); + SaveInData *pCurrentSaveInData ); OUString MapCommand2UIName(const OUString& sCommand); /** @@ -62,14 +62,14 @@ public: the commands in the selected category. */ void categorySelected( const VclPtr& pFunctionListBox, - const OUString& filterTerm = OUString(), SaveInData* pCurrentSaveInData = nullptr ); + const OUString& filterTerm, SaveInData* pCurrentSaveInData = nullptr ); void SetStylesInfo(SfxStylesInfo_Impl* pStyles); // Adds children of the given macro group to the functions list void addChildren( SvTreeListEntry* parentEntry, const css::uno::Reference &parentNode, - const VclPtr &pFunctionListBox, const OUString &filterTerm , SaveInData *pCurrentSaveInData = nullptr ); + const VclPtr &pFunctionListBox, const OUString &filterTerm , SaveInData *pCurrentSaveInData ); }; #endif // INCLUDED_CUI_SOURCE_INC_COMMANDCATEGORYLISTBOX_HXX diff --git a/cui/source/inc/cfgutil.hxx b/cui/source/inc/cfgutil.hxx index 4a97e63c608b..a1f4a2971314 100644 --- a/cui/source/inc/cfgutil.hxx +++ b/cui/source/inc/cfgutil.hxx @@ -201,7 +201,7 @@ public: SvxScriptSelectorDialog ( vcl::Window* pParent, bool bShowSlots, - const css::uno::Reference< css::frame::XFrame >& xFrame = nullptr + const css::uno::Reference< css::frame::XFrame >& xFrame ); virtual ~SvxScriptSelectorDialog() override; virtual void dispose() override; diff --git a/cui/source/inc/cuicharmap.hxx b/cui/source/inc/cuicharmap.hxx index 74928b37a83e..db77b34ec3cb 100644 --- a/cui/source/inc/cuicharmap.hxx +++ b/cui/source/inc/cuicharmap.hxx @@ -136,7 +136,7 @@ private: void selectCharByCode(Radix radix); public: - SvxCharacterMap(weld::Window* pParent, const SfxItemSet* pSet=nullptr, const bool bInsert=true); + SvxCharacterMap(weld::Window* pParent, const SfxItemSet* pSet, const bool bInsert=true); short execute(); void set_title(const OUString& rTitle) { m_xDialog->set_title(rTitle); } diff --git a/include/filter/msfilter/msdffimp.hxx b/include/filter/msfilter/msdffimp.hxx index 5c0742a39f0a..41f5ce32ae0f 100644 --- a/include/filter/msfilter/msdffimp.hxx +++ b/include/filter/msfilter/msdffimp.hxx @@ -600,7 +600,7 @@ public: SvStream* pStData, SdrModel* pSdrModel_, long nApplicationScale, - Color mnDefaultColor_ = COL_DEFAULT, + Color mnDefaultColor_, SvStream* pStData2_ = nullptr, bool bSkipImages = false ); diff --git a/include/sfx2/objsh.hxx b/include/sfx2/objsh.hxx index a749d842ac2f..d614c283f901 100644 --- a/include/sfx2/objsh.hxx +++ b/include/sfx2/objsh.hxx @@ -630,7 +630,7 @@ public: const JobSetup & rSetup, sal_uInt16 nAspect = ASPECT_CONTENT ); virtual void Draw( OutputDevice *, const JobSetup & rSetup, - sal_uInt16 nAspect = ASPECT_CONTENT ) = 0; + sal_uInt16 nAspect ) = 0; virtual void FillClass( SvGlobalName * pClassName, diff --git a/include/svl/itemset.hxx b/include/svl/itemset.hxx index 12daca908fbd..87ac1f786f13 100644 --- a/include/svl/itemset.hxx +++ b/include/svl/itemset.hxx @@ -201,7 +201,7 @@ public: bool bInvalidAsDefault = true ); void PutExtended( const SfxItemSet&, SfxItemState eDontCareAs, - SfxItemState eDefaultAs = SfxItemState::UNKNOWN ); + SfxItemState eDefaultAs ); bool Set( const SfxItemSet&, bool bDeep = true ); diff --git a/include/svl/zforlist.hxx b/include/svl/zforlist.hxx index dbc4929fef50..536d6bdf1645 100644 --- a/include/svl/zforlist.hxx +++ b/include/svl/zforlist.hxx @@ -776,7 +776,7 @@ public: returned, even if the format code only contains [$xxx] ! */ bool GetNewCurrencySymbolString( sal_uInt32 nFormat, OUString& rSymbol, - const NfCurrencyEntry** ppEntry = nullptr, + const NfCurrencyEntry** ppEntry, bool* pBank = nullptr ) const; /** Look up the corresponding NfCurrencyEntry matching diff --git a/include/svtools/htmlout.hxx b/include/svtools/htmlout.hxx index 9aaf719021f2..3d95640e29cb 100644 --- a/include/svtools/htmlout.hxx +++ b/include/svtools/htmlout.hxx @@ -72,7 +72,7 @@ struct HTMLOutFuncs bool bOutStarBasic, const sal_Char *pDelim, const sal_Char *pIndentArea, - const sal_Char *pIndentMap = nullptr, + const sal_Char *pIndentMap, rtl_TextEncoding eDestEnc = RTL_TEXTENCODING_MS_1252, OUString *pNonConvertableChars = nullptr ); SVT_DLLPUBLIC static SvStream& FlushToAscii( SvStream&, HTMLOutContext& rContext ); diff --git a/include/svx/hlnkitem.hxx b/include/svx/hlnkitem.hxx index daa3da50aabb..ad4aaf164a70 100644 --- a/include/svx/hlnkitem.hxx +++ b/include/svx/hlnkitem.hxx @@ -67,7 +67,7 @@ public: const OUString& rTarget, const OUString& rIntName, SvxLinkInsertMode eTyp, HyperDialogEvent nEvents, - SvxMacroTableDtor const *pMacroTbl =nullptr ); + SvxMacroTableDtor const *pMacroTbl ); inline SvxHyperlinkItem& operator=( const SvxHyperlinkItem &rItem ); diff --git a/include/svx/svdhdl.hxx b/include/svx/svdhdl.hxx index f738a996e409..8c719674260f 100644 --- a/include/svx/svdhdl.hxx +++ b/include/svx/svdhdl.hxx @@ -259,7 +259,7 @@ class SVX_DLLPUBLIC SdrHdlColor : public SdrHdl SVX_DLLPRIVATE static Color GetLuminance(const Color& rCol); public: - explicit SdrHdlColor(const Point& rRef, Color aCol, const Size& rSize, bool bLum = false); + explicit SdrHdlColor(const Point& rRef, Color aCol, const Size& rSize, bool bLuminance); virtual ~SdrHdlColor() override; bool IsUseLuminance() const { return bUseLuminance; } diff --git a/include/svx/svdmodel.hxx b/include/svx/svdmodel.hxx index 12636ad48543..cd49212c3584 100644 --- a/include/svx/svdmodel.hxx +++ b/include/svx/svdmodel.hxx @@ -431,7 +431,7 @@ public: virtual void Merge(SdrModel& rSourceModel, sal_uInt16 nFirstPageNum, sal_uInt16 nLastPageNum, sal_uInt16 nDestPos, - bool bMergeMasterPages, bool bAllMasterPages = false, + bool bMergeMasterPages, bool bAllMasterPages, bool bUndo = true, bool bTreadSourceAsConst = false); // Behaves like Merge(SourceModel=DestModel,nFirst,nLast,nDest,sal_False,sal_False,bUndo,!bMoveNoCopy); diff --git a/include/svx/svdpage.hxx b/include/svx/svdpage.hxx index 38a994ff9284..f6899da1a86d 100644 --- a/include/svx/svdpage.hxx +++ b/include/svx/svdpage.hxx @@ -83,7 +83,7 @@ friend class SdrEditView; protected: void RecalcRects(); - void copyDataFromSdrObjList(const SdrObjList& rSrcList, SdrModel* pNewModel = nullptr); + void copyDataFromSdrObjList(const SdrObjList& rSrcList, SdrModel* pNewModel); private: /// simple ActionChildInserted forwarder to have it on a central place diff --git a/include/tools/diagnose_ex.h b/include/tools/diagnose_ex.h index 9c18d5f51ad4..0f924fc20988 100644 --- a/include/tools/diagnose_ex.h +++ b/include/tools/diagnose_ex.h @@ -31,7 +31,7 @@ TOOLS_DLLPUBLIC void DbgUnhandledException(const css::uno::Any& caughtException, const char* currentFunction, const char* fileAndLineNo, - const char* area = nullptr, const char* explanatory = nullptr); + const char* area, const char* explanatory = nullptr); //getCaughtException throws exceptions in never-going-to-happen situations which //floods coverity with warnings diff --git a/include/vcl/GraphicObject.hxx b/include/vcl/GraphicObject.hxx index d9f60e49598d..bad14526f1d4 100644 --- a/include/vcl/GraphicObject.hxx +++ b/include/vcl/GraphicObject.hxx @@ -320,7 +320,7 @@ public: const MapMode& rDestMap, const GraphicAttr& rAttr ) const; - Graphic GetTransformedGraphic( const GraphicAttr* pAttr = nullptr ) const; // TODO: Change to Impl + Graphic GetTransformedGraphic( const GraphicAttr* pAttr ) const; // TODO: Change to Impl void SetAttr( const GraphicAttr& rAttr ); const GraphicAttr& GetAttr() const { return maAttr; } diff --git a/include/vcl/bitmap.hxx b/include/vcl/bitmap.hxx index 78aeb2292533..d0fa1a28ea34 100644 --- a/include/vcl/bitmap.hxx +++ b/include/vcl/bitmap.hxx @@ -288,7 +288,7 @@ public: @param nDitherFlags The algorithm to be used for dithering */ - bool Dither( BmpDitherFlags nDitherFlags = BmpDitherFlags::Matrix ); + bool Dither( BmpDitherFlags nDitherFlags ); /** Crop the bitmap diff --git a/include/vcl/floatwin.hxx b/include/vcl/floatwin.hxx index 5e5cfac0d3ac..60531a5478a3 100644 --- a/include/vcl/floatwin.hxx +++ b/include/vcl/floatwin.hxx @@ -149,7 +149,7 @@ public: FloatWinTitleType GetTitleType() const { return mnTitle; } void StartPopupMode( const tools::Rectangle& rRect, FloatWinPopupFlags nFlags ); - void StartPopupMode( ToolBox* pBox, FloatWinPopupFlags nFlags = FloatWinPopupFlags::NONE ); + void StartPopupMode( ToolBox* pBox, FloatWinPopupFlags nFlags ); void EndPopupMode( FloatWinPopupEndFlags nFlags = FloatWinPopupEndFlags::NONE ); void AddPopupModeWindow( vcl::Window* pWindow ); FloatWinPopupFlags GetPopupModeFlags() const { return mnPopupModeFlags; } diff --git a/sc/inc/filter.hxx b/sc/inc/filter.hxx index 0af471c6440d..11ef4398a701 100644 --- a/sc/inc/filter.hxx +++ b/sc/inc/filter.hxx @@ -69,7 +69,7 @@ class SAL_DLLPUBLIC_RTTI ScFormatFilterPlugin { const rtl_TextEncoding eSrc ) = 0; virtual ErrCode ScImportRTF( SvStream&, const OUString& rBaseURL, ScDocument*, ScRange& rRange ) = 0; virtual ErrCode ScImportHTML( SvStream&, const OUString& rBaseURL, ScDocument*, ScRange& rRange, double nOutputFactor, - bool bCalcWidthHeight, SvNumberFormatter* pFormatter, bool bConvertDate = true ) = 0; + bool bCalcWidthHeight, SvNumberFormatter* pFormatter, bool bConvertDate ) = 0; // various import helpers virtual ScEEAbsImport *CreateRTFImport( ScDocument* pDoc, const ScRange& rRange ) = 0; diff --git a/sc/inc/rangeutl.hxx b/sc/inc/rangeutl.hxx index db54bc70cab6..68c930221ca7 100644 --- a/sc/inc/rangeutl.hxx +++ b/sc/inc/rangeutl.hxx @@ -55,7 +55,7 @@ public: static bool IsAbsTabArea ( const OUString& rAreaStr, const ScDocument* pDoc, ScArea*** pppAreas, - sal_uInt16* pAreaCount = nullptr, + sal_uInt16* pAreaCount, bool bAcceptCellRef = false, ScAddress::Details const & rDetails = ScAddress::detailsOOOa1 ); diff --git a/sc/inc/scabstdlg.hxx b/sc/inc/scabstdlg.hxx index 3821a8f8f907..dc4e89043bf6 100644 --- a/sc/inc/scabstdlg.hxx +++ b/sc/inc/scabstdlg.hxx @@ -518,7 +518,7 @@ public: virtual VclPtr CreateScImportOptionsDlg ( bool bAscii, const ScImportOptions* pOptions, const OUString* pStrTitle, - bool bOnlyDbtoolsEncodings = false, + bool bOnlyDbtoolsEncodings, bool bImport = true ) = 0; virtual VclPtr CreateScAttrDlg( vcl::Window* pParent, diff --git a/sc/source/core/data/table3.cxx b/sc/source/core/data/table3.cxx index 3e94e174e8b3..51b13475abf8 100644 --- a/sc/source/core/data/table3.cxx +++ b/sc/source/core/data/table3.cxx @@ -2386,7 +2386,7 @@ public: std::pair compareByValue( const ScRefCellValue& rCell, SCCOL nCol, SCROW nRow, const ScQueryEntry& rEntry, const ScQueryEntry::Item& rItem, - const ScInterpreterContext* pContext = nullptr) + const ScInterpreterContext* pContext) { bool bOk = false; bool bTestEqual = false; @@ -2474,7 +2474,7 @@ public: std::pair compareByString( ScRefCellValue& rCell, SCROW nRow, const ScQueryEntry& rEntry, const ScQueryEntry::Item& rItem, - const ScInterpreterContext* pContext = nullptr) + const ScInterpreterContext* pContext) { bool bOk = false; bool bTestEqual = false; diff --git a/sc/source/filter/inc/ftools.hxx b/sc/source/filter/inc/ftools.hxx index 13fb359831ea..cae5241fe1e3 100644 --- a/sc/source/filter/inc/ftools.hxx +++ b/sc/source/filter/inc/ftools.hxx @@ -275,7 +275,7 @@ public: virtual ErrCode ScImportRTF( SvStream&, const OUString& rBaseURL, ScDocument*, ScRange& rRange ) override; virtual ErrCode ScImportHTML( SvStream&, const OUString& rBaseURL, ScDocument*, ScRange& rRange, double nOutputFactor, bool bCalcWidthHeight, - SvNumberFormatter* pFormatter, bool bConvertDate = true ) override; + SvNumberFormatter* pFormatter, bool bConvertDate ) override; virtual ScEEAbsImport *CreateRTFImport( ScDocument* pDoc, const ScRange& rRange ) override; virtual ScEEAbsImport *CreateHTMLImport( ScDocument* pDocP, const OUString& rBaseURL, const ScRange& rRange ) override; diff --git a/sc/source/ui/attrdlg/scdlgfact.hxx b/sc/source/ui/attrdlg/scdlgfact.hxx index 3d37a2bbdff2..3b1d5334b08b 100644 --- a/sc/source/ui/attrdlg/scdlgfact.hxx +++ b/sc/source/ui/attrdlg/scdlgfact.hxx @@ -548,7 +548,7 @@ public: virtual VclPtr CreateScImportOptionsDlg ( bool bAscii, const ScImportOptions* pOptions, const OUString* pStrTitle, - bool bOnlyDbtoolsEncodings = false, + bool bOnlyDbtoolsEncodings, bool bImport = true ) override; virtual VclPtr CreateScAttrDlg( vcl::Window* pParent, const SfxItemSet* pCellAttrs ) override; diff --git a/sc/source/ui/inc/csvtablebox.hxx b/sc/source/ui/inc/csvtablebox.hxx index 2f799f7b5aaa..b508243f26b7 100644 --- a/sc/source/ui/inc/csvtablebox.hxx +++ b/sc/source/ui/inc/csvtablebox.hxx @@ -101,7 +101,7 @@ public: /** Fills all cells of all lines with the passed texts (Unicode strings). */ void SetUniStrings( const OUString* pTextLines, const OUString& rSepChars, - sal_Unicode cTextSep, bool bMergeSep, bool bRemoveSpace = false ); + sal_Unicode cTextSep, bool bMergeSep, bool bRemoveSpace ); // column settings -------------------------------------------------------- public: diff --git a/sc/source/ui/inc/docsh.hxx b/sc/source/ui/inc/docsh.hxx index bad57292ce9e..8e1b02aeb41f 100644 --- a/sc/source/ui/inc/docsh.hxx +++ b/sc/source/ui/inc/docsh.hxx @@ -196,8 +196,7 @@ public: virtual bool DoSaveCompleted( SfxMedium * pNewStor=nullptr, bool bRegisterRecent=true ) override; // SfxObjectShell virtual bool QuerySlotExecutable( sal_uInt16 nSlotId ) override; - virtual void Draw( OutputDevice *, const JobSetup & rSetup, - sal_uInt16 nAspect = ASPECT_CONTENT ) override; + virtual void Draw( OutputDevice *, const JobSetup & rSetup, sal_uInt16 nAspect ) override; virtual void SetVisArea( const tools::Rectangle & rVisArea ) override; diff --git a/sc/source/ui/inc/impex.hxx b/sc/source/ui/inc/impex.hxx index c41fb83fafa2..cf3310ffb2c2 100644 --- a/sc/source/ui/inc/impex.hxx +++ b/sc/source/ui/inc/impex.hxx @@ -107,7 +107,7 @@ public: static bool IsFormatSupported( SotClipboardFormatId nFormat ); static const sal_Unicode* ScanNextFieldFromString( const sal_Unicode* p, OUString& rField, sal_Unicode cStr, const sal_Unicode* pSeps, - bool bMergeSeps, bool& rbIsQuoted, bool& rbOverflowCell, bool bRemoveSpace = false ); + bool bMergeSeps, bool& rbIsQuoted, bool& rbOverflowCell, bool bRemoveSpace ); static void WriteUnicodeOrByteString( SvStream& rStrm, const OUString& rString, bool bZero = false ); static void WriteUnicodeOrByteEndl( SvStream& rStrm ); diff --git a/sc/source/ui/inc/tabvwsh.hxx b/sc/source/ui/inc/tabvwsh.hxx index 126811185faf..8a897123a89c 100644 --- a/sc/source/ui/inc/tabvwsh.hxx +++ b/sc/source/ui/inc/tabvwsh.hxx @@ -387,8 +387,8 @@ public: /// See SfxViewShell::NotifyCursor(). void NotifyCursor(SfxViewShell* pViewShell) const override; /// Emits a LOK_CALLBACK_INVALIDATE_HEADER for all views whose current tab is equal to nCurrentTabIndex - static void notifyAllViewsHeaderInvalidation(HeaderType eHeaderType, SCTAB nCurrentTabIndex = -1); - static void notifyAllViewsHeaderInvalidation(bool Columns, SCTAB nCurrentTabIndex = -1); + static void notifyAllViewsHeaderInvalidation(HeaderType eHeaderType, SCTAB nCurrentTabIndex); + static void notifyAllViewsHeaderInvalidation(bool Columns, SCTAB nCurrentTabIndex); static bool isAnyEditViewInRange(bool bColumns, SCCOLROW nStart, SCCOLROW nEnd); css::uno::Reference getSelectedXShapes(); }; diff --git a/sd/inc/drawdoc.hxx b/sd/inc/drawdoc.hxx index 5ddb69a9b451..ac824cf90653 100644 --- a/sd/inc/drawdoc.hxx +++ b/sd/inc/drawdoc.hxx @@ -459,7 +459,7 @@ public: SAL_DLLPRIVATE void Merge(SdrModel& rSourceModel, sal_uInt16 nFirstPageNum, sal_uInt16 nLastPageNum, sal_uInt16 nDestPos, - bool bMergeMasterPages, bool bAllMasterPages = false, + bool bMergeMasterPages, bool bAllMasterPages, bool bUndo = true, bool bTreadSourceAsConst = false) override; css::text::WritingMode GetDefaultWritingMode() const; diff --git a/sd/source/ui/inc/DrawDocShell.hxx b/sd/source/ui/inc/DrawDocShell.hxx index 3860e025508a..7012e2113433 100644 --- a/sd/source/ui/inc/DrawDocShell.hxx +++ b/sd/source/ui/inc/DrawDocShell.hxx @@ -93,7 +93,7 @@ public: virtual bool SaveAs( SfxMedium &rMedium ) override; virtual ::tools::Rectangle GetVisArea(sal_uInt16 nAspect) const override; - virtual void Draw(OutputDevice*, const JobSetup& rSetup, sal_uInt16 nAspect = ASPECT_CONTENT) override; + virtual void Draw(OutputDevice*, const JobSetup& rSetup, sal_uInt16 nAspect) override; virtual ::svl::IUndoManager* GetUndoManager() override; virtual Printer* GetDocumentPrinter() override; diff --git a/sd/workben/custompanel/ctp_panel.cxx b/sd/workben/custompanel/ctp_panel.cxx index 536eb3d0828b..b7b1cf3e62d9 100644 --- a/sd/workben/custompanel/ctp_panel.cxx +++ b/sd/workben/custompanel/ctp_panel.cxx @@ -84,7 +84,7 @@ namespace sd { namespace colortoolpanel } catch( const Exception& ) { - DBG_UNHANDLED_EXCEPTION(); + DBG_UNHANDLED_EXCEPTION("sd"); } return NULL; } @@ -114,7 +114,7 @@ namespace sd { namespace colortoolpanel } catch( const Exception& ) { - DBG_UNHANDLED_EXCEPTION(); + DBG_UNHANDLED_EXCEPTION("sd"); } osl_atomic_increment( &m_refCount ); if ( xParentWindow.is() ) @@ -182,7 +182,7 @@ namespace sd { namespace colortoolpanel } catch( const Exception& ) { - DBG_UNHANDLED_EXCEPTION(); + DBG_UNHANDLED_EXCEPTION("sd"); } } @@ -205,7 +205,7 @@ namespace sd { namespace colortoolpanel } catch( const Exception& ) { - DBG_UNHANDLED_EXCEPTION(); + DBG_UNHANDLED_EXCEPTION("sd"); } m_xWindow.clear(); } diff --git a/sfx2/source/notebookbar/NotebookbarPopup.hxx b/sfx2/source/notebookbar/NotebookbarPopup.hxx index 64de9cdc7304..2a70cd77daf5 100755 --- a/sfx2/source/notebookbar/NotebookbarPopup.hxx +++ b/sfx2/source/notebookbar/NotebookbarPopup.hxx @@ -45,7 +45,7 @@ public: virtual void PopupModeEnd() override; - void hideSeparators(bool bHide = true); + void hideSeparators(bool bHide); void dispose() override; }; diff --git a/slideshow/source/engine/shapes/viewshape.cxx b/slideshow/source/engine/shapes/viewshape.cxx index a43c258fd305..d34388568e4d 100644 --- a/slideshow/source/engine/shapes/viewshape.cxx +++ b/slideshow/source/engine/shapes/viewshape.cxx @@ -209,7 +209,7 @@ namespace slideshow } catch( uno::Exception& ) { - DBG_UNHANDLED_EXCEPTION(); + DBG_UNHANDLED_EXCEPTION("slideshow"); } #endif if( pClip ) diff --git a/starmath/inc/document.hxx b/starmath/inc/document.hxx index 00be9e454248..95d6af49b1e7 100644 --- a/starmath/inc/document.hxx +++ b/starmath/inc/document.hxx @@ -106,7 +106,7 @@ class SM_DLLPUBLIC SmDocShell : public SfxObjectShell, public SfxListener virtual void Draw(OutputDevice *pDevice, const JobSetup & rSetup, - sal_uInt16 nAspect = ASPECT_CONTENT) override; + sal_uInt16 nAspect) override; virtual void FillClass(SvGlobalName* pClassName, SotClipboardFormatId* pFormat, diff --git a/store/source/storbase.hxx b/store/source/storbase.hxx index 6e683eb4db09..042a467db1b5 100644 --- a/store/source/storbase.hxx +++ b/store/source/storbase.hxx @@ -554,7 +554,7 @@ protected: /** Construction. */ - explicit OStorePageObject (std::shared_ptr const & rxPage = std::shared_ptr()) + explicit OStorePageObject (std::shared_ptr const & rxPage) : m_xPage (rxPage), m_bDirty (false) {} diff --git a/sw/inc/crsrsh.hxx b/sw/inc/crsrsh.hxx index 48f7c7a57d17..98a83f08b1f2 100644 --- a/sw/inc/crsrsh.hxx +++ b/sw/inc/crsrsh.hxx @@ -414,7 +414,7 @@ public: * stack * @return if there was one on the stack, otherwise */ - bool Pop(PopMode = PopMode::DeleteStack); + bool Pop(PopMode); /* * Combine 2 Cursors. * Delete the topmost from the stack and move its Mark into the current. diff --git a/sw/inc/docsh.hxx b/sw/inc/docsh.hxx index ebd823291046..0be7ea783433 100644 --- a/sw/inc/docsh.hxx +++ b/sw/inc/docsh.hxx @@ -111,7 +111,7 @@ class SW_DLLPUBLIC SwDocShell /// Make DocInfo known to the Doc. SAL_DLLPRIVATE virtual VclPtr CreateDocumentInfoDialog(const SfxItemSet &) override; /// OLE-stuff - SAL_DLLPRIVATE virtual void Draw( OutputDevice*, const JobSetup&, sal_uInt16 = ASPECT_CONTENT) override; + SAL_DLLPRIVATE virtual void Draw( OutputDevice*, const JobSetup&, sal_uInt16 nAspect) override; /// Methods for StyleSheets diff --git a/sw/inc/docufld.hxx b/sw/inc/docufld.hxx index fd699b563356..db58e2dd2f49 100644 --- a/sw/inc/docufld.hxx +++ b/sw/inc/docufld.hxx @@ -308,7 +308,7 @@ public: bool bConditional, const OUString& rCond, const OUString& rText, - bool bHidden = false, + bool bHidden, sal_uInt16 nSubType = TYP_HIDDENTXTFLD); SwHiddenTextField( SwHiddenTextFieldType*, diff --git a/sw/inc/pam.hxx b/sw/inc/pam.hxx index f5840c0d1a4d..968d20c91f7d 100644 --- a/sw/inc/pam.hxx +++ b/sw/inc/pam.hxx @@ -185,13 +185,13 @@ public: bool bSearchInNotes, utl::TextSearch& rSText, SwMoveFnCollection const & fnMove, - const SwPaM *pPam =nullptr, bool bInReadOnly = false); + const SwPaM *pPam, bool bInReadOnly = false); bool Find( const SwFormat& rFormat, SwMoveFnCollection const & fnMove, - const SwPaM *pPam =nullptr, bool bInReadOnly = false); + const SwPaM *pPam, bool bInReadOnly = false); bool Find( const SfxPoolItem& rAttr, bool bValue, SwMoveFnCollection const & fnMove, - const SwPaM *pPam =nullptr, bool bInReadOnly = false ); + const SwPaM *pPam, bool bInReadOnly = false ); bool Find( const SfxItemSet& rAttr, bool bNoColls, SwMoveFnCollection const & fnMove, const SwPaM *pPam, bool bInReadOnly, bool bMoveFirst ); diff --git a/sw/inc/swcrsr.hxx b/sw/inc/swcrsr.hxx index bebc7023f169..6d306073de26 100644 --- a/sw/inc/swcrsr.hxx +++ b/sw/inc/swcrsr.hxx @@ -120,12 +120,12 @@ public: SwDocPositions nStart, SwDocPositions nEnde, bool& bCancel, FindRanges, - const SwTextFormatColl* pReplFormat = nullptr ); + const SwTextFormatColl* pReplFormat ); sal_uLong Find( const SfxItemSet& rSet, bool bNoCollections, SwDocPositions nStart, SwDocPositions nEnde, bool& bCancel, FindRanges, - const i18nutil::SearchOptions2* pSearchOpt = nullptr, + const i18nutil::SearchOptions2* pSearchOpt, const SfxItemSet* rReplSet = nullptr ); // UI versions diff --git a/sw/source/core/undo/untbl.cxx b/sw/source/core/undo/untbl.cxx index a3fc1152d73e..524ac22d08e8 100644 --- a/sw/source/core/undo/untbl.cxx +++ b/sw/source/core/undo/untbl.cxx @@ -2284,7 +2284,7 @@ public: RedlineFlagsInternGuard( SwDoc& rDoc, // change mode of this document RedlineFlags eNewRedlineFlags, // new redline mode - RedlineFlags eRedlineFlagsMask = RedlineFlags::On | RedlineFlags::Ignore /*change only bits set in this mask*/); + RedlineFlags eRedlineFlagsMask /*change only bits set in this mask*/); ~RedlineFlagsInternGuard(); }; diff --git a/sw/source/filter/html/svxcss1.hxx b/sw/source/filter/html/svxcss1.hxx index bceda4e9c758..516887c54521 100644 --- a/sw/source/filter/html/svxcss1.hxx +++ b/sw/source/filter/html/svxcss1.hxx @@ -240,7 +240,7 @@ public: SvxCSS1Parser( SfxItemPool& rPool, const OUString& rBaseURL, - sal_uInt16 *pWhichIds, sal_uInt16 nWhichIds=0 ); + sal_uInt16 *pWhichIds, sal_uInt16 nWhichIds ); virtual ~SvxCSS1Parser() override; bool IsIgnoreFontFamily() const { return bIgnoreFontFamily; } diff --git a/sw/source/filter/html/wrthtml.hxx b/sw/source/filter/html/wrthtml.hxx index 352c66adf06a..f3bf90476603 100644 --- a/sw/source/filter/html/wrthtml.hxx +++ b/sw/source/filter/html/wrthtml.hxx @@ -658,7 +658,7 @@ Writer& OutHTML_Image( Writer&, const SwFrameFormat& rFormat, Graphic const & rGraphic, const OUString& rAlternateText, const Size& rRealSize, HtmlFrmOpts nFrameOpts, const sal_Char *pMarkType, - const ImageMap *pGenImgMap = nullptr, + const ImageMap *pGenImgMap, const OUString& rMimeType = OUString() ); Writer& OutHTML_BulletImage( Writer& rWrt, const sal_Char *pTag, diff --git a/sw/source/filter/ww8/ww8scan.hxx b/sw/source/filter/ww8/ww8scan.hxx index c9216ed1cbe6..a97ea13628fe 100644 --- a/sw/source/filter/ww8/ww8scan.hxx +++ b/sw/source/filter/ww8/ww8scan.hxx @@ -1533,7 +1533,7 @@ public: sal_uInt16 m_nFib_actual; // 0x05bc #i56856# WW8Fib(SvStream& rStrm, sal_uInt8 nWantedVersion,sal_uInt32 nOffset=0); - explicit WW8Fib(sal_uInt8 nVersion = 6, bool bDot = false); + explicit WW8Fib(sal_uInt8 nVersion, bool bDot = false); void WriteHeader(SvStream& rStrm); void Write(SvStream& rStrm); diff --git a/sw/source/uibase/inc/frmdlg.hxx b/sw/source/uibase/inc/frmdlg.hxx index 8a8cd84bc467..28c8cbbbaaf4 100644 --- a/sw/source/uibase/inc/frmdlg.hxx +++ b/sw/source/uibase/inc/frmdlg.hxx @@ -51,7 +51,7 @@ public: const SfxItemSet& rCoreSet, bool bNewFrame, const OUString& sResType, - bool bFormat = false, + bool bFormat, const OString& sDefPage = OString(), const OUString* pFormatStr = nullptr); diff --git a/sw/source/uibase/inc/wrtsh.hxx b/sw/source/uibase/inc/wrtsh.hxx index 4693ac1860f3..13825221942a 100644 --- a/sw/source/uibase/inc/wrtsh.hxx +++ b/sw/source/uibase/inc/wrtsh.hxx @@ -593,7 +593,7 @@ private: SAL_DLLPRIVATE void LeaveExtSel() { m_bSelWrd = m_bSelLn = false;} SAL_DLLPRIVATE bool GoStart(bool KeepArea, bool *, - bool bSelect = false, bool bDontMoveRegion = false); + bool bSelect, bool bDontMoveRegion = false); SAL_DLLPRIVATE bool GoEnd(bool KeepArea = false, const bool * = nullptr); enum BookMarkMove diff --git a/toolkit/inc/helper/btndlg.hxx b/toolkit/inc/helper/btndlg.hxx index affcfa1f87e2..011f8761abb1 100644 --- a/toolkit/inc/helper/btndlg.hxx +++ b/toolkit/inc/helper/btndlg.hxx @@ -58,7 +58,7 @@ public: void SetPageSizePixel( const Size& rSize ) { maPageSize = rSize; } - void AddButton( StandardButtonType eType, sal_uInt16 nId, ButtonDialogFlags nBtnFlags = ButtonDialogFlags::NONE, long nSepPixel = 0 ); + void AddButton( StandardButtonType eType, sal_uInt16 nId, ButtonDialogFlags nBtnFlags, long nSepPixel = 0 ); void RemoveButton( sal_uInt16 nId ); protected: diff --git a/vcl/inc/messagedialog.hxx b/vcl/inc/messagedialog.hxx index 09d3a909fece..cf1df6ed68aa 100644 --- a/vcl/inc/messagedialog.hxx +++ b/vcl/inc/messagedialog.hxx @@ -36,9 +36,8 @@ private: MessageDialog(vcl::Window* pParent, WinBits nStyle); public: - MessageDialog(vcl::Window* pParent, const OUString& rMessage, - VclMessageType eMessageType = VclMessageType::Error, - VclButtonsType eButtonsType = VclButtonsType::Ok); + MessageDialog(vcl::Window* pParent, const OUString& rMessage, VclMessageType eMessageType, + VclButtonsType eButtonsType); MessageDialog(vcl::Window* pParent, const OString& rID, const OUString& rUIXMLDescription); virtual bool set_property(const OString& rKey, const OUString& rValue) override; OUString const& get_primary_text() const; diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.hxx b/writerfilter/source/dmapper/DomainMapper_Impl.hxx index d671c210853b..7546984165ac 100644 --- a/writerfilter/source/dmapper/DomainMapper_Impl.hxx +++ b/writerfilter/source/dmapper/DomainMapper_Impl.hxx @@ -877,7 +877,7 @@ public: /// If the current paragraph has a numbering style associated, this method returns its character style (part of the numbering rules) css::uno::Reference GetCurrentNumberingCharStyle(); /// If the current paragraph has a numbering style associated, this method returns its numbering rules - css::uno::Reference GetCurrentNumberingRules(sal_Int32* pListLevel = nullptr); + css::uno::Reference GetCurrentNumberingRules(sal_Int32* pListLevel); /** Used for attributes/sprms which cannot be evaluated immediately (e.g. they depend -- cgit