From fb1b461208e7a2760fa1c018db08606a9b3e435d Mon Sep 17 00:00:00 2001
From: Gabor Kelemen <kelemen.gabor2@nisz.hu>
Date: Fri, 25 Oct 2019 12:17:34 +0200
Subject: tdf#42949 Fix IWYU warning in include/vcl/window.hxx

The boost/property_tree/ptree.hpp added in commit
75b8db7fa7344a679d3c5dbdc8c5bd4228cdbc7c

turns out to be rather expensive: it adds about 900 kB per
compilation unit and window.hxx is included in about 2600 compilation units

Replacing it with forward declaration header has reduced total includebloat
from 26.1 Gb to about 22.7

Change-Id: I797608b54a62a5838c7a5d47355fb6bd736ad36c
Reviewed-on: https://gerrit.libreoffice.org/81500
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
---
 include/vcl/window.hxx              | 2 +-
 sfx2/source/sidebar/Panel.cxx       | 2 ++
 svtools/source/control/valueset.cxx | 1 +
 vcl/source/control/button.cxx       | 1 +
 vcl/source/control/field.cxx        | 1 +
 vcl/source/control/listbox.cxx      | 1 +
 vcl/source/window/layout.cxx        | 1 +
 vcl/source/window/toolbox2.cxx      | 1 +
 vcl/source/window/window.cxx        | 1 +
 9 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/include/vcl/window.hxx b/include/vcl/window.hxx
index 071fe5f8bd26..855ca478187c 100644
--- a/include/vcl/window.hxx
+++ b/include/vcl/window.hxx
@@ -34,7 +34,7 @@
 #include <com/sun/star/uno/Reference.hxx>
 #include <memory>
 
-#include <boost/property_tree/ptree.hpp>
+#include <boost/property_tree/ptree_fwd.hpp>
 
 class VirtualDevice;
 struct ImplSVEvent;
diff --git a/sfx2/source/sidebar/Panel.cxx b/sfx2/source/sidebar/Panel.cxx
index d9515affef63..e4b9ef6668ec 100644
--- a/sfx2/source/sidebar/Panel.cxx
+++ b/sfx2/source/sidebar/Panel.cxx
@@ -40,6 +40,8 @@
 #include <com/sun/star/ui/XSidebarPanel.hpp>
 #include <com/sun/star/ui/XUIElement.hpp>
 
+#include <boost/property_tree/ptree.hpp>
+
 using namespace css;
 using namespace css::uno;
 
diff --git a/svtools/source/control/valueset.cxx b/svtools/source/control/valueset.cxx
index 08721c25acde..46e1b78b2b05 100644
--- a/svtools/source/control/valueset.cxx
+++ b/svtools/source/control/valueset.cxx
@@ -36,6 +36,7 @@
 #include "valueimp.hxx"
 
 #include <svtools/valueset.hxx>
+#include <boost/property_tree/ptree.hpp>
 
 using namespace css::uno;
 using namespace css::lang;
diff --git a/vcl/source/control/button.cxx b/vcl/source/control/button.cxx
index 3a286f026cba..ce37b5b358f6 100644
--- a/vcl/source/control/button.cxx
+++ b/vcl/source/control/button.cxx
@@ -44,6 +44,7 @@
 #include <comphelper/dispatchcommand.hxx>
 #include <comphelper/lok.hxx>
 #include <officecfg/Office/Common.hxx>
+#include <boost/property_tree/ptree.hpp>
 
 
 using namespace css;
diff --git a/vcl/source/control/field.cxx b/vcl/source/control/field.cxx
index 83644c5e5657..ed003e5d74e6 100644
--- a/vcl/source/control/field.cxx
+++ b/vcl/source/control/field.cxx
@@ -39,6 +39,7 @@
 #include <rtl/math.hxx>
 
 #include <unotools/localedatawrapper.hxx>
+#include <boost/property_tree/ptree.hpp>
 
 using namespace ::com::sun::star;
 using namespace ::comphelper;
diff --git a/vcl/source/control/listbox.cxx b/vcl/source/control/listbox.cxx
index d9bb1d98bfed..de2f45c69525 100644
--- a/vcl/source/control/listbox.cxx
+++ b/vcl/source/control/listbox.cxx
@@ -32,6 +32,7 @@
 #include <comphelper/lok.hxx>
 
 #include <com/sun/star/datatransfer/dnd/XDropTarget.hpp>
+#include <boost/property_tree/ptree.hpp>
 
 void ListBox::EnableQuickSelection( bool b )
 {
diff --git a/vcl/source/window/layout.cxx b/vcl/source/window/layout.cxx
index ce0d15afddab..75da9e20b9e5 100644
--- a/vcl/source/window/layout.cxx
+++ b/vcl/source/window/layout.cxx
@@ -19,6 +19,7 @@
 #include <messagedialog.hxx>
 #include <window.h>
 #include <boost/multi_array.hpp>
+#include <boost/property_tree/ptree.hpp>
 #include <vcl/vclmedit.hxx>
 #include <sal/log.hxx>
 
diff --git a/vcl/source/window/toolbox2.cxx b/vcl/source/window/toolbox2.cxx
index 56f687dac2f8..201e44213d49 100644
--- a/vcl/source/window/toolbox2.cxx
+++ b/vcl/source/window/toolbox2.cxx
@@ -21,6 +21,7 @@
 #include <sal/log.hxx>
 
 #include <comphelper/processfactory.hxx>
+#include <boost/property_tree/ptree.hpp>
 
 #include <vcl/svapp.hxx>
 #include <vcl/idle.hxx>
diff --git a/vcl/source/window/window.cxx b/vcl/source/window/window.cxx
index b09158b9b16c..c6434c537eb8 100644
--- a/vcl/source/window/window.cxx
+++ b/vcl/source/window/window.cxx
@@ -66,6 +66,7 @@
 #include <unotools/configmgr.hxx>
 #include <osl/diagnose.h>
 #include <tools/debug.hxx>
+#include <boost/property_tree/ptree.hpp>
 
 #include <cassert>
 #include <typeinfo>
-- 
cgit