From c7c6f0af6c836ebe0968967a1e7c8320b0ac17d6 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Fri, 23 Apr 2021 16:07:32 +0200 Subject: loplugin:stringadd convert chained append to + which can use the more efficient *StringConcat Also fix a crash in stringview plugin which started happening while I working on this. Change-Id: I91a5b9b7707d1594d27d80b73930f5afac8ae608 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114568 Tested-by: Jenkins Reviewed-by: Noel Grandin --- UnoControls/source/controls/progressmonitor.cxx | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'UnoControls') diff --git a/UnoControls/source/controls/progressmonitor.cxx b/UnoControls/source/controls/progressmonitor.cxx index 05296e35915b..de9d596513de 100644 --- a/UnoControls/source/controls/progressmonitor.cxx +++ b/UnoControls/source/controls/progressmonitor.cxx @@ -722,7 +722,7 @@ void ProgressMonitor::impl_rebuildFixedText () // "\n" MUST BE at the end of line!!! => Else ... topic and his text are not in the same line!!! for (auto const & pSearchItem : maTextlist_Top) { - aCollectString.append(pSearchItem->sTopic).append("\n"); + aCollectString.append(pSearchItem->sTopic + "\n"); } m_xTopic_Top->setText ( aCollectString.makeStringAndClear() ); @@ -737,7 +737,7 @@ void ProgressMonitor::impl_rebuildFixedText () // "\n" MUST BE at the end of line!!! => Else ... topic and his text are not in the same line!!! for (auto const & pSearchItem : maTextlist_Top) { - aCollectString.append(pSearchItem->sText).append("\n"); + aCollectString.append(pSearchItem->sText + "\n"); } m_xText_Top->setText ( aCollectString.makeStringAndClear() ); @@ -754,7 +754,7 @@ void ProgressMonitor::impl_rebuildFixedText () // "\n" MUST BE at the end of line!!! => Else ... topic and his text are not in the same line!!! for (auto const & pSearchItem : maTextlist_Bottom) { - aCollectString.append(pSearchItem->sTopic).append("\n"); + aCollectString.append(pSearchItem->sTopic + "\n"); } m_xTopic_Bottom->setText ( aCollectString.makeStringAndClear() ); @@ -770,7 +770,7 @@ void ProgressMonitor::impl_rebuildFixedText () // "\n" MUST BE at the end of line!!! => Else ... topic and his text are not in the same line!!! for (auto const & pSearchItem : maTextlist_Bottom) { - aCollectString.append(pSearchItem->sText).append("\n"); + aCollectString.append(pSearchItem->sText + "\n"); } m_xText_Bottom->setText ( aCollectString.makeStringAndClear() ); -- cgit