From 72d88049bdac3417f6833255dff5a06a0f3eb1c3 Mon Sep 17 00:00:00 2001 From: Julien Nabet Date: Thu, 4 Jul 2019 18:09:26 +0200 Subject: cid#1448380: Resource leak (avmedia/gstplayer) Change-Id: Ieaf5f68f17558f27e187241869c8fe01f8e29ba2 Reviewed-on: https://gerrit.libreoffice.org/75094 Reviewed-by: Jan-Marek Glogowski Tested-by: Jenkins Reviewed-by: Julien Nabet --- avmedia/source/gstreamer/gstplayer.cxx | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'avmedia/source') diff --git a/avmedia/source/gstreamer/gstplayer.cxx b/avmedia/source/gstreamer/gstplayer.cxx index 35feb8ad5ea2..111622cbac9c 100644 --- a/avmedia/source/gstreamer/gstplayer.cxx +++ b/avmedia/source/gstreamer/gstplayer.cxx @@ -846,10 +846,9 @@ uno::Reference< ::media::XPlayerWindow > SAL_CALL Player::createPlayerWindow( co if( aSize.Width > 0 && aSize.Height > 0 ) { - ::avmedia::gstreamer::Window* pWindow = new ::avmedia::gstreamer::Window; if (rArguments.getLength() <= 2) { - xRet = pWindow; + xRet = new ::avmedia::gstreamer::Window; return xRet; } @@ -894,7 +893,7 @@ uno::Reference< ::media::XPlayerWindow > SAL_CALL Player::createPlayerWindow( co return nullptr; } - xRet = pWindow; + xRet = new ::avmedia::gstreamer::Window; g_object_set(G_OBJECT(mpPlaybin), "video-sink", pVideosink, nullptr); g_object_set(G_OBJECT(mpPlaybin), "force-aspect-ratio", FALSE, nullptr); -- cgit