From 32f60d78b15b5f2c677e8687720665f6814fef62 Mon Sep 17 00:00:00 2001 From: Zolnai Tamás Date: Wed, 28 May 2014 13:07:38 +0200 Subject: libgltf: solve this memory leak problem on a better way 2 Handle those cases when file loading failes. Release *.json file on a different way since it is allocated by libgltf (inside the glTFHandle). (cherry picked from commit fafc1e29c1f060c1a44361a0445300f9786ad6f4) Change-Id: Idf6c6971a8ac1b342d89dc4f61a62624183e01d0 --- avmedia/source/opengl/oglplayer.cxx | 20 +++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-) (limited to 'avmedia') diff --git a/avmedia/source/opengl/oglplayer.cxx b/avmedia/source/opengl/oglplayer.cxx index 79c78f18ecc9..4f173563d7e4 100644 --- a/avmedia/source/opengl/oglplayer.cxx +++ b/avmedia/source/opengl/oglplayer.cxx @@ -31,6 +31,13 @@ OGLPlayer::OGLPlayer() OGLPlayer::~OGLPlayer() { + for (size_t i = 0; i < m_pHandle->size; ++i) + { + if (m_pHandle->files[i].type != GLTF_JSON) + { + delete [] m_pHandle->files[i].buffer; + } + } gltf_renderer_release(m_pHandle); } @@ -68,6 +75,8 @@ bool OGLPlayer::create( const OUString& rURL ) m_pHandle = gltf_renderer_init(&aJsonFile); + delete [] aJsonFile.buffer; + if( !m_pHandle || !m_pHandle->files ) { SAL_WARN("avmedia.opengl", "gltf_renderer_init returned an invalid glTFHandle"); @@ -87,7 +96,14 @@ bool OGLPlayer::create( const OUString& rURL ) // Load images as bitmaps GraphicFilter aFilter; Graphic aGraphic; - aFilter.ImportGraphic(aGraphic, INetURLObject(sFilesURL)); + if( aFilter.ImportGraphic(aGraphic, INetURLObject(sFilesURL)) != GRFILTER_OK ) + { + rFile.buffer = 0; + rFile.imagewidth = 0; + rFile.imageheight = 0; + SAL_WARN("avmedia.opengl", "Can't load texture file: " + sFilesURL); + return false; + } BitmapEx aBitmapEx = aGraphic.GetBitmapEx(); aBitmapEx.Mirror(BMP_MIRROR_VERT); rFile.buffer = (char*)OpenGLHelper::ConvertBitmapExToRGBABuffer(aBitmapEx); @@ -98,6 +114,8 @@ bool OGLPlayer::create( const OUString& rURL ) { if( !lcl_LoadFile(&rFile, sFilesURL) ) { + rFile.buffer = 0; + rFile.size = 0; SAL_WARN("avmedia.opengl", "Can't load glTF file: " + sFilesURL); return false; } -- cgit