From 1f9468fc29874eae5100317282ab8b395904406d Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Thu, 14 Oct 2021 14:57:54 +0200 Subject: use std::vector::insert instead of push_back because it will pre-allocate space and often is optimised to memcpy Change-Id: I03ed7915f2762d3d27e378638052a47a28bbf096 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123588 Tested-by: Jenkins Reviewed-by: Noel Grandin --- basctl/source/basicide/basobj2.cxx | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) (limited to 'basctl') diff --git a/basctl/source/basicide/basobj2.cxx b/basctl/source/basicide/basobj2.cxx index 9748b24ccd2f..f14535cbd3f1 100644 --- a/basctl/source/basicide/basobj2.cxx +++ b/basctl/source/basicide/basobj2.cxx @@ -100,21 +100,15 @@ Sequence< OUString > GetMergedLibraryNames( const Reference< script::XLibraryCon std::vector aLibList; if ( xModLibContainer.is() ) { - Sequence< OUString > aModLibNames = xModLibContainer->getElementNames(); - sal_Int32 nModLibCount = aModLibNames.getLength(); - const OUString* pModLibNames = aModLibNames.getConstArray(); - for ( sal_Int32 i = 0 ; i < nModLibCount ; i++ ) - aLibList.push_back( pModLibNames[ i ] ); + const Sequence< OUString > aModLibNames = xModLibContainer->getElementNames(); + aLibList.insert( aLibList.end(), aModLibNames.begin(), aModLibNames.end() ); } // create a list of dialog library names if ( xDlgLibContainer.is() ) { - Sequence< OUString > aDlgLibNames = xDlgLibContainer->getElementNames(); - sal_Int32 nDlgLibCount = aDlgLibNames.getLength(); - const OUString* pDlgLibNames = aDlgLibNames.getConstArray(); - for ( sal_Int32 i = 0 ; i < nDlgLibCount ; i++ ) - aLibList.push_back( pDlgLibNames[ i ] ); + const Sequence< OUString > aDlgLibNames = xDlgLibContainer->getElementNames(); + aLibList.insert( aLibList.end(), aDlgLibNames.begin(), aDlgLibNames.end() ); } // sort list -- cgit