From 6a40737e1feb2e8d1992c46ee6c0e5cf30bab025 Mon Sep 17 00:00:00 2001 From: Samuel Mehrbrodt Date: Mon, 11 Nov 2019 14:53:51 +0100 Subject: Fix macro disabling in Basic IDE After 8d69ca60f3c8f53699986f924291a2acda5694a1 macros were always disabled as ScriptDocument::allowMacros always returned false when called from non-document context. Change-Id: Ibef4c7d561f4ee01cd44f5327e4ab948282bb07d Reviewed-on: https://gerrit.libreoffice.org/82444 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt --- basctl/source/basicide/baside2.cxx | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'basctl') diff --git a/basctl/source/basicide/baside2.cxx b/basctl/source/basicide/baside2.cxx index af35a3a3dc7b..5cb16f8f1f58 100644 --- a/basctl/source/basicide/baside2.cxx +++ b/basctl/source/basicide/baside2.cxx @@ -62,6 +62,7 @@ #include #include #include +#include namespace basctl { @@ -308,7 +309,8 @@ void ModulWindow::BasicExecute() { // #116444# check security settings before macro execution ScriptDocument aDocument( GetDocument() ); - if (!aDocument.allowMacros()) + bool bMacrosDisabled = officecfg::Office::Common::Security::Scripting::DisableMacrosExecution::get(); + if (bMacrosDisabled || (aDocument.isDocument() && !aDocument.allowMacros())) { std::unique_ptr xBox( Application::CreateMessageDialog(GetFrameWeld(), VclMessageType::Warning, -- cgit