From bb209f2f53edc1b0d268d561e0c12bf93e83fb41 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Tue, 11 Sep 2018 09:42:35 +0200 Subject: Revert "clang bugprone-unused-return-value" comment from sberg: aren't these changes broken in general, when the called function may throw an exception before it takes ownership of the passed-in pointer? So revert, except for (a) PlainTextFilterDetect::detect, which was definitely a leak (b) SwCursor::FindAll, where unique_ptr was being unnecessarily used This reverts commit 7764ae70b04058a64a3999529e98d1115ba59d1c. Change-Id: I555e651b44e245b031729013d2ce88d26e8a357e Reviewed-on: https://gerrit.libreoffice.org/60301 Reviewed-by: Noel Grandin Tested-by: Noel Grandin --- basctl/source/basicide/bastype2.cxx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'basctl') diff --git a/basctl/source/basicide/bastype2.cxx b/basctl/source/basicide/bastype2.cxx index d8fe8efdc59a..5997980df2ea 100644 --- a/basctl/source/basicide/bastype2.cxx +++ b/basctl/source/basicide/bastype2.cxx @@ -701,8 +701,9 @@ SvTreeListEntry* TreeListBox::AddEntry( { SvTreeListEntry* p = InsertEntry( rText, rImage, rImage, pParent, bChildrenOnDemand, TREELIST_APPEND, - aUserData.release() + aUserData.get() ); + aUserData.release(); return p; } -- cgit