From 62633dfe026bc3badf7066e5fb454036bae9cfdc Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Tue, 12 Apr 2016 12:08:00 +0200 Subject: clang-tidy performance-unnecessary-value-param in various Change-Id: I7168d44dab8e6a8e37bb7920d744ff32f5e52907 Reviewed-on: https://gerrit.libreoffice.org/24019 Tested-by: Jenkins Reviewed-by: Noel Grandin --- basegfx/source/polygon/b2dpolygoncutandtouch.cxx | 2 +- basegfx/source/polygon/b2dtrapezoid.cxx | 4 ++-- basegfx/source/range/b2drangeclipper.cxx | 6 +++--- basegfx/source/tools/b2dclipstate.cxx | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) (limited to 'basegfx') diff --git a/basegfx/source/polygon/b2dpolygoncutandtouch.cxx b/basegfx/source/polygon/b2dpolygoncutandtouch.cxx index 1d4405fac5c8..e72c6ba6b7e5 100644 --- a/basegfx/source/polygon/b2dpolygoncutandtouch.cxx +++ b/basegfx/source/polygon/b2dpolygoncutandtouch.cxx @@ -142,7 +142,7 @@ namespace basegfx while(nNewInd < nTempPointCount && rTempPoints[nNewInd].getIndex() == a) { const temporaryPoint& rTempPoint = rTempPoints[nNewInd++]; - const B2DPoint aNewPoint(rTempPoint.getPoint()); + const B2DPoint& aNewPoint(rTempPoint.getPoint()); // do not add points double if(!aRetval.getB2DPoint(aRetval.count() - 1L).equal(aNewPoint)) diff --git a/basegfx/source/polygon/b2dtrapezoid.cxx b/basegfx/source/polygon/b2dtrapezoid.cxx index 2b6db06febb6..e36d2af4930d 100644 --- a/basegfx/source/polygon/b2dtrapezoid.cxx +++ b/basegfx/source/polygon/b2dtrapezoid.cxx @@ -271,7 +271,7 @@ namespace basegfx bool splitEdgeAtGivenPoint( TrDeEdgeEntries::reference aEdge, const B2DPoint& rCutPoint, - TrDeEdgeEntries::iterator aCurrent) + const TrDeEdgeEntries::iterator& aCurrent) { // do not create edges without deltaY: do not split when start is identical if(aEdge.getStart().equal(rCutPoint)) @@ -323,7 +323,7 @@ namespace basegfx bool testAndCorrectEdgeIntersection( TrDeEdgeEntries::reference aEdgeA, TrDeEdgeEntries::reference aEdgeB, - TrDeEdgeEntries::iterator aCurrent) + const TrDeEdgeEntries::iterator& aCurrent) { // Exclude simple cases: same start or end point if(aEdgeA.getStart().equal(aEdgeB.getStart())) diff --git a/basegfx/source/range/b2drangeclipper.cxx b/basegfx/source/range/b2drangeclipper.cxx index 882b4a88cfc2..46f9e490e37c 100644 --- a/basegfx/source/range/b2drangeclipper.cxx +++ b/basegfx/source/range/b2drangeclipper.cxx @@ -706,14 +706,14 @@ namespace basegfx // wow what a hack. necessary because stl's list::erase does // not eat reverse_iterator - template Iter eraseFromList(Cont&, Iter); + template Iter eraseFromList(Cont&, const Iter&); template<> inline ListOfEdges::iterator eraseFromList( - ListOfEdges& rList, ListOfEdges::iterator aIter) + ListOfEdges& rList, const ListOfEdges::iterator& aIter) { return rList.erase(aIter); } template<> inline ListOfEdges::reverse_iterator eraseFromList( - ListOfEdges& rList, ListOfEdges::reverse_iterator aIter) + ListOfEdges& rList, const ListOfEdges::reverse_iterator& aIter) { return ListOfEdges::reverse_iterator( rList.erase(boost::prior(aIter.base()))); diff --git a/basegfx/source/tools/b2dclipstate.cxx b/basegfx/source/tools/b2dclipstate.cxx index 65a179fa58df..251a0e130116 100644 --- a/basegfx/source/tools/b2dclipstate.cxx +++ b/basegfx/source/tools/b2dclipstate.cxx @@ -105,7 +105,7 @@ namespace tools B2VectorOrientation::Positive); } - void addPolyPolygon(B2DPolyPolygon aPoly, Operation eOp) + void addPolyPolygon(const B2DPolyPolygon& aPoly, Operation eOp) { commitPendingRanges(); if( mePendingOps != eOp ) -- cgit