From 7d8196ea2f4ec3634dbad7367345e62c4ea9893d Mon Sep 17 00:00:00 2001 From: Eike Rathke Date: Thu, 22 Sep 2016 22:20:48 +0200 Subject: perf: eliminate SfxSimpleHint and move to SfxHint, tdf#87101 related There were over 150 places in *::Notify() functions that did some dynamic_cast of which ~98% were unnecessary because the base class SfxHint passed was an SfxSimpleHint anyway. dynamic_cast operations come with quite some cost, so avoid if possible. Specifically for ScFormulaCell::Notify() that created a bottleneck in scenarios where cells were notified that already handled a previous notification. In mass operations doing the dynamic_cast before it could be decided whether having to act on it or not this made 2/3 of all time spent in the Notify() call. To get rid of that rename/move SfxSimpleHint to SfxHint and let classes derive from SfxHint instead of SfxSimpleHint. This comes only with a slight cost that an additional sal_uInt32 is transported in such hints, initialized to 0, but this is neglectable compared to the huge gain. For the rare cases where a Notify() actually expects both, an SfxHint (formerly SfxSimpleHint) and a derived hint, this changed order of the dynamic_cast involved so the simple SfxHint::GetId() is handled last. Modules using such combinations can further optimize by treating the simple SfxHint::GetId() first once verified that none of the other derived hints use an ID not equal to zero respectively none of the ID values the simple hint uses. Change-Id: I9fcf723e3a4487ceb92336189d23a62c344cf0ce Reviewed-on: https://gerrit.libreoffice.org/29205 Reviewed-by: Eike Rathke Tested-by: Eike Rathke --- basic/source/basmgr/basicmanagerrepository.cxx | 5 ++--- basic/source/basmgr/basmgr.cxx | 4 ++-- 2 files changed, 4 insertions(+), 5 deletions(-) (limited to 'basic/source/basmgr') diff --git a/basic/source/basmgr/basicmanagerrepository.cxx b/basic/source/basmgr/basicmanagerrepository.cxx index 25b71c757333..cb09047ec184 100644 --- a/basic/source/basmgr/basicmanagerrepository.cxx +++ b/basic/source/basmgr/basicmanagerrepository.cxx @@ -30,7 +30,7 @@ #include #include #include -#include +#include #include #include #include @@ -577,8 +577,7 @@ namespace basic void ImplRepository::Notify( SfxBroadcaster& _rBC, const SfxHint& _rHint ) { - const SfxSimpleHint* pSimpleHint = dynamic_cast< const SfxSimpleHint* >( &_rHint ); - if ( !pSimpleHint || ( pSimpleHint->GetId() != SFX_HINT_DYING ) ) + if ( _rHint.GetId() != SFX_HINT_DYING ) // not interested in return; diff --git a/basic/source/basmgr/basmgr.cxx b/basic/source/basmgr/basmgr.cxx index 55ccad287424..66e16c5b5a5e 100644 --- a/basic/source/basmgr/basmgr.cxx +++ b/basic/source/basmgr/basmgr.cxx @@ -20,7 +20,7 @@ #include #include #include -#include +#include #include #include #include @@ -851,7 +851,7 @@ void BasicManager::LoadOldBasicManager( SotStorage& rStorage ) BasicManager::~BasicManager() { // Notify listener if something needs to be saved - Broadcast( SfxSimpleHint( SFX_HINT_DYING) ); + Broadcast( SfxHint( SFX_HINT_DYING) ); } void BasicManager::LegacyDeleteBasicManager( BasicManager*& _rpManager ) -- cgit