From d977e02ec6350115c39f03d588539e8bd423a1c3 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Thu, 9 Aug 2018 16:30:57 +0200 Subject: unnecessary null check before dynamic_cast, in various Change-Id: I76ad0b3152030c29ee28f6a6cc80d0832188d02b Reviewed-on: https://gerrit.libreoffice.org/58774 Tested-by: Jenkins Reviewed-by: Noel Grandin --- basic/source/runtime/methods1.cxx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'basic/source/runtime/methods1.cxx') diff --git a/basic/source/runtime/methods1.cxx b/basic/source/runtime/methods1.cxx index 4b59ea081c28..7f5ab0233096 100644 --- a/basic/source/runtime/methods1.cxx +++ b/basic/source/runtime/methods1.cxx @@ -123,7 +123,7 @@ void SbRtl_CallByName(StarBASIC *, SbxArray & rPar, bool) SbxObject* pObj = nullptr; if( pObjVar ) pObj = dynamic_cast( pObjVar ); - if( !pObj && pObjVar && dynamic_cast( pObjVar) != nullptr ) + if( !pObj && dynamic_cast( pObjVar) ) { SbxBase* pObjVarObj = static_cast(pObjVar)->GetObject(); pObj = dynamic_cast( pObjVarObj ); @@ -864,7 +864,7 @@ void SbRtl_FindPropertyObject(StarBASIC *, SbxArray & rPar, bool) { pObj = dynamic_cast( pObjVar ); } - if( !pObj && pObjVar && dynamic_cast( pObjVar) != nullptr ) + if( !pObj && dynamic_cast( pObjVar) ) { SbxBase* pObjVarObj = static_cast(pObjVar)->GetObject(); pObj = dynamic_cast( pObjVarObj ); -- cgit