From 76a25639474c50c34a2b84ba1f357013de5ddae8 Mon Sep 17 00:00:00 2001
From: Mike Kaganski <mike.kaganski@collabora.com>
Date: Fri, 19 Oct 2018 21:22:23 +0200
Subject: tdf#120703 (PVS): redundant check

V547 Expression 'aData.eType == SbxDECIMAL' is always true

Change-Id: I37bf367221ced7bf1c53bcd5138ae7bac656da52
Reviewed-on: https://gerrit.libreoffice.org/62030
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
---
 basic/source/sbx/sbxvalue.cxx | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

(limited to 'basic/source')

diff --git a/basic/source/sbx/sbxvalue.cxx b/basic/source/sbx/sbxvalue.cxx
index dba938e96eec..05e8773aab9f 100644
--- a/basic/source/sbx/sbxvalue.cxx
+++ b/basic/source/sbx/sbxvalue.cxx
@@ -164,8 +164,7 @@ void SbxValue::Clear()
             }
             break;
         case SbxDECIMAL:
-            if( aData.eType == SbxDECIMAL )
-                releaseDecimalPtr( aData.pDecimal );
+            releaseDecimalPtr( aData.pDecimal );
             break;
         case SbxDATAOBJECT:
             aData.pData = nullptr; break;
-- 
cgit