From 049e026755f7c36c7594bf4e7891603930669a54 Mon Sep 17 00:00:00 2001
From: Noel Grandin <noel.grandin@collabora.co.uk>
Date: Tue, 7 Nov 2017 15:01:52 +0200
Subject: loplugin:finalclasses in basic,basegfx

Change-Id: Iff223782fa0ded0fe46b8b7af35bfd21f331015f
Reviewed-on: https://gerrit.libreoffice.org/44535
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
---
 basic/inc/sbstdobj.hxx        | 10 +++-------
 basic/source/inc/namecont.hxx |  6 +++---
 basic/source/inc/symtbl.hxx   |  3 +--
 3 files changed, 7 insertions(+), 12 deletions(-)

(limited to 'basic')

diff --git a/basic/inc/sbstdobj.hxx b/basic/inc/sbstdobj.hxx
index 8fe8c336b848..ba2190b143e2 100644
--- a/basic/inc/sbstdobj.hxx
+++ b/basic/inc/sbstdobj.hxx
@@ -35,9 +35,8 @@ public:
 };
 
 // class SbStdPicture
-class BASIC_DLLPUBLIC SbStdPicture : public SbxObject
+class BASIC_DLLPUBLIC SbStdPicture final : public SbxObject
 {
-protected:
     Graphic     aGraphic;
 
     virtual ~SbStdPicture() override;
@@ -56,9 +55,8 @@ public:
 };
 
 // class SbStdFont
-class BASIC_DLLPUBLIC SbStdFont : public SbxObject
+class BASIC_DLLPUBLIC SbStdFont final : public SbxObject
 {
-protected:
     bool    bBold;
     bool    bItalic;
     bool    bStrikeThrough;
@@ -94,10 +92,8 @@ public:
 };
 
 // class SbStdClipboard
-class BASIC_DLLPUBLIC SbStdClipboard : public SbxObject
+class BASIC_DLLPUBLIC SbStdClipboard final : public SbxObject
 {
-protected:
-
     virtual ~SbStdClipboard() override;
     virtual void   Notify( SfxBroadcaster& rBC, const SfxHint& rHint ) override;
 
diff --git a/basic/source/inc/namecont.hxx b/basic/source/inc/namecont.hxx
index 72016292713f..203660ae6ff0 100644
--- a/basic/source/inc/namecont.hxx
+++ b/basic/source/inc/namecont.hxx
@@ -613,13 +613,13 @@ public:
 };
 
 
-class ScriptExtensionIterator
+class ScriptExtensionIterator final
 {
 public:
     ScriptExtensionIterator();
     OUString nextBasicOrDialogLibrary( bool& rbPureDialogLib );
 
-protected:
+private:
     css::uno::Reference< css::deployment::XPackage >
         implGetNextUserScriptPackage( bool& rbPureDialogLib );
     css::uno::Reference< css::deployment::XPackage >
@@ -648,7 +648,7 @@ protected:
 
     int m_iUserPackage;
     int m_iSharedPackage;
-       int m_iBundledPackage;
+    int m_iBundledPackage;
 
     ScriptSubPackageIterator* m_pScriptSubPackageIterator;
 
diff --git a/basic/source/inc/symtbl.hxx b/basic/source/inc/symtbl.hxx
index 5ff54d2f87af..64a11ea814f3 100644
--- a/basic/source/inc/symtbl.hxx
+++ b/basic/source/inc/symtbl.hxx
@@ -46,10 +46,9 @@ public:
 };
 
 
-class SbiSymPool {
+class SbiSymPool final {
     friend class SbiSymDef;
     friend class SbiProcDef;
-protected:
     SbiStringPool& rStrings;
     std::vector<std::unique_ptr<SbiSymDef>> m_Data;
     SbiSymPool*    pParent;
-- 
cgit