From 14cd5182c5f64c43581c82db8c958369152226ac Mon Sep 17 00:00:00 2001 From: Stephan Bergmann Date: Tue, 10 May 2016 16:42:16 +0200 Subject: Replace fallthrough comments with new SAL_FALLTHROUGH macro ...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca --- basic/source/comp/loops.cxx | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'basic') diff --git a/basic/source/comp/loops.cxx b/basic/source/comp/loops.cxx index ae973d4677ad..4eaf4f86b7f7 100644 --- a/basic/source/comp/loops.cxx +++ b/basic/source/comp/loops.cxx @@ -546,7 +546,8 @@ void SbiParser::Resume() { aGen.Gen( SbiOpcode::RESUME_, 0 ); break; - } // fall through + } + SAL_FALLTHROUGH; case SYMBOL: if( MayBeLabel() ) { @@ -554,7 +555,8 @@ void SbiParser::Resume() aGen.Gen( SbiOpcode::RESUME_, nLbl ); Next(); break; - } // fall through + } + SAL_FALLTHROUGH; default: Error( ERRCODE_BASIC_LABEL_EXPECTED ); } -- cgit