From e2451bd729d0f1d795a5b689deba65bc4e9d92c6 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Fri, 25 Oct 2013 16:43:20 +0200 Subject: Convert indexOf->startsWith and lastIndexOf->endsWith This is both an optimisation and a cleanup. This converts code like aStr.indexOf("XX") == 0 to aStr.startsWith("XX") and converts code like aStr.lastIndexOf("XXX") == aStr.getLength() - 3 to aStr.endsWith("XXX") Note that in general aStr.lastIndexOf("X") == aStr.getLength() - 1 converts to aStr.isEmpty() || aStr.endsWith("X") so I used the surrounding context to determine if aStr could be empty when modifying the code. Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669 --- basic/source/runtime/runtime.cxx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'basic') diff --git a/basic/source/runtime/runtime.cxx b/basic/source/runtime/runtime.cxx index a2c55a811aaf..6cd204ef5855 100644 --- a/basic/source/runtime/runtime.cxx +++ b/basic/source/runtime/runtime.cxx @@ -3387,7 +3387,7 @@ SbxVariable* SbiRuntime::FindElement( SbxObject* pObj, sal_uInt32 nOp1, sal_uInt OUString aName( pImg->GetString( static_cast( nOp1 & 0x7FFF ) ) ); // Hacky capture of Evaluate [] syntax // this should be tackled I feel at the pcode level - if ( bIsVBAInterOp && aName.indexOf((sal_Unicode)'[') == 0 ) + if ( bIsVBAInterOp && aName.startsWith("[") ) { // emulate pcode here StepARGC(); -- cgit option> LibreOffice 核心代码仓库文档基金会
summaryrefslogtreecommitdiff
'>8
AgeCommit message (Expand)Author
2018-08-15Port main/xmlhelp to gbuild.Damjan Jovanovic
space:
mode:
authorMatthias Seidel <mseidel@apache.org>2019-08-02 18:03:42 +0000
committerMatthias Seidel <mseidel@apache.org>2019-08-02 18:03:42 +0000
commitcc36ea775eb22fd95e3e746f1912264763faf57d (patch)
treeda554fbaebed2dce1707ea304adf1b2f8376160c /connectivity/source/inc/adabas/BIndex.hxx
parentaf40db04de2f5073bd31fb4b7305fc6ff98970ff (diff)
Cleaned up whitespace, reordered Increase/Decrease Indent in sidebar aoo/trunk
Notes
Notes: ignore: obsolete