From 28726190d52b0729339d7257b84b449fafa4c34e Mon Sep 17 00:00:00 2001 From: Gabor Kelemen Date: Thu, 6 Dec 2018 00:17:03 +0100 Subject: find-unneeded-includes: Avoid proposing o3tl fw declaration This does not really work: even when it seems to, it compiles only because of transitive includes - Filter o3tl/typed_flags_set.hxx in f-u-u - Remove already added fw declarations from hxx files and include full header just in case - Remove now unnecessary blacklist entries Change-Id: Ie0de6667af697095a623b435806449e7e28a6004 Reviewed-on: https://gerrit.libreoffice.org/64659 Tested-by: Jenkins Reviewed-by: Miklos Vajna --- bin/find-unneeded-includes | 8 ++++++++ 1 file changed, 8 insertions(+) (limited to 'bin') diff --git a/bin/find-unneeded-includes b/bin/find-unneeded-includes index ecc29fe32919..b7da51714bb0 100755 --- a/bin/find-unneeded-includes +++ b/bin/find-unneeded-includes @@ -63,6 +63,14 @@ def ignoreRemoval(include, toAdd, absFileName, moduleRules): if include == k and v in toAdd: return True + # Avoid proposing o3tl fw declaration + o3tl = { + "o3tl/typed_flags_set.hxx" : "namespace o3tl { template struct typed_flags; }", + } + for k, v, in o3tl.items(): + if include == k and v in toAdd: + return True + # Follow boost documentation. if include == "boost/optional.hpp" and "boost/optional/optional.hpp" in toAdd: return True -- cgit