From cd2d737dd5b1d46261a9aa6c5caae57347a287af Mon Sep 17 00:00:00 2001
From: Gökçen Eraslan <gokcen.eraslan@gmail.com>
Date: Tue, 17 Apr 2012 12:04:05 +0300
Subject: Fix handling of deleted bugzilla attachments

As in https://bugs.kde.org/show_bug.cgi?ctype=xml&id=53343 <data>
tag may not have a value if the attachment is deleted.
---
 bin/get-bugzilla-attachments-by-mimetype | 5 +++++
 1 file changed, 5 insertions(+)

(limited to 'bin')

diff --git a/bin/get-bugzilla-attachments-by-mimetype b/bin/get-bugzilla-attachments-by-mimetype
index b9488b94806f..7c779579e6a4 100755
--- a/bin/get-bugzilla-attachments-by-mimetype
+++ b/bin/get-bugzilla-attachments-by-mimetype
@@ -77,6 +77,11 @@ def get_from_bug_url_via_xml(url, mimetype, prefix, suffix):
                         print 'skipping'
                         break
                 elif node.nodeName == 'data':
+                    # check if attachment is deleted (i.e. https://bugs.kde.org/show_bug.cgi?id=53343&ctype=xml)
+                    if not node.firstChild:
+                        print 'deleted attachment, skipping'
+                        continue
+
                     download = suffix + '/' +prefix + id + '-' + str(attachmentid) + '.' + suffix
                     print 'downloading as', download
                     f = open(download, 'w')
-- 
cgit