From b14224fe97b8a44232c9c1401d3a49771f46582e Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Tue, 2 Feb 2016 16:15:51 +0200 Subject: loplugin:unusedmethods using an idea from dtardon: noelgrandin, hi. could you try to run the unusedmethods clang plugin with "make build-nocheck"? that would catch functions that are only used in tests. e.g., i just removed the whole o3tl::range class, which has not been used in many years, but htere was a test for it... dtardon, interesting idea! Sure, I can do that. Change-Id: I5653953a426a2186a1e43017212d87ffce520387 Reviewed-on: https://gerrit.libreoffice.org/22041 Reviewed-by: Noel Grandin Tested-by: Noel Grandin --- binaryurp/source/lessoperators.cxx | 22 ---------------------- binaryurp/source/lessoperators.hxx | 4 ---- 2 files changed, 26 deletions(-) (limited to 'binaryurp') diff --git a/binaryurp/source/lessoperators.cxx b/binaryurp/source/lessoperators.cxx index 6d8952de810f..66375178be71 100644 --- a/binaryurp/source/lessoperators.cxx +++ b/binaryurp/source/lessoperators.cxx @@ -42,28 +42,6 @@ bool operator <(TypeDescription const & left, TypeDescription const & right) { OUString::unacquired(&right.get()->pTypeName))); } -bool TypeDescEqual::operator()( const TypeDescription& rLeft, const TypeDescription& rRight) const -{ - assert( rLeft.is() && rRight.is()); - const typelib_TypeDescription& rA = *rLeft.get(); - const typelib_TypeDescription& rB = *rRight.get(); - if( rA.eTypeClass != rB.eTypeClass) - return false; - const sal_Int32 nCmp = rtl_ustr_compare_WithLength( - rA.pTypeName->buffer, rA.pTypeName->length, - rB.pTypeName->buffer, rB.pTypeName->length); - return (nCmp == 0); -} - -sal_Int32 TypeDescHash::operator()( const TypeDescription& rTD) const -{ - assert( rTD.is()); - const typelib_TypeDescription& rA = *rTD.get(); - sal_Int32 h = rtl_ustr_hashCode_WithLength( rA.pTypeName->buffer, rA.pTypeName->length); - h ^= static_cast(rA.eTypeClass); - return h; -} - } } } } namespace rtl { diff --git a/binaryurp/source/lessoperators.hxx b/binaryurp/source/lessoperators.hxx index 317e76ab18d5..f3202b5fb5af 100644 --- a/binaryurp/source/lessoperators.hxx +++ b/binaryurp/source/lessoperators.hxx @@ -31,10 +31,6 @@ namespace com { namespace sun { namespace star { namespace uno { bool operator <(TypeDescription const & left, TypeDescription const & right); -struct TypeDescHash { sal_Int32 operator()( const TypeDescription&) const; }; - -struct TypeDescEqual { bool operator()( const TypeDescription&, const TypeDescription&) const; }; - } } } } namespace rtl { -- cgit