From 268be3ac88bd9572b2402ecdb7bed04038fe6999 Mon Sep 17 00:00:00 2001 From: Stephan Bergmann Date: Wed, 12 Mar 2014 11:48:17 +0100 Subject: Mark overriding DisambiguationHelper class template mem funs as SAL_OVERRIDE ...which reveals that some uses are not derived from XEventListener, so re- introduce BaseMutexHelper as an alternative (which originally got superseded by DisambiguationHelper in 09b546cf9c1d0d9f78066e70a0348c7678cdcb14 "Fix overloaded-virtual warning in canvas"). Change-Id: I1418370733b72526ec481b70fa69f03e7c28b7ce --- canvas/source/cairo/cairo_canvas.hxx | 6 +++--- canvas/source/cairo/cairo_canvasbitmap.hxx | 5 +++-- canvas/source/cairo/cairo_canvascustomsprite.hxx | 6 +++--- canvas/source/cairo/cairo_spritecanvas.hxx | 2 +- 4 files changed, 10 insertions(+), 9 deletions(-) (limited to 'canvas/source/cairo') diff --git a/canvas/source/cairo/cairo_canvas.hxx b/canvas/source/cairo/cairo_canvas.hxx index 945bf5f2b568..96eb1e715c3b 100644 --- a/canvas/source/cairo/cairo_canvas.hxx +++ b/canvas/source/cairo/cairo_canvas.hxx @@ -38,7 +38,7 @@ #include #include -#include +#include #include #include @@ -60,7 +60,7 @@ namespace cairocanvas ::com::sun::star::util::XUpdatable, ::com::sun::star::beans::XPropertySet, ::com::sun::star::lang::XServiceName > GraphicDeviceBase_Base; - typedef ::canvas::GraphicDeviceBase< ::canvas::DisambiguationHelper< GraphicDeviceBase_Base >, + typedef ::canvas::GraphicDeviceBase< ::canvas::BaseMutexHelper< GraphicDeviceBase_Base >, DeviceHelper, ::osl::MutexGuard, ::cppu::OWeakObject > CanvasBase_Base; @@ -116,7 +116,7 @@ namespace cairocanvas ~Canvas(); /// Dispose all internal references - virtual void disposeThis(); + virtual void disposeThis() SAL_OVERRIDE; // Forwarding the XComponent implementation to the // cppu::ImplHelper templated base diff --git a/canvas/source/cairo/cairo_canvasbitmap.hxx b/canvas/source/cairo/cairo_canvasbitmap.hxx index f67a955daded..1f074cf0292a 100644 --- a/canvas/source/cairo/cairo_canvasbitmap.hxx +++ b/canvas/source/cairo/cairo_canvasbitmap.hxx @@ -32,6 +32,7 @@ #include +#include #include #include "cairo_cairo.hxx" @@ -49,7 +50,7 @@ namespace cairocanvas ::com::sun::star::lang::XServiceInfo, ::com::sun::star::beans::XFastPropertySet > CanvasBitmapBase_Base; class CanvasBitmapSpriteSurface_Base : - public ::canvas::DisambiguationHelper, + public ::canvas::BaseMutexHelper, public SurfaceProvider { }; @@ -79,7 +80,7 @@ namespace cairocanvas bool bHasAlpha ); /// Dispose all internal references - virtual void disposeThis(); + virtual void disposeThis() SAL_OVERRIDE; // Forwarding the XComponent implementation to the // cppu::ImplHelper templated base diff --git a/canvas/source/cairo/cairo_canvascustomsprite.hxx b/canvas/source/cairo/cairo_canvascustomsprite.hxx index 65e0040a0870..5a324881b032 100644 --- a/canvas/source/cairo/cairo_canvascustomsprite.hxx +++ b/canvas/source/cairo/cairo_canvascustomsprite.hxx @@ -33,7 +33,7 @@ #include #include -#include +#include #include #include "cairo_sprite.hxx" @@ -67,7 +67,7 @@ namespace cairocanvas remain a base class that provides implementation, not to enforce any specific interface on its derivees. */ - class CanvasCustomSpriteSpriteBase_Base : public ::canvas::DisambiguationHelper< CanvasCustomSpriteBase_Base >, + class CanvasCustomSpriteSpriteBase_Base : public ::canvas::BaseMutexHelper< CanvasCustomSpriteBase_Base >, public Sprite, public SurfaceProvider { @@ -102,7 +102,7 @@ namespace cairocanvas CanvasCustomSprite( const ::com::sun::star::geometry::RealSize2D& rSpriteSize, const SpriteCanvasRef& rRefDevice ); - virtual void disposeThis(); + virtual void disposeThis() SAL_OVERRIDE; // Forwarding the XComponent implementation to the // cppu::ImplHelper templated base diff --git a/canvas/source/cairo/cairo_spritecanvas.hxx b/canvas/source/cairo/cairo_spritecanvas.hxx index 6869881e7a42..95ff09f08ce4 100644 --- a/canvas/source/cairo/cairo_spritecanvas.hxx +++ b/canvas/source/cairo/cairo_spritecanvas.hxx @@ -113,7 +113,7 @@ namespace cairocanvas void initialize(); /// Dispose all internal references - virtual void disposeThis(); + virtual void disposeThis() SAL_OVERRIDE; // Forwarding the XComponent implementation to the // cppu::ImplHelper templated base -- cgit