From 637cceeefba0b0e2e09ac734bb0327364e8ddd25 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Fri, 24 Mar 2023 10:09:16 +0200 Subject: loplugin:stringadd in c* after my patch to merge the bufferadd loplugin into stringadd Change-Id: I66f4ce2fd87c1e12eefb14406e0e17212f68ceff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149497 Tested-by: Jenkins Reviewed-by: Noel Grandin --- chart2/source/tools/ObjectIdentifier.cxx | 13 ++++--------- chart2/source/tools/StatisticsHelper.cxx | 3 +-- 2 files changed, 5 insertions(+), 11 deletions(-) (limited to 'chart2/source/tools') diff --git a/chart2/source/tools/ObjectIdentifier.cxx b/chart2/source/tools/ObjectIdentifier.cxx index 587aace2f3d8..883c115126cb 100644 --- a/chart2/source/tools/ObjectIdentifier.cxx +++ b/chart2/source/tools/ObjectIdentifier.cxx @@ -90,15 +90,13 @@ OUString lcl_createClassificationStringForType( ObjectType eObjectType { if( !aRet.isEmpty() ) aRet.append(":"); - aRet.append( m_aDragMethodEquals ); - aRet.append( rDragMethodServiceName ); + aRet.append( OUString::Concat(m_aDragMethodEquals) + rDragMethodServiceName ); if( !rDragParameterString.empty() ) { if( !aRet.isEmpty() ) aRet.append(":"); - aRet.append( m_aDragParameterEquals ); - aRet.append( rDragParameterString ); + aRet.append( OUString::Concat(m_aDragParameterEquals) + rDragParameterString ); } } return aRet.makeStringAndClear(); @@ -584,9 +582,7 @@ OUString ObjectIdentifier::createClassifiedIdentifierWithParent( if(!rParentPartical.empty()) aRet.append(":"); - aRet.append(getStringForType( eObjectType )); - aRet.append("="); - aRet.append(rParticleID); + aRet.append(getStringForType( eObjectType ) + "=" + rParticleID); return aRet.makeStringAndClear(); } @@ -1014,8 +1010,7 @@ OUString ObjectIdentifier::createChildParticleWithIndex( ObjectType eObjectType, OUStringBuffer aRet( getStringForType( eObjectType ) ); if( !aRet.isEmpty() ) { - aRet.append("="); - aRet.append(nIndex); + aRet.append("=" + OUString::number(nIndex)); } return aRet.makeStringAndClear(); } diff --git a/chart2/source/tools/StatisticsHelper.cxx b/chart2/source/tools/StatisticsHelper.cxx index e97475915705..1336f471432c 100644 --- a/chart2/source/tools/StatisticsHelper.cxx +++ b/chart2/source/tools/StatisticsHelper.cxx @@ -82,8 +82,7 @@ uno::Reference< chart2::data::XLabeledDataSequence > lcl_getErrorBarLabeledSeque aRole.append( 'x'); OUString aPlainRole = aRole.makeStringAndClear(); - aRole.append( aPlainRole ); - aRole.append( '-' ); + aRole.append( aPlainRole + "-" ); if( bPositiveValue ) aRole.append( "positive" ); -- cgit