From 0ac722ccdf75c1d1e8f8cc6c031238a44a5edb0b Mon Sep 17 00:00:00 2001
From: Caolán McNamara <caolanm@redhat.com>
Date: Wed, 8 Oct 2014 14:52:48 +0100
Subject: coverity#1237352 Dereference after null check

Change-Id: Ia9cb84bb0924915d4611c5f18d2a0d19b4198d94
---
 chart2/source/view/charttypes/GL3DBarChart.cxx | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

(limited to 'chart2/source')

diff --git a/chart2/source/view/charttypes/GL3DBarChart.cxx b/chart2/source/view/charttypes/GL3DBarChart.cxx
index ec5855d6670a..cd2738460ad2 100755
--- a/chart2/source/view/charttypes/GL3DBarChart.cxx
+++ b/chart2/source/view/charttypes/GL3DBarChart.cxx
@@ -570,11 +570,7 @@ GL3DBarChart::GL3DBarChart(
         osl_getSystemTime(&maDataUpdateStartTime);
         osl_getSystemTime(&maDataUpdateEndTime);
     }
-    Size aSize;
-    if (mpWindow)
-    {
-        aSize = mpWindow->GetSizePixel();
-    }
+    Size aSize = mpWindow->GetSizePixel();
     mpRenderer->SetSize(aSize);
     mpWindow->setRenderer(this);
     mpWindow->getContext().makeCurrent();
@@ -602,7 +598,7 @@ GL3DBarChart::~GL3DBarChart()
 
     joinRenderThread();
 
-    if(mbValidContext && mpWindow)
+    if(mbValidContext)
         mpWindow->setRenderer(NULL);
 }
 
-- 
cgit