From 0c3bd1d482ece1f2217cc87069179161f6a5bb56 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Mon, 14 Aug 2017 08:28:13 +0200 Subject: new loplugin:droplong The types 'long' and 'unsigned long' are different sizes on different platforms, making them wholy unsuitable for portable code. And when I mean different sizes, I mean 64bit Linux and 64bit Windows have different bit sizes. Change-Id: Id4d8cd709bf71a3f85ed6515fae2b0a21ae8c25d Reviewed-on: https://gerrit.libreoffice.org/41130 Tested-by: Jenkins Reviewed-by: Noel Grandin --- codemaker/source/cppumaker/cppuoptions.cxx | 2 +- codemaker/source/javamaker/javaoptions.cxx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'codemaker/source') diff --git a/codemaker/source/cppumaker/cppuoptions.cxx b/codemaker/source/cppumaker/cppuoptions.cxx index d6f31e89aeee..b399de19147e 100644 --- a/codemaker/source/cppumaker/cppuoptions.cxx +++ b/codemaker/source/cppumaker/cppuoptions.cxx @@ -278,7 +278,7 @@ bool CppuOptions::initOptions(int ac, char* av[], bool bCmdFile) ret = initOptions(rargc, rargv, bCmdFile); - for (long j=0; j < rargc; j++) + for (int j=0; j < rargc; j++) { free(rargv[j]); } diff --git a/codemaker/source/javamaker/javaoptions.cxx b/codemaker/source/javamaker/javaoptions.cxx index a09107a99b53..08c5a7f4dbf8 100644 --- a/codemaker/source/javamaker/javaoptions.cxx +++ b/codemaker/source/javamaker/javaoptions.cxx @@ -208,7 +208,7 @@ bool JavaOptions::initOptions(int ac, char* av[], bool bCmdFile) ret = initOptions(rargc, rargv, bCmdFile); - for (long j=0; j < rargc; j++) + for (int j=0; j < rargc; j++) { free(rargv[j]); } -- cgit