From 8fced917aa1af58216cbde56720f2f473eed86d9 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Wed, 19 Apr 2017 13:10:54 +0200 Subject: clang-tidy readability-simplify-boolean-expr in accessibility..cui Change-Id: Iae27da322c6ede592e6b268fb2210d3525ed22cc Reviewed-on: https://gerrit.libreoffice.org/36677 Tested-by: Jenkins Reviewed-by: Noel Grandin --- comphelper/source/misc/backupfilehelper.cxx | 21 +++------------------ 1 file changed, 3 insertions(+), 18 deletions(-) (limited to 'comphelper/source/misc/backupfilehelper.cxx') diff --git a/comphelper/source/misc/backupfilehelper.cxx b/comphelper/source/misc/backupfilehelper.cxx index 7e5c2dbc7ff9..da131acafdd4 100644 --- a/comphelper/source/misc/backupfilehelper.cxx +++ b/comphelper/source/misc/backupfilehelper.cxx @@ -137,12 +137,7 @@ namespace aArray[2] = sal_uInt8((nSource & 0x0000ff00) >> 8); aArray[3] = sal_uInt8(nSource & 0x000000ff); - if (osl_File_E_None == osl_writeFile(rHandle, static_cast(aArray), 4, &nBaseWritten) && 4 == nBaseWritten) - { - return true; - } - - return false; + return osl_File_E_None == osl_writeFile(rHandle, static_cast(aArray), 4, &nBaseWritten) && 4 == nBaseWritten; } bool read_OString(FileSharedPtr& rFile, OString& rTarget) @@ -178,12 +173,7 @@ namespace sal_uInt64 nBaseWritten(0); - if (osl_File_E_None == osl_writeFile(rHandle, static_cast(rSource.getStr()), nLength, &nBaseWritten) && nLength == nBaseWritten) - { - return true; - } - - return false; + return osl_File_E_None == osl_writeFile(rHandle, static_cast(rSource.getStr()), nLength, &nBaseWritten) && nLength == nBaseWritten; } OUString createFileURL(const OUString& rURL, const OUString& rName, const OUString& rExt) @@ -535,12 +525,7 @@ namespace // write mbEnabled nState = static_cast< sal_uInt32 >(mbEnabled); - if (!write_sal_uInt32(rHandle, nState)) - { - return false; - } - - return true; + return write_sal_uInt32(rHandle, nState); } const OString& getName() const -- cgit