From 78dac9f19460b92da3e56214cd5833c7407ab0f2 Mon Sep 17 00:00:00 2001
From: Noel <noelgrandin@gmail.com>
Date: Fri, 6 Nov 2020 12:24:37 +0200
Subject: retire the stringbuffer loplugin

the best code is now the opposite of what this plugin recommends

Change-Id: I88c04200c73a9bae07ef8fcf6ba5f1d9e4927709
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105394
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
---
 compilerplugins/clang/store/stringbuffer.cxx | 76 ++++++++++++++++++++++++++++
 1 file changed, 76 insertions(+)
 create mode 100644 compilerplugins/clang/store/stringbuffer.cxx

(limited to 'compilerplugins/clang/store')

diff --git a/compilerplugins/clang/store/stringbuffer.cxx b/compilerplugins/clang/store/stringbuffer.cxx
new file mode 100644
index 000000000000..61df3069a51c
--- /dev/null
+++ b/compilerplugins/clang/store/stringbuffer.cxx
@@ -0,0 +1,76 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+#ifndef LO_CLANG_SHARED_PLUGINS
+
+#include "check.hxx"
+#include "compat.hxx"
+#include "plugin.hxx"
+#include <vector>
+
+/** Look for appending result of adding OUString/OString to OUStringBuffer
+ */
+namespace
+{
+class StringBuffer : public loplugin::FilteringPlugin<StringBuffer>
+{
+public:
+    explicit StringBuffer(loplugin::InstantiationData const& rData)
+        : FilteringPlugin(rData)
+    {
+    }
+
+    bool preRun() override
+    {
+        StringRef fn(handler.getMainFileName());
+        return !loplugin::hasPathnamePrefix(fn, SRCDIR "/sal/qa/");
+    }
+
+    void run() override
+    {
+        if (preRun())
+        {
+            TraverseDecl(compiler.getASTContext().getTranslationUnitDecl());
+        }
+    }
+
+    bool VisitCXXMemberCallExpr(CXXMemberCallExpr const*);
+};
+
+bool StringBuffer::VisitCXXMemberCallExpr(CXXMemberCallExpr const* memberCallExpr)
+{
+    if (ignoreLocation(memberCallExpr))
+        return true;
+    if (!loplugin::DeclCheck(memberCallExpr->getRecordDecl())
+             .Class("OUStringBuffer")
+             .Namespace("rtl")
+             .GlobalNamespace())
+        return true;
+    if (!memberCallExpr->getMethodDecl()->getIdentifier())
+        return true;
+    if (memberCallExpr->getMethodDecl()->getName() != "append")
+        return true;
+    auto matTemp = dyn_cast<MaterializeTemporaryExpr>(memberCallExpr->getArg(0));
+    if (!matTemp)
+        return true;
+    if (!isa<CXXOperatorCallExpr>(compat::getSubExpr(matTemp)))
+        return true;
+    report(DiagnosticsEngine::Warning,
+           "appending added result of OUString to OUStringBuffer, rather do .append(x).append(y)",
+           compat::getBeginLoc(memberCallExpr))
+        << memberCallExpr->getSourceRange();
+    return true;
+}
+
+loplugin::Plugin::Registration<StringBuffer> stringbuffer("stringbuffer", false);
+
+} // namespace
+
+#endif // LO_CLANG_SHARED_PLUGINS
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
-- 
cgit