From abe39f7781f59b96c5a8d3dd5b41c60fdf04ad84 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Fri, 6 Mar 2020 14:40:40 +0200 Subject: improve loplugin:unusedfields noticed something that wasn't being picked up, wrote some tests, and found an unhandled case in Plugin::getParentFunctionDecl Change-Id: I52b4ea273be6614e197392dfc4d6053bbc1704de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90141 Tested-by: Jenkins Reviewed-by: Noel Grandin --- .../clang/unusedfields.readonly.results | 42 ++++++++++------------ 1 file changed, 19 insertions(+), 23 deletions(-) (limited to 'compilerplugins/clang/unusedfields.readonly.results') diff --git a/compilerplugins/clang/unusedfields.readonly.results b/compilerplugins/clang/unusedfields.readonly.results index 3071b96d5a38..25a153d86200 100644 --- a/compilerplugins/clang/unusedfields.readonly.results +++ b/compilerplugins/clang/unusedfields.readonly.results @@ -174,17 +174,17 @@ dbaccess/source/core/api/RowSetBase.hxx:96 dbaccess::ORowSetBase m_aErrors ::connectivity::SQLError dbaccess/source/core/dataaccess/documentcontainer.cxx:67 dbaccess::(anonymous namespace)::LocalNameApproval m_aErrors ::connectivity::SQLError -dbaccess/source/core/inc/ContentHelper.hxx:109 +dbaccess/source/core/inc/ContentHelper.hxx:105 dbaccess::OContentHelper m_aErrorHelper const ::connectivity::SQLError -dbaccess/source/filter/hsqldb/parseschema.hxx:36 +dbaccess/source/filter/hsqldb/parseschema.hxx:35 dbahsql::SchemaParser m_PrimaryKeys std::map > dbaccess/source/ui/control/tabletree.cxx:233 dbaui::(anonymous namespace)::OViewSetter m_aEqualFunctor ::comphelper::UStringMixEqual dbaccess/source/ui/inc/charsetlistbox.hxx:44 dbaui::CharSetListBox m_aCharSets class dbaui::OCharsetDisplay -dbaccess/source/ui/inc/directsql.hxx:65 +dbaccess/source/ui/inc/directsql.hxx:67 dbaui::DirectSQLDialog m_aColorConfig const svtools::ColorConfig -dbaccess/source/ui/inc/WCopyTable.hxx:261 +dbaccess/source/ui/inc/WCopyTable.hxx:259 dbaui::OCopyTableWizard m_aLocale css::lang::Locale drawinglayer/source/processor2d/vclprocessor2d.hxx:82 drawinglayer::processor2d::VclProcessor2D maDrawinglayerOpt const class SvtOptionsDrawinglayer @@ -341,7 +341,7 @@ include/svx/svdoedge.hxx:160 include/svx/svdpntv.hxx:160 SdrPaintView maDrawinglayerOpt const class SvtOptionsDrawinglayer include/unoidl/unoidl.hxx:443 - unoidl::ConstantValue union unoidl::ConstantValue::(anonymous at /media/disk2/libo4/include/unoidl/unoidl.hxx:443:5) + unoidl::ConstantValue union unoidl::ConstantValue::(anonymous at /home/noel/libo2/include/unoidl/unoidl.hxx:443:5) include/unoidl/unoidl.hxx:444 unoidl::ConstantValue::(anonymous) booleanValue _Bool include/unoidl/unoidl.hxx:445 @@ -372,7 +372,7 @@ io/source/stm/odata.cxx:578 io_stm::(anonymous namespace)::ODataOutputStream::writeDouble(double)::(anonymous union)::(anonymous) n2 sal_uInt32 io/source/stm/odata.cxx:578 io_stm::(anonymous namespace)::ODataOutputStream::writeDouble(double)::(anonymous union)::(anonymous) n1 sal_uInt32 -libreofficekit/qa/gtktiledviewer/gtv-lok-dialog.cxx:53 +libreofficekit/qa/gtktiledviewer/gtv-lok-dialog.cxx:46 (anonymous namespace)::GtvLokDialogPrivate m_nChildKeyModifier guint32 libreofficekit/source/gtk/lokdocview.cxx:86 (anonymous namespace)::LOKDocViewPrivateImpl m_bIsLoading _Bool @@ -419,17 +419,13 @@ sc/inc/attarray.hxx:68 sc/inc/compiler.hxx:129 ScRawToken::(anonymous union)::(anonymous) eItem const class ScTableRefToken::Item sc/inc/compiler.hxx:130 - ScRawToken::(anonymous) table const struct (anonymous struct at /media/disk2/libo4/sc/inc/compiler.hxx:127:9) + ScRawToken::(anonymous) table const struct (anonymous struct at /home/noel/libo2/sc/inc/compiler.hxx:127:9) sc/inc/compiler.hxx:135 ScRawToken::(anonymous) pMat class ScMatrix *const sc/inc/formulagroup.hxx:39 sc::FormulaGroupEntry::(anonymous) mpCells class ScFormulaCell **const sc/inc/reordermap.hxx:21 sc::ColRowReorderMapType maData sc::ColRowReorderMapType::DataType -sc/qa/extras/anchor.cxx:61 - sc_apitest::ScAnchorTest mxComponent uno::Reference -sc/qa/unit/scshapetest.cxx:43 - sc_apitest::ScShapeTest mxComponent uno::Reference sc/source/core/inc/adiasync.hxx:42 ScAddInAsync::(anonymous) pStr class rtl::OUString * sc/source/core/inc/interpre.hxx:102 @@ -598,13 +594,13 @@ sw/source/core/access/accfrmobjmap.hxx:100 SwAccessibleChildMap maMap std::map sw/source/core/access/acchypertextdata.hxx:40 SwAccessibleHyperTextData maMap std::map -sw/source/core/access/accmap.cxx:106 +sw/source/core/access/accmap.cxx:107 SwAccessibleContextMap_Impl maMap std::map -sw/source/core/access/accmap.cxx:291 +sw/source/core/access/accmap.cxx:290 SwAccessibleShapeMap_Impl maMap std::map -sw/source/core/access/accmap.cxx:648 +sw/source/core/access/accmap.cxx:647 SwAccessibleEventMap_Impl maMap std::map -sw/source/core/access/accmap.cxx:692 +sw/source/core/access/accmap.cxx:691 SwAccessibleSelectedParas_Impl maMap std::map sw/source/core/doc/swstylemanager.cxx:60 (anonymous namespace)::SwStyleManager aAutoCharPool class StylePool @@ -618,7 +614,7 @@ sw/source/core/text/inftxt.cxx:567 (anonymous namespace)::SwTransparentTextGuard m_aContentVDev ScopedVclPtrInstance sw/source/core/text/redlnitr.hxx:76 SwRedlineItr m_pSet std::unique_ptr -sw/source/filter/html/htmltab.cxx:2834 +sw/source/filter/html/htmltab.cxx:2835 CellSaveStruct m_xCnts std::shared_ptr sw/source/filter/inc/rtf.hxx:32 RTFSurround::(anonymous) nVal sal_uInt8 @@ -730,7 +726,7 @@ vcl/inc/salwtype.hxx:205 SalSurroundingTextSelectionChangeEvent mnEnd const sal_uLong vcl/inc/salwtype.hxx:211 SalQueryCharPositionEvent mnCharPos sal_uLong -vcl/inc/svdata.hxx:278 +vcl/inc/svdata.hxx:316 ImplSVNWFData mbMenuBarDockingAreaCommonBG _Bool vcl/inc/toolbox.h:108 vcl::ToolBoxLayoutData m_aLineItemIds std::vector @@ -898,15 +894,15 @@ vcl/source/control/roadmapwizard.cxx:62 vcl::RoadmapWizardImpl aStateDescriptors vcl::(anonymous namespace)::StateDescriptions vcl/source/control/tabctrl.cxx:78 ImplTabCtrlData maLayoutPageIdToLine std::unordered_map -vcl/source/filter/jpeg/Exif.hxx:51 +vcl/source/filter/jpeg/Exif.hxx:53 Exif::ExifIFD tag sal_uInt8 [2] -vcl/source/filter/jpeg/Exif.hxx:52 +vcl/source/filter/jpeg/Exif.hxx:54 Exif::ExifIFD type sal_uInt8 [2] -vcl/source/filter/jpeg/Exif.hxx:53 +vcl/source/filter/jpeg/Exif.hxx:55 Exif::ExifIFD count sal_uInt8 [4] -vcl/source/filter/jpeg/Exif.hxx:54 +vcl/source/filter/jpeg/Exif.hxx:56 Exif::ExifIFD offset sal_uInt8 [4] -vcl/source/filter/jpeg/Exif.hxx:58 +vcl/source/filter/jpeg/Exif.hxx:60 Exif::TiffHeader byteOrder const sal_uInt16 vcl/source/filter/jpeg/transupp.h:132 (anonymous) slow_hflip boolean @@ -998,5 +994,5 @@ xmloff/source/chart/SchXMLChartContext.hxx:56 SeriesDefaultsAndStyles maPercentageErrorDefault const css::uno::Any xmloff/source/chart/SchXMLChartContext.hxx:57 SeriesDefaultsAndStyles maErrorMarginDefault const css::uno::Any -xmloff/source/core/xmlexp.cxx:262 +xmloff/source/core/xmlexp.cxx:264 SvXMLExport_Impl maSaveOptions const class SvtSaveOptions -- cgit