From 0e0fb5eaae14d7077c1bdce5bf45e50ed07bcd11 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Sat, 17 Aug 2019 08:48:51 +0200 Subject: loplugin:unnecessaryvirtual Change-Id: I9f2e524a4fb467ddc198fce1ff4740d3768ceeac Reviewed-on: https://gerrit.libreoffice.org/77618 Tested-by: Jenkins Reviewed-by: Noel Grandin --- .../clang/unnecessaryvirtual-dead.results | 16 ++--- compilerplugins/clang/unnecessaryvirtual.results | 84 ++++++++++++---------- 2 files changed, 53 insertions(+), 47 deletions(-) (limited to 'compilerplugins') diff --git a/compilerplugins/clang/unnecessaryvirtual-dead.results b/compilerplugins/clang/unnecessaryvirtual-dead.results index 29f7436169ff..7551aaea3325 100644 --- a/compilerplugins/clang/unnecessaryvirtual-dead.results +++ b/compilerplugins/clang/unnecessaryvirtual-dead.results @@ -4,25 +4,23 @@ include/basegfx/utils/unopolypolygon.hxx:97 void basegfx::unotools::UnoPolyPolygon::modifying()const include/canvas/base/bufferedgraphicdevicebase.hxx:108 void canvas::BufferedGraphicDeviceBase::destroyBuffers() -include/canvas/base/graphicdevicebase.hxx:300 +include/canvas/base/graphicdevicebase.hxx:306 void canvas::GraphicDeviceBase::removePropertyChangeListener(const class rtl::OUString &,const class com::sun::star::uno::Reference &,) -include/canvas/base/graphicdevicebase.hxx:313 +include/canvas/base/graphicdevicebase.hxx:319 void canvas::GraphicDeviceBase::removeVetoableChangeListener(const class rtl::OUString &,const class com::sun::star::uno::Reference &,) -sc/source/core/opencl/formulagroupcl.cxx:1061 +sc/source/core/opencl/formulagroupcl.cxx:1059 void sc::opencl::DynamicKernelSlidingArgument::GenSlidingWindowFunction(class std::__cxx11::basic_stringstream &,) slideshow/source/engine/animationfactory.cxx:443 void slideshow::internal::(anonymous namespace)::GenericAnimation::prefetch(const class std::shared_ptr &,const class std::shared_ptr &,) -vcl/inc/salframe.hxx:144 +vcl/inc/salframe.hxx:145 void SalFrame::SetRepresentedURL(const class rtl::OUString &,) -vcl/inc/salmenu.hxx:71 - void SalMenu::SetItemBits(unsigned int,enum MenuItemBits,) vcl/inc/salmenu.hxx:81 void SalMenu::RemoveMenuBarButton(unsigned short,) -vcl/inc/salobj.hxx:48 +vcl/inc/salobj.hxx:49 void SalObject::Enable(_Bool,) -vcl/inc/unx/saldata.hxx:68 +vcl/inc/unx/saldata.hxx:54 void X11SalData::initNWF() -vcl/inc/unx/saldata.hxx:69 +vcl/inc/unx/saldata.hxx:55 void X11SalData::deInitNWF() writerfilter/source/ooxml/OOXMLFactory.hxx:72 void writerfilter::ooxml::OOXMLFactory_ns::startAction(class writerfilter::ooxml::OOXMLFastContextHandler *,) diff --git a/compilerplugins/clang/unnecessaryvirtual.results b/compilerplugins/clang/unnecessaryvirtual.results index 054f950a361b..cde0a75285f8 100644 --- a/compilerplugins/clang/unnecessaryvirtual.results +++ b/compilerplugins/clang/unnecessaryvirtual.results @@ -20,6 +20,10 @@ basic/source/comp/codegen.cxx:526 _Bool BufferTransformer::processParams() chart2/source/inc/WeakListenerAdapter.hxx:57 void chart::WeakListenerAdapter::disposing(const struct com::sun::star::lang::EventObject &,) +desktop/source/deployment/gui/dp_gui_extlistbox.hxx:200 + int dp_gui::ExtensionBox_Impl::getItemCount()const +desktop/source/deployment/gui/dp_gui_extlistbox.hxx:208 + int dp_gui::ExtensionBox_Impl::getSelIndex()const extensions/source/dbpilots/unoautopilot.hxx:99 class cppu::IPropertyArrayHelper * dbp::OUnoAutoPilot::createArrayHelper()const extensions/source/propctrlr/commoncontrol.hxx:127 @@ -72,8 +76,6 @@ include/comphelper/unique_disposing_ptr.hxx:169 void comphelper::unique_disposing_solar_mutex_reset_ptr::reset(type-parameter-0-0 *,) include/comphelper/weakeventlistener.hxx:119 void comphelper::OWeakListenerAdapter::disposing(const struct com::sun::star::lang::EventObject &,) -include/sfx2/basedlgs.hxx:91 - void SfxModelessDialog::FillInfo(struct SfxChildWinInfo &,)const include/svl/svdde.hxx:237 class DdeData * DdeTopic::Get(enum SotClipboardFormatId,) include/svl/svdde.hxx:238 @@ -86,8 +88,8 @@ include/svl/svdde.hxx:244 _Bool DdeTopic::StartAdviseLoop() include/svl/svdde.hxx:300 void DdeService::~DdeService() -include/svtools/simptabl.hxx:88 - int SvSimpleTable::ColCompare(class SvTreeListEntry *,class SvTreeListEntry *,) +include/svtools/simptabl.hxx:79 + void SvSimpleTable::HBarClick() include/toolkit/controls/geometrycontrolmodel.hxx:184 void OGeometryControlModel::fillProperties(class com::sun::star::uno::Sequence &,class com::sun::star::uno::Sequence &,)const include/vbahelper/vbacollectionimpl.hxx:290 @@ -114,24 +116,20 @@ include/vbahelper/vbareturntypes.hxx:41 type-parameter-0-0 ooo::vba::DefaultReturnHelper::getValue() include/vcl/customweld.hxx:41 class rtl::OUString weld::CustomWidgetController::GetHelpText()const -include/vcl/treelistbox.hxx:471 - class SvTreeListEntry * SvTreeListBox::CreateEntry()const -include/vcl/weld.hxx:96 +include/vcl/weld.hxx:97 void weld::Widget::set_visible(_Bool,) -sc/source/core/opencl/formulagroupcl.cxx:1053 +include/vcl/window.hxx:1155 + class rtl::OString vcl::Window::GetScreenshotId()const +sc/source/core/opencl/formulagroupcl.cxx:1051 _Bool sc::opencl::DynamicKernelSlidingArgument::NeedParallelReduction()const -sc/source/core/opencl/formulagroupcl.cxx:1061 +sc/source/core/opencl/formulagroupcl.cxx:1059 void sc::opencl::DynamicKernelSlidingArgument::GenSlidingWindowFunction(class std::__cxx11::basic_stringstream &,) -sc/source/core/opencl/formulagroupcl.cxx:1340 +sc/source/core/opencl/formulagroupcl.cxx:1338 void sc::opencl::ParallelReductionVectorRef::GenSlidingWindowFunction(class std::__cxx11::basic_stringstream &,) -sc/source/core/opencl/formulagroupcl.cxx:1520 +sc/source/core/opencl/formulagroupcl.cxx:1518 class std::__cxx11::basic_string, class std::allocator > sc::opencl::ParallelReductionVectorRef::GenSlidingWindowDeclRef(_Bool,)const -sc/source/core/opencl/formulagroupcl.cxx:1555 +sc/source/core/opencl/formulagroupcl.cxx:1553 unsigned long sc::opencl::ParallelReductionVectorRef::Marshal(struct _cl_kernel *,int,int,struct _cl_program *,) -sc/source/filter/inc/xestyle.hxx:703 - void XclExpDxf::SaveXmlExt(class XclExpXmlStream &,) -sc/source/ui/inc/anyrefdg.hxx:220 - void ScRefHdlrImpl::dispose() sc/source/ui/vba/vbacondition.hxx:41 class rtl::OUString ScVbaCondition::Formula1() sc/source/ui/vba/vbacondition.hxx:42 @@ -218,58 +216,68 @@ slideshow/source/engine/animationfactory.cxx:447 void slideshow::internal::(anonymous namespace)::GenericAnimation::start(const class std::shared_ptr &,const class std::shared_ptr &,) sw/inc/flypos.hxx:37 void SwPosFlyFrame::~SwPosFlyFrame() -vcl/inc/salframe.hxx:144 +sw/source/ui/dbui/mmaddressblockpage.hxx:235 + class weld::TreeView * SwCustomizeAddressBlockDialog::get_drag_source()const +vcl/inc/salframe.hxx:145 void SalFrame::SetRepresentedURL(const class rtl::OUString &,) -vcl/inc/salframe.hxx:189 +vcl/inc/salframe.hxx:191 void SalFrame::Flush(const class tools::Rectangle &,) -vcl/inc/salinst.hxx:94 +vcl/inc/salinst.hxx:93 _Bool SalInstance::SVMainHook(int *,) -vcl/inc/salmenu.hxx:71 - void SalMenu::SetItemBits(unsigned int,enum MenuItemBits,) vcl/inc/salmenu.hxx:80 _Bool SalMenu::AddMenuBarButton(const struct SalMenuButtonItem &,) vcl/inc/salmenu.hxx:81 void SalMenu::RemoveMenuBarButton(unsigned short,) vcl/inc/salmenu.hxx:93 class tools::Rectangle SalMenu::GetMenuBarButtonRectPixel(unsigned short,class SalFrame *,) -vcl/inc/salobj.hxx:48 +vcl/inc/salobj.hxx:49 void SalObject::Enable(_Bool,) vcl/inc/salprn.hxx:116 enum SalPrinterError SalPrinter::GetErrorCode() -vcl/inc/unx/glyphcache.hxx:57 +vcl/inc/unx/glyphcache.hxx:54 void GlyphCache::~GlyphCache() vcl/inc/unx/gtk/gtkdata.hxx:165 int GtkSalDisplay::CaptureMouse(class SalFrame *,) -vcl/inc/unx/saldata.hxx:65 +vcl/inc/unx/saldata.hxx:51 void X11SalData::Init() -vcl/inc/unx/saldata.hxx:68 +vcl/inc/unx/saldata.hxx:54 void X11SalData::initNWF() -vcl/inc/unx/saldata.hxx:69 +vcl/inc/unx/saldata.hxx:55 void X11SalData::deInitNWF() -vcl/inc/unx/saldisp.hxx:185 +vcl/inc/unx/saldisp.hxx:182 void SalXLib::~SalXLib() -vcl/inc/unx/saldisp.hxx:186 +vcl/inc/unx/saldisp.hxx:183 void SalXLib::Init() -vcl/inc/unx/saldisp.hxx:188 +vcl/inc/unx/saldisp.hxx:185 _Bool SalXLib::Yield(_Bool,_Bool,) -vcl/inc/unx/saldisp.hxx:189 +vcl/inc/unx/saldisp.hxx:186 void SalXLib::Wakeup() -vcl/inc/unx/saldisp.hxx:192 +vcl/inc/unx/saldisp.hxx:189 void SalXLib::Insert(int,void *,int (*)(int, void *),int (*)(int, void *),int (*)(int, void *),) -vcl/inc/unx/saldisp.hxx:196 +vcl/inc/unx/saldisp.hxx:193 void SalXLib::Remove(int,) -vcl/inc/unx/saldisp.hxx:198 +vcl/inc/unx/saldisp.hxx:195 void SalXLib::StartTimer(unsigned long,) -vcl/inc/unx/saldisp.hxx:199 +vcl/inc/unx/saldisp.hxx:196 void SalXLib::StopTimer() -vcl/inc/unx/saldisp.hxx:201 +vcl/inc/unx/saldisp.hxx:198 _Bool SalXLib::CheckTimeout(_Bool,) -vcl/inc/unx/saldisp.hxx:412 +vcl/inc/unx/saldisp.hxx:409 void SalX11Display::Yield() -vcl/inc/unx/salframe.h:210 +vcl/inc/unx/salframe.h:208 void X11SalFrame::updateGraphics(_Bool,) -vcl/inc/unx/salinst.h:47 +vcl/inc/unx/salinst.h:45 class SalX11Display * X11SalInstance::CreateDisplay()const +workdir/../vcl/inc/qt5/Qt5FilePicker.hxx:145 + void Qt5FilePicker::disposing(const struct com::sun::star::lang::EventObject &,) +workdir/../vcl/inc/qt5/Qt5Frame.hxx:158 + void Qt5Frame::registerDragSource(class Qt5DragSource *,) +workdir/../vcl/inc/qt5/Qt5Frame.hxx:159 + void Qt5Frame::deregisterDragSource(const class Qt5DragSource *,) +workdir/../vcl/inc/qt5/Qt5Frame.hxx:160 + void Qt5Frame::registerDropTarget(class Qt5DropTarget *,) +workdir/../vcl/inc/qt5/Qt5Frame.hxx:161 + void Qt5Frame::deregisterDropTarget(const class Qt5DropTarget *,) writerfilter/source/ooxml/OOXMLFactory.hxx:72 void writerfilter::ooxml::OOXMLFactory_ns::startAction(class writerfilter::ooxml::OOXMLFastContextHandler *,) writerfilter/source/ooxml/OOXMLFactory.hxx:73 -- cgit