From 1854f1ddf6ffaddff92d3209f15b68a53f91d2b1 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Tue, 19 May 2020 18:27:34 +0200 Subject: loplugin:unusedfields Change-Id: If179d0a13f3c9f7a49e3efe9027a64368ed600a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94544 Tested-by: Jenkins Tested-by: Noel Grandin Reviewed-by: Noel Grandin --- .../unusedfields.only-used-in-constructor.results | 28 ++++++++++--------- .../clang/unusedfields.readonly.results | 8 ++---- .../clang/unusedfields.untouched.results | 32 ++++++++++++---------- .../clang/unusedfields.writeonly.results | 14 ++++++---- 4 files changed, 43 insertions(+), 39 deletions(-) (limited to 'compilerplugins') diff --git a/compilerplugins/clang/unusedfields.only-used-in-constructor.results b/compilerplugins/clang/unusedfields.only-used-in-constructor.results index bd57ae985122..d86845605b51 100644 --- a/compilerplugins/clang/unusedfields.only-used-in-constructor.results +++ b/compilerplugins/clang/unusedfields.only-used-in-constructor.results @@ -9,9 +9,9 @@ avmedia/source/vlc/wrapper/Types.hxx:43 avmedia/source/vlc/wrapper/Types.hxx:44 libvlc_event_t::(anonymous union)::(anonymous) dummy2 const char * avmedia/source/vlc/wrapper/Types.hxx:45 - libvlc_event_t::(anonymous) padding struct (anonymous struct at /home/noel/libo/avmedia/source/vlc/wrapper/Types.hxx:42:7) + libvlc_event_t::(anonymous) padding struct (anonymous struct at /home/noel/libo2/avmedia/source/vlc/wrapper/Types.hxx:42:7) avmedia/source/vlc/wrapper/Types.hxx:46 - libvlc_event_t u union (anonymous union at /home/noel/libo/avmedia/source/vlc/wrapper/Types.hxx:40:5) + libvlc_event_t u union (anonymous union at /home/noel/libo2/avmedia/source/vlc/wrapper/Types.hxx:40:5) avmedia/source/vlc/wrapper/Types.hxx:52 libvlc_track_description_t psz_name char * basegfx/source/polygon/b2dpolygontriangulator.cxx:112 @@ -86,6 +86,8 @@ cppcanvas/source/mtfrenderer/textaction.cxx:1641 cppcanvas::internal::(anonymous namespace)::OutlineAction maTextLineInfo const tools::TextLineInfo cppu/source/threadpool/threadpool.cxx:361 _uno_ThreadPool dummy sal_Int32 +cppu/source/typelib/typelib.cxx:60 + (anonymous namespace)::AlignSize_Impl nInt16 sal_Int16 cppu/source/uno/check.cxx:38 (anonymous namespace)::C1 n1 sal_Int16 cppu/source/uno/check.cxx:67 @@ -118,8 +120,6 @@ cppu/source/uno/check.cxx:107 (anonymous namespace)::P p2 double cppu/source/uno/check.cxx:115 (anonymous namespace)::second a int -cppu/source/uno/check.cxx:120 - (anonymous namespace)::AlignSize_Impl nInt16 sal_Int16 cppu/source/uno/check.cxx:126 (anonymous namespace)::Char1 c1 char cppu/source/uno/check.cxx:130 @@ -170,8 +170,6 @@ dbaccess/source/core/dataaccess/connection.hxx:102 dbaccess::OConnection m_nInAppend std::atomic dbaccess/source/core/inc/databasecontext.hxx:85 dbaccess::ODatabaseContext m_aBasicDLL class BasicDLL -desktop/qa/desktop_lib/test_desktop_lib.cxx:2782 - class AllSettings & drawinglayer/inc/texture/texture3d.hxx:61 drawinglayer::texture::GeoTexSvxBitmapEx maBitmap class Bitmap drawinglayer/inc/texture/texture3d.hxx:63 @@ -432,6 +430,8 @@ pyuno/source/module/pyuno_impl.hxx:237 pyuno::stRuntimeImpl ob_base PyObject reportdesign/source/core/api/ReportDefinition.cxx:236 reportdesign::(anonymous namespace)::OStyle m_aSize awt::Size +reportdesign/source/filter/xml/xmlExport.cxx:1231 + sal_Int32 sal/qa/osl/condition/osl_Condition.cxx:72 osl_Condition::ctors bRes1 _Bool sal/qa/osl/condition/osl_Condition.cxx:202 @@ -632,7 +632,7 @@ sdext/source/pdfimport/pdfparse/pdfparse.cxx:266 (anonymous namespace)::PDFGrammar::definition trailer rule sfx2/inc/autoredactdialog.hxx:101 SfxAutoRedactDialog m_xDocShell class SfxObjectShellLock -sfx2/source/dialog/basedlgs.cxx:45 +sfx2/source/dialog/basedlgs.cxx:47 SfxModelessDialog_Impl aMoveIdle class Idle sfx2/source/doc/doctempl.cxx:102 DocTempl::(anonymous namespace)::DocTempl_EntryData_Impl mxObjShell class SfxObjectShellLock @@ -732,6 +732,8 @@ sw/source/core/crsr/crbm.cxx:64 (anonymous namespace)::CursorStateHelper m_aSaveState class SwCursorSaveState sw/source/core/inc/swfont.hxx:980 SvStatistics nGetStretchTextSize sal_uInt16 +sw/source/core/inc/txtfrm.hxx:223 + SwTextFrame mbHasBlinkPortions _Bool sw/source/core/layout/dbg_lay.cxx:171 SwImplEnterLeave nAction enum DbgAction sw/source/core/text/inftxt.cxx:565 @@ -840,17 +842,17 @@ vcl/unx/gtk3/gtk3gloactiongroup.cxx:27 (anonymous namespace)::GLOAction parent_instance GObject vcl/unx/gtk3/gtk3glomenu.cxx:14 GLOMenu parent_instance const GMenuModel -vcl/unx/gtk3/gtk3gtkinst.cxx:4757 +vcl/unx/gtk3/gtk3gtkinst.cxx:4761 (anonymous namespace)::GtkInstanceAssistant m_pButtonBox GtkButtonBox * -vcl/unx/gtk3/gtk3gtkinst.cxx:5130 +vcl/unx/gtk3/gtk3gtkinst.cxx:5134 (anonymous namespace)::CrippledViewport viewport GtkViewport -vcl/unx/gtk3/gtk3gtkinst.cxx:5273 +vcl/unx/gtk3/gtk3gtkinst.cxx:5277 (anonymous namespace)::CustomCellRendererSurface parent GtkCellRendererText -vcl/unx/gtk3/gtk3gtkinst.cxx:5281 +vcl/unx/gtk3/gtk3gtkinst.cxx:5285 (anonymous namespace)::CustomCellRendererSurfaceClass parent_class GtkCellRendererTextClass -vcl/unx/gtk3/gtk3gtkinst.cxx:12686 +vcl/unx/gtk3/gtk3gtkinst.cxx:12690 (anonymous namespace)::GtkInstanceComboBox m_pOverlay GtkOverlay * -vcl/unx/gtk3/gtk3gtkinst.cxx:12692 +vcl/unx/gtk3/gtk3gtkinst.cxx:12696 (anonymous namespace)::GtkInstanceComboBox m_pMenuTextRenderer GtkCellRenderer * writerfilter/source/dmapper/PropertyMap.hxx:220 writerfilter::dmapper::SectionPropertyMap m_nDebugSectionNumber sal_Int32 diff --git a/compilerplugins/clang/unusedfields.readonly.results b/compilerplugins/clang/unusedfields.readonly.results index 38f5b00b99ec..5436d4a7e7c7 100644 --- a/compilerplugins/clang/unusedfields.readonly.results +++ b/compilerplugins/clang/unusedfields.readonly.results @@ -156,8 +156,6 @@ cppu/source/uno/check.cxx:107 (anonymous namespace)::P p2 double cppu/source/uno/check.cxx:115 (anonymous namespace)::second a int -cppu/source/uno/check.cxx:120 - (anonymous namespace)::AlignSize_Impl nInt16 sal_Int16 cppu/source/uno/check.cxx:126 (anonymous namespace)::Char1 c1 char cppu/source/uno/check.cxx:130 @@ -337,7 +335,7 @@ include/svx/svdoedge.hxx:160 include/svx/svdpntv.hxx:160 SdrPaintView maDrawinglayerOpt class SvtOptionsDrawinglayer include/unoidl/unoidl.hxx:443 - unoidl::ConstantValue union unoidl::ConstantValue::(anonymous at /home/noel/libo/include/unoidl/unoidl.hxx:443:5) + unoidl::ConstantValue union unoidl::ConstantValue::(anonymous at /home/noel/libo2/include/unoidl/unoidl.hxx:443:5) include/unoidl/unoidl.hxx:444 unoidl::ConstantValue::(anonymous) booleanValue _Bool include/unoidl/unoidl.hxx:445 @@ -415,7 +413,7 @@ sc/inc/attarray.hxx:68 sc/inc/compiler.hxx:129 ScRawToken::(anonymous union)::(anonymous) eItem class ScTableRefToken::Item sc/inc/compiler.hxx:130 - ScRawToken::(anonymous) table struct (anonymous struct at /home/noel/libo/sc/inc/compiler.hxx:127:9) + ScRawToken::(anonymous) table struct (anonymous struct at /home/noel/libo2/sc/inc/compiler.hxx:127:9) sc/inc/compiler.hxx:135 ScRawToken::(anonymous) pMat class ScMatrix * sc/inc/formulagroup.hxx:39 @@ -926,8 +924,6 @@ vcl/inc/WidgetThemeLibrary.hxx:150 vcl::WidgetThemeLibrary_t updateSettings _Bool (*)(struct vcl::WidgetDrawStyle &) vcl/source/app/settings.cxx:196 ImplStyleData maDialogStyle struct DialogStyle -vcl/source/control/combobox.cxx:65 - ComboBox::Impl m_DoubleClickHdl Link vcl/source/control/roadmapwizard.cxx:62 vcl::RoadmapWizardImpl aStateDescriptors vcl::(anonymous namespace)::StateDescriptions vcl/source/control/tabctrl.cxx:79 diff --git a/compilerplugins/clang/unusedfields.untouched.results b/compilerplugins/clang/unusedfields.untouched.results index 2bbfd9204ba4..7d9cfae3bd4d 100644 --- a/compilerplugins/clang/unusedfields.untouched.results +++ b/compilerplugins/clang/unusedfields.untouched.results @@ -5,9 +5,9 @@ avmedia/source/vlc/wrapper/Types.hxx:43 avmedia/source/vlc/wrapper/Types.hxx:44 libvlc_event_t::(anonymous union)::(anonymous) dummy2 const char * avmedia/source/vlc/wrapper/Types.hxx:45 - libvlc_event_t::(anonymous) padding struct (anonymous struct at /home/noel/libo/avmedia/source/vlc/wrapper/Types.hxx:42:7) + libvlc_event_t::(anonymous) padding struct (anonymous struct at /home/noel/libo2/avmedia/source/vlc/wrapper/Types.hxx:42:7) avmedia/source/vlc/wrapper/Types.hxx:46 - libvlc_event_t u union (anonymous union at /home/noel/libo/avmedia/source/vlc/wrapper/Types.hxx:40:5) + libvlc_event_t u union (anonymous union at /home/noel/libo2/avmedia/source/vlc/wrapper/Types.hxx:40:5) avmedia/source/vlc/wrapper/Types.hxx:52 libvlc_track_description_t psz_name char * basctl/source/inc/dlged.hxx:122 @@ -34,12 +34,12 @@ connectivity/source/drivers/mork/MDatabaseMetaData.hxx:30 connectivity::mork::ODatabaseMetaData m_pMetaDataHelper std::unique_ptr cppu/source/threadpool/threadpool.cxx:361 _uno_ThreadPool dummy sal_Int32 +cppu/source/typelib/typelib.cxx:60 + (anonymous namespace)::AlignSize_Impl nInt16 sal_Int16 dbaccess/source/core/inc/databasecontext.hxx:85 dbaccess::ODatabaseContext m_aBasicDLL class BasicDLL dbaccess/source/sdbtools/inc/connectiondependent.hxx:115 sdbtools::ConnectionDependentComponent::EntryGuard m_aMutexGuard ::osl::MutexGuard -desktop/qa/desktop_lib/test_desktop_lib.cxx:2782 - class AllSettings & emfio/source/emfuno/xemfparser.cxx:50 emfio::emfreader::(anonymous namespace)::XEmfParser context_ uno::Reference extensions/source/scanner/scanner.hxx:43 @@ -122,16 +122,16 @@ include/sfx2/msg.hxx:138 SfxType7 pType const std::type_info * include/sfx2/msg.hxx:139 SfxType8 aAttrib struct SfxTypeAttrib [8] -include/sfx2/msg.hxx:139 - SfxType8 pType const std::type_info * include/sfx2/msg.hxx:139 SfxType8 nAttribs sal_uInt16 +include/sfx2/msg.hxx:139 + SfxType8 pType const std::type_info * include/sfx2/msg.hxx:139 SfxType8 createSfxPoolItemFunc std::function -include/sfx2/msg.hxx:140 - SfxType10 pType const std::type_info * include/sfx2/msg.hxx:140 SfxType10 createSfxPoolItemFunc std::function +include/sfx2/msg.hxx:140 + SfxType10 pType const std::type_info * include/sfx2/msg.hxx:140 SfxType10 aAttrib struct SfxTypeAttrib [10] include/sfx2/msg.hxx:140 @@ -180,10 +180,10 @@ include/sfx2/msg.hxx:147 SfxType23 nAttribs sal_uInt16 include/sfx2/msg.hxx:147 SfxType23 aAttrib struct SfxTypeAttrib [23] -include/sfx2/msg.hxx:147 - SfxType23 pType const std::type_info * include/sfx2/msg.hxx:147 SfxType23 createSfxPoolItemFunc std::function +include/sfx2/msg.hxx:147 + SfxType23 pType const std::type_info * include/svtools/genericunodialog.hxx:156 svt::UnoDialogEntryGuard m_aGuard ::osl::MutexGuard include/svtools/unoevent.hxx:163 @@ -252,6 +252,8 @@ pyuno/source/module/pyuno_impl.hxx:137 pyuno::(anonymous) ob_base PyObject pyuno/source/module/pyuno_impl.hxx:237 pyuno::stRuntimeImpl ob_base PyObject +reportdesign/source/filter/xml/xmlExport.cxx:1231 + sal_Int32 reportdesign/source/ui/inc/ReportWindow.hxx:52 rptui::OReportWindow m_pObjFac std::unique_ptr > sal/qa/osl/condition/osl_Condition.cxx:72 @@ -344,7 +346,7 @@ sdext/source/pdfimport/pdfparse/pdfparse.cxx:264 (anonymous namespace)::PDFGrammar::definition value rule sfx2/inc/autoredactdialog.hxx:101 SfxAutoRedactDialog m_xDocShell class SfxObjectShellLock -sfx2/source/dialog/basedlgs.cxx:45 +sfx2/source/dialog/basedlgs.cxx:47 SfxModelessDialog_Impl aMoveIdle class Idle sfx2/source/doc/doctempl.cxx:102 DocTempl::(anonymous namespace)::DocTempl_EntryData_Impl mxObjShell class SfxObjectShellLock @@ -382,6 +384,8 @@ sw/source/core/crsr/crbm.cxx:64 (anonymous namespace)::CursorStateHelper m_aSaveState class SwCursorSaveState sw/source/core/frmedt/fetab.cxx:75 (anonymous namespace)::TableWait m_pWait const std::unique_ptr +sw/source/core/inc/txtfrm.hxx:223 + SwTextFrame mbHasBlinkPortions _Bool sw/source/core/layout/dbg_lay.cxx:171 SwImplEnterLeave nAction enum DbgAction sw/source/uibase/inc/condedit.hxx:43 @@ -442,11 +446,11 @@ vcl/unx/gtk3/a11y/gtk3atkhypertext.cxx:31 (anonymous namespace)::HyperLink atk_hyper_link const AtkHyperlink vcl/unx/gtk3/gtk3gloactiongroup.cxx:27 (anonymous namespace)::GLOAction parent_instance GObject -vcl/unx/gtk3/gtk3gtkinst.cxx:5130 +vcl/unx/gtk3/gtk3gtkinst.cxx:5134 (anonymous namespace)::CrippledViewport viewport GtkViewport -vcl/unx/gtk3/gtk3gtkinst.cxx:5273 +vcl/unx/gtk3/gtk3gtkinst.cxx:5277 (anonymous namespace)::CustomCellRendererSurface parent GtkCellRendererText -vcl/unx/gtk3/gtk3gtkinst.cxx:5281 +vcl/unx/gtk3/gtk3gtkinst.cxx:5285 (anonymous namespace)::CustomCellRendererSurfaceClass parent_class GtkCellRendererTextClass writerfilter/source/ooxml/OOXMLStreamImpl.hxx:43 writerfilter::ooxml::OOXMLStreamImpl mxFastParser css::uno::Reference diff --git a/compilerplugins/clang/unusedfields.writeonly.results b/compilerplugins/clang/unusedfields.writeonly.results index 9c3b323a714f..e7634fe348bf 100644 --- a/compilerplugins/clang/unusedfields.writeonly.results +++ b/compilerplugins/clang/unusedfields.writeonly.results @@ -204,8 +204,6 @@ cppu/source/uno/check.cxx:107 (anonymous namespace)::P p2 double cppu/source/uno/check.cxx:115 (anonymous namespace)::second a int -cppu/source/uno/check.cxx:120 - (anonymous namespace)::AlignSize_Impl nInt16 sal_Int16 cppu/source/uno/check.cxx:126 (anonymous namespace)::Char1 c1 char cppu/source/uno/check.cxx:130 @@ -610,7 +608,7 @@ sc/source/ui/inc/PivotLayoutTreeListData.hxx:38 ScPivotLayoutTreeListData maDataItemValues std::vector > sc/source/ui/inc/preview.hxx:47 ScPreview nTabPage long -sc/source/ui/inc/tabvwsh.hxx:121 +sc/source/ui/inc/tabvwsh.hxx:122 ScTabViewShell xDisProvInterceptor css::uno::Reference sc/source/ui/inc/transobj.hxx:47 ScTransferObj m_aDrawPersistRef SfxObjectShellRef @@ -788,6 +786,10 @@ svx/source/sidebar/glow/GlowPropertyPanel.hxx:42 svx::sidebar::GlowPropertyPanel maGlowRadiusController sfx2::sidebar::ControllerItem svx/source/sidebar/glow/GlowPropertyPanel.hxx:43 svx::sidebar::GlowPropertyPanel maGlowTransparencyController sfx2::sidebar::ControllerItem +svx/source/sidebar/inspector/InspectorTextPanel.hxx:46 + svx::sidebar::InspectorTextPanel mxFontDispatch std::unique_ptr +svx/source/sidebar/inspector/InspectorTextPanel.hxx:48 + svx::sidebar::InspectorTextPanel mxFontHeightDispatch std::unique_ptr svx/source/sidebar/line/LinePropertyPanel.hxx:85 svx::sidebar::LinePropertyPanel maStyleControl sfx2::sidebar::ControllerItem svx/source/sidebar/line/LinePropertyPanel.hxx:86 @@ -897,7 +899,7 @@ sw/source/filter/inc/rtf.hxx:29 sw/source/filter/inc/rtf.hxx:30 RTFSurround::(anonymous union)::(anonymous) nJunk sal_uInt8 sw/source/filter/inc/rtf.hxx:31 - RTFSurround::(anonymous) Flags struct (anonymous struct at /home/noel/libo/sw/source/filter/inc/rtf.hxx:27:9) + RTFSurround::(anonymous) Flags struct (anonymous struct at /home/noel/libo2/sw/source/filter/inc/rtf.hxx:27:9) sw/source/uibase/inc/glossary.hxx:63 SwGlossaryDlg m_xGroupData std::vector > sw/source/uibase/inc/maildispatcher.hxx:146 @@ -1114,7 +1116,7 @@ vcl/unx/gtk3/gtk3glomenu.cxx:14 GLOMenu parent_instance const GMenuModel vcl/unx/gtk3/gtk3gtkinst.cxx:1613 in char * -vcl/unx/gtk3/gtk3gtkinst.cxx:12696 +vcl/unx/gtk3/gtk3gtkinst.cxx:12700 (anonymous namespace)::GtkInstanceComboBox m_xCustomMenuButtonHelper std::unique_ptr vcl/unx/gtk3/gtk3hudawareness.cxx:18 (anonymous namespace)::HudAwarenessHandle connection GDBusConnection * @@ -1146,7 +1148,7 @@ xmloff/source/forms/elementexport.hxx:104 xmloff::OControlExport m_pOuterElement std::unique_ptr xmloff/source/forms/officeforms.hxx:67 xmloff::OFormsRootExport m_pImplElement std::unique_ptr -xmloff/source/text/txtimp.cxx:525 +xmloff/source/text/txtimp.cxx:528 XMLTextImportHelper::Impl m_xFrameImpPrMap rtl::Reference xmlsecurity/inc/certificatechooser.hxx:53 CertificateChooser mvUserData std::vector > -- cgit